Change in ovirt-host-deploy[master]: packaging: offline: add tar dependency
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: offline: add tar dependency
......................................................................
packaging: offline: add tar dependency
Change-Id: I2b04f724b6420738f373330455eb841ea5d8d986
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-host-deploy-offline.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37423
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b04f724b6420738f373330455eb841ea5d8d986
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 10 months
Change in ovirt-engine[master]: core: Fix DAO tests execution
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fix DAO tests execution
......................................................................
core: Fix DAO tests execution
Fixes problems with DAO tests execution introduced in
I89b8ecc31ca3a179886d84ae7f725282c5571c37.
Change-Id: Ibc1fd976c8976b19427f215aca76b9ffc9835ca0
Signed-off-by: Martin Perina <mperina(a)redhat.com>
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/dbfunc-custom.sh
M packaging/dbscripts/uuidgen.sh
2 files changed, 28 insertions(+), 20 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc1fd976c8976b19427f215aca76b9ffc9835ca0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: core: Fix possible NPE in BackendIscsiBondNetworksResourceTest
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Fix possible NPE in BackendIscsiBondNetworksResourceTest
......................................................................
core: Fix possible NPE in BackendIscsiBondNetworksResourceTest
Fixes possible NPE reported by Coverity.
Change-Id: Ic26f2ee7cf605e23aa0c60a4edb83470b8c7458a
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondNetworksResourceTest.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37405
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic26f2ee7cf605e23aa0c60a4edb83470b8c7458a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: core: Fix Coverity issue in AuditLogableBaseTest
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Fix Coverity issue in AuditLogableBaseTest
......................................................................
core: Fix Coverity issue in AuditLogableBaseTest
Fixes false Coverity issue in getVdsWithVdsId() test, when null was
passed to setVds() and valid UUID was passed to setVdsId(). Because
getVds() checks for vdsId when vds is null, the method returned valid
VDS object using vdsId (but Coverity wasn't able to figure it out).
Change-Id: Id1d6b6ab0abc048adcdacbecb465802c0626b34d
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37406
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1d6b6ab0abc048adcdacbecb465802c0626b34d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: core: remove irrelevant rows generated by pg_dump
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: remove irrelevant rows generated by pg_dump
......................................................................
core: remove irrelevant rows generated by pg_dump
Those rows where not recognized correctly from engine-setup
Change-Id: I3e62040ef549feb791c9f694431e2bb98e740a66
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/data/0000_insert_schema_version.sql
M packaging/dbscripts/data/0010_insert_users.sql
M packaging/dbscripts/data/0020_insert_ad_groups.sql
M packaging/dbscripts/data/0030_insert_storage_pool.sql
M packaging/dbscripts/data/0040_insert_vds_groups.sql
M packaging/dbscripts/data/0050_insert_roles.sql
M packaging/dbscripts/data/0060_insert_permissions.sql
M packaging/dbscripts/data/0070_insert_roles_groups.sql
M packaging/dbscripts/data/0080_insert_images.sql
M packaging/dbscripts/data/0090_insert_network.sql
M packaging/dbscripts/data/0100_insert_network_cluster.sql
M packaging/dbscripts/data/0110_insert_vm_static.sql
M packaging/dbscripts/data/0120_insert_vm_device.sql
M packaging/dbscripts/data/0130_insert_vm_ovf_generations.sql
M packaging/dbscripts/data/0140_insert_action_version_map.sql
M packaging/dbscripts/data/0150_insert_event_map.sql
M packaging/dbscripts/data/0160_insert_dwh_history_timekeeping.sql
17 files changed, 0 insertions(+), 136 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Dima Kuznetsov: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/37404
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e62040ef549feb791c9f694431e2bb98e740a66
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5.1]: build: ovirt-engine-3.5.1.1
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: build: ovirt-engine-3.5.1.1
......................................................................
build: ovirt-engine-3.5.1.1
Change-Id: I6063f0ed4647d71115768fbd863436c8155fcd97
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M backend/manager/dependencies/pom.xml
M backend/manager/modules/aaa/pom.xml
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/branding/pom.xml
M backend/manager/modules/builtin-extensions/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/dal/pom.xml
M backend/manager/modules/docs/pom.xml
M backend/manager/modules/extensions-api-root/extensions-api/pom.xml
M backend/manager/modules/extensions-api-root/pom.xml
M backend/manager/modules/extensions-manager/pom.xml
M backend/manager/modules/logger/pom.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/common/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/pom.xml
M backend/manager/modules/restapi/types/pom.xml
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
M backend/manager/modules/scheduler/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M backend/manager/modules/services/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/uutils/pom.xml
M backend/manager/modules/vdsbroker/pom.xml
M backend/manager/modules/welcome/pom.xml
M backend/manager/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
M build-tools-root/checkstyles/pom.xml
M build-tools-root/jboss-modules-maven-plugin/pom.xml
M build-tools-root/ovirt-checkstyle-extension/pom.xml
M build-tools-root/pom.xml
M build/validations/pom.xml
M ear/pom.xml
M frontend/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/pom.xml
M mavenmake/pom.xml
M ovirt-engine.spec.in
M pom.xml
M version.mak
53 files changed, 59 insertions(+), 56 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Gilad Chaplik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/37398
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6063f0ed4647d71115768fbd863436c8155fcd97
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.1
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Leave free space value as null
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Leave free space value as null
......................................................................
core: Leave free space value as null
In Some situations, such as a newly created disks or disks on a storage domain
that's been re-connected, the disk's free space -
StorageDomainDynamic.availableDiskSize is null. This was interpreted
into 0 in some cases, causing a strict reaction from the system, though
is doesn't necessarily means the storage has 0 space. These cases are now using the null value and
do not assume low space.
The value will be updated on the next poll from vdsm, making sure future
behaviour is as is should.
Change-Id: I3379f34c0022eb7066db400f9d9342f8d02fb85f
Bug-Url: https://bugzilla.redhat.com/1177147
Bug-Url: https://bugzilla.redhat.com/1182012
Related-To: https://bugzilla.redhat.com/1176854
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
3 files changed, 17 insertions(+), 17 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/37306
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3379f34c0022eb7066db400f9d9342f8d02fb85f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Fix storage allocation check when merging a snapshot
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix storage allocation check when merging a snapshot
......................................................................
core: Fix storage allocation check when merging a snapshot
When merging a snapshot we need extra available space for the snapshot
being removed, plus this snapshot's child (the one on top of the deleted
one). This patch takes the child-snapshot's size into consideration.
Change-Id: I41213884ed0ca9ddf8354ab7be58f032a6d90673
Bug-Url: https://bugzilla.redhat.com/1178010
Bug-Url: https://bugzilla.redhat.com/1053733
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java
5 files changed, 81 insertions(+), 145 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/37255
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41213884ed0ca9ddf8354ab7be58f032a6d90673
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: core: Fix storage allocation check when merging a snapshot
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix storage allocation check when merging a snapshot
......................................................................
core: Fix storage allocation check when merging a snapshot
When merging a snapshot we need extra available space for the snapshot
being removed, plus this snapshot's child (the one on top of the deleted
one). This patch takes the child-snapshot's size into consideration.
Change-Id: I41213884ed0ca9ddf8354ab7be58f032a6d90673
Bug-Url: https://bugzilla.redhat.com/1178010
Bug-Url: https://bugzilla.redhat.com/1053733
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java
5 files changed, 81 insertions(+), 145 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/37014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41213884ed0ca9ddf8354ab7be58f032a6d90673
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5]: restapi: Allow import of Posix/Gluster export storage domains
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Allow import of Posix/Gluster export storage domains
......................................................................
restapi: Allow import of Posix/Gluster export storage domains
Change-Id: I70b2d4856714b8c95157dd885e91f354071d8c4b
Bug-Url: https://bugzilla.redhat.com/1186375
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java
2 files changed, 13 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37341
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70b2d4856714b8c95157dd885e91f354071d8c4b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
