January 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: VDS code cleanup
by oourfali＠redhat.com 13 Jan '15

13 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: VDS code cleanup ...................................................................... core: VDS code cleanup 1. Renames attributes and methods to camel case so they respect Java Coding Conventions 2. Code cleanup Change-Id: I0f042df0710a9785042e199ed1710dbf4e23a94c Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHooksListModel.java 2 files changed, 302 insertions(+), 327 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f042df0710a9785042e199ed1710dbf4e23a94c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: VdsDynamic code cleanup
by oourfali＠redhat.com 13 Jan '15

13 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: VdsDynamic code cleanup ...................................................................... core: VdsDynamic code cleanup 1. Renames VdsDynamic attributes to camel case so they respect Java Coding Conventions 2. Code cleanup Change-Id: I768776eb247a24bd2d5d0d5e24c17cefbac98c50 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsArchitectureHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataAfterInstallationVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsManagerTest.java 10 files changed, 450 insertions(+), 453 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I768776eb247a24bd2d5d0d5e24c17cefbac98c50 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: fix audit/acct/log messages without profile/authn names
by yzaslavs＠redhat.com 13 Jan '15

13 Jan '15

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: fix audit/acct/log messages without profile/authn names ...................................................................... aaa: fix audit/acct/log messages without profile/authn names some logging/audit records are issued without correct user or without full user name, this makes it difficult to perform problem determination. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1180707 Change-Id: I7776f9f5b93aca96c84fb5a7672e10dded186d05 Signed-off-by: Ravi Nori <rnori(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AcctUtils.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfile.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginAdminUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutBySessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Acct.java 14 files changed, 104 insertions(+), 48 deletions(-) Approvals: Alon Bar-Lev: Verified Ravi Nori: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7776f9f5b93aca96c84fb5a7672e10dded186d05 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: common: Change GetConfiguration query not to refresh session
by yzaslavs＠redhat.com 13 Jan '15

13 Jan '15

Yair Zaslavsky has submitted this change and it was merged. Change subject: common: Change GetConfiguration query not to refresh session ...................................................................... common: Change GetConfiguration query not to refresh session Bug-Url: https://bugzilla.redhat.com/1168842 Change-Id: I9ec8cb46e3fba206d9e1a93df9f985d5c2477fa8 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConfigurationValueParameters.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ec8cb46e3fba206d9e1a93df9f985d5c2477fa8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Adapt UI plugin infra REST session timeout
by tnisan＠redhat.com 12 Jan '15

12 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Adapt UI plugin infra REST session timeout ...................................................................... webadmin: Adapt UI plugin infra REST session timeout Engine session expiration happens through periodic job (SessionDataContainer#cleanExpiredUsersSessions) whose periodicity is the same as Engine session timeout value (UserSessionTimeOutInterval). Because of that, Engine sessions can stay active up to 2 * UserSessionTimeOutInterval. Refer to Einav's comment at http://gerrit.ovirt.org/#/c/36622/ for details. In this patch, we adapt REST session timeout to be 2 * UserSessionTimeOutInterval. Change-Id: Ifa95dba9b1f9647369bd817995c1cbd86f1e528f Bug-Url: https://bugzilla.redhat.com/1172726 Bug-Url: https://bugzilla.redhat.com/1168842 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java 1 file changed, 19 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit http://gerrit.ovirt.org/36738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa95dba9b1f9647369bd817995c1cbd86f1e528f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Adapt UI plugin infra REST session timeout
by vszocs＠redhat.com 12 Jan '15

12 Jan '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Adapt UI plugin infra REST session timeout ...................................................................... webadmin: Adapt UI plugin infra REST session timeout Engine session expiration happens through periodic job (SessionDataContainer#cleanExpiredUsersSessions) whose periodicity is the same as Engine session timeout value (UserSessionTimeOutInterval). Because of that, Engine sessions can stay active up to 2 * UserSessionTimeOutInterval. Refer to Einav's comment at http://gerrit.ovirt.org/#/c/36622/ for details. In this patch, we adapt REST session timeout to be 2 * UserSessionTimeOutInterval. Change-Id: Ifa95dba9b1f9647369bd817995c1cbd86f1e528f Bug-Url: https://bugzilla.redhat.com/1172726 Bug-Url: https://bugzilla.redhat.com/1168842 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java 1 file changed, 18 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa95dba9b1f9647369bd817995c1cbd86f1e528f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: permission sub sub tab
by awels＠redhat.com 12 Jan '15

12 Jan '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: permission sub sub tab ...................................................................... webadmin: permission sub sub tab - Due to the GIN changes some of the permission models where not properly instantiated, this patch fixes the problem for the - Cpu Profile sub tab. - Disk Profile sub tab. Change-Id: I0d42952f82215a51c5b48f9ecf5bf1450b75ef72 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionWithInheritedPermissionListModelTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/CpuProfileListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/DiskProfileListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/StorageModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/CpuProfilesListModelTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/DiskProfilesListModelTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/CpuProfilePermissionModelProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/DiskProfilePermissionModelProvider.java 9 files changed, 21 insertions(+), 15 deletions(-) Approvals: Alexander Wels: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d42952f82215a51c5b48f9ecf5bf1450b75ef72 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine : NPE when adding a VM to a VM pool when there's not ...
by oourfali＠redhat.com 12 Jan '15

12 Jan '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine : NPE when adding a VM to a VM pool when there's not enough storage ...................................................................... engine : NPE when adding a VM to a VM pool when there's not enough storage NPE in the engine log while adding a vm to an existing pool, when there is not enough storage to perform this operation. Change-Id: I0d53e9505054f9476910154a7677d273293f79c0 Bug-Url: https://bugzilla.redhat.com/1179558 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified Vered Volansky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d53e9505054f9476910154a7677d273293f79c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: yaml: add created trigger to jobs running on merged
by dcaroest＠redhat.com 12 Jan '15

12 Jan '15

David Caro has submitted this change and it was merged. Change subject: yaml: add created trigger to jobs running on merged ...................................................................... yaml: add created trigger to jobs running on merged will help identifying issues earlier. Change-Id: I3ce9a83807e8185ba0ac6e39446fdf5095dcd794 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/jobs/ioprocess/ioprocess_create-rpms.yaml M jobs/confs/yaml/jobs/mom/mom_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-engine-extension-aaa-misc/ovirt-engine-extension-aaa-misc_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-engine-extension-logger-log4j/ovirt-engine-extension-logger-log4j_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-host-deploy/ovirt-host-deploy_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-image-uploader/ovirt-image-uploader_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-iso-uploader/ovirt-iso-uploader_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-log-collector/ovirt-log-collector_create-rpms.yaml M jobs/confs/yaml/jobs/vdsm-jsonrpc-java/vdsm-jsonrpc-java_create-rpms.yaml 12 files changed, 17 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified David Caro: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ce9a83807e8185ba0ac6e39446fdf5095dcd794 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Fixed Wrong Usages of the Reserved Word BOOLEAN
by amureini＠redhat.com 12 Jan '15

12 Jan '15

Allon Mureinik has submitted this change and it was merged. Change subject: packaging: Fixed Wrong Usages of the Reserved Word BOOLEAN ...................................................................... packaging: Fixed Wrong Usages of the Reserved Word BOOLEAN Fixed some wrong occurrences of 'boolean' to 'BOOLEAN'. Change-Id: I916e8bf4e45836843886f2b299c8502bfe4f4c70 Bug-Url: https://bugzilla.redhat.com/1073448 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M packaging/dbscripts/storages_sp.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/36358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I916e8bf4e45836843886f2b299c8502bfe4f4c70 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0