December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add memballoon by default to blank template
by tjelinek＠redhat.com 03 Dec '15

03 Dec '15

Tomas Jelinek has submitted this change and it was merged. Change subject: core: add memballoon by default to blank template ...................................................................... core: add memballoon by default to blank template Adds the memballoon to the balnk template. The VMs already created from this template are not touched since there is no way to know if the user wanted to have it enabled or disabled. Change-Id: I529c6b915422f7e507a7d757cbb0bec9d58311cc Bug-Url: https://bugzilla.redhat.com/1280004 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0070_enable_ballon_for_blank_template.sql 1 file changed, 45 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I529c6b915422f7e507a7d757cbb0bec9d58311cc Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: Fix bugzilla link in pom.xml
by sbonazzo＠redhat.com 03 Dec '15

03 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: Fix bugzilla link in pom.xml ...................................................................... build: Fix bugzilla link in pom.xml Fixed the issue tracking link in pom.xml to reflect Red Hat Bugzilla's new structure, where oVirt is its own category. Change-Id: Ic08f85fed228c8295c7f30c7aeaf07588f5e037b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Eyal Edri: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/49553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic08f85fed228c8295c7f30c7aeaf07588f5e037b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-3.6]: build: ovirt-live-3.6.1_rc2
by sbonazzo＠redhat.com 03 Dec '15

03 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.6.1_rc2 ...................................................................... build: ovirt-live-3.6.1_rc2 Change-Id: I6fd5bd90f7e622e607d54f72eab6ca064847c428 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fd5bd90f7e622e607d54f72eab6ca064847c428 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core, restapi: Remove ObjectUtils.equals calls
by amureini＠redhat.com 03 Dec '15

03 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core, restapi: Remove ObjectUtils.equals calls ...................................................................... core, restapi: Remove ObjectUtils.equals calls Replace the usage of Apache Commons Lang's ObjectUtils.equals with Java 7's Objects.equals, as part of the effort to reuse as much of the JDK as possible and bring the usage of unneeded third parties down to a minimum. Change-Id: Ic79b964f60bde9d1811556678f9ddce081e60491 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeQuotaForDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/QosValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackNetworkResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackSubnetResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackSubnetsResource.java 14 files changed, 35 insertions(+), 37 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic79b964f60bde9d1811556678f9ddce081e60491 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: support vmware provider without proxy
by ahadas＠redhat.com 03 Dec '15

03 Dec '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: support vmware provider without proxy ...................................................................... webadmin: support vmware provider without proxy Fix NPE that was thrown when adding external provider of type VMware with no proxy host set. Change-Id: I8357b4f23fb74cd83d1474f9e892cb5f31cb40e8 Bug-Url: https://bugzilla.redhat.com/1284260 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/VmwarePropertiesModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/49581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8357b4f23fb74cd83d1474f9e892cb5f31cb40e8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: Removed unused property
by sbonazzo＠redhat.com 03 Dec '15

03 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: Removed unused property ...................................................................... build: Removed unused property The maven-checkstyle-plugin.version property is not used, and hence can be safely removed. Change-Id: Ib2a0e5336035876603864ad44c0142106ae2ec61 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/pom.xml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Tal Nisan: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/49488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2a0e5336035876603864ad44c0142106ae2ec61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Configure->Roles
by tnisan＠redhat.com 03 Dec '15

03 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Configure->Roles ...................................................................... webadmin: Configure->Roles - Added ability to resize columns in Roles grid. - Added ability to sort on columns in Roles grid. - Added ability to resize columns in Roles sub grid. - Added ability to sort on column in Roles sub grid. Change-Id: Id47bafa4848730d6579d62296fea126aaa55c55c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1284626 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49599 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id47bafa4848730d6579d62296fea126aaa55c55c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Fix: it will add the branch to bz extenals
by dcaro＠redhat.com 02 Dec '15

02 Dec '15

David Caro has submitted this change and it was merged. Change subject: Fix: it will add the branch to bz extenals ...................................................................... Fix: it will add the branch to bz extenals Until now it only did so when updating the external bug, but now it will do so also on new external bugs Change-Id: Ic3aa3e04329772919fa5e9d01b2c3be9621950f7 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/lib/bz.py 1 file changed, 18 insertions(+), 20 deletions(-) Approvals: Eyal Edri: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3aa3e04329772919fa5e9d01b2c3be9621950f7 Gerrit-PatchSet: 4 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Configure->Roles
by awels＠redhat.com 02 Dec '15

02 Dec '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Configure->Roles ...................................................................... webadmin: Configure->Roles - Added ability to resize columns in Roles grid. - Added ability to sort on columns in Roles grid. - Added ability to resize columns in Roles sub grid. - Added ability to sort on column in Roles sub grid. Change-Id: Id47bafa4848730d6579d62296fea126aaa55c55c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1284626 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id47bafa4848730d6579d62296fea126aaa55c55c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Cleaning up any leftover interfaces
by dcaro＠redhat.com 02 Dec '15

02 Dec '15

David Caro has submitted this change and it was merged. Change subject: Cleaning up any leftover interfaces ...................................................................... Cleaning up any leftover interfaces For some reason, on some vms lago execution leaves some leftover interfaces and makes the next run in that slave to fail too, this prevents that while the main reason is addressed in the code Change-Id: I58f79051a9865978f06ad7a8869eca07b77f24d5 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/cleanup_slave.sh 1 file changed, 27 insertions(+), 0 deletions(-) Approvals: Barak Korren: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/49534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58f79051a9865978f06ad7a8869eca07b77f24d5 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0