December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: ovirt-hosted-engine-ha-1.3.3.1
by msivak＠redhat.com 01 Dec '15

01 Dec '15

Martin Sivák has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-1.3.3.1 ...................................................................... build: ovirt-hosted-engine-ha-1.3.3.1 Change-Id: I5b43c161177f74558c1ad6ff28bd45efb74f6f1c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 11 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b43c161177f74558c1ad6ff28bd45efb74f6f1c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix typo in audit log message
by rgolan＠redhat.com 01 Dec '15

01 Dec '15

Roy Golan has submitted this change and it was merged. Change subject: core: Fix typo in audit log message ...................................................................... core: Fix typo in audit log message Change-Id: I1311f46567c5170c95650b76f3af8d5e82a76648 Bug-Url: https://bugzilla.redhat.com/1273378 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Roy Golan: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1311f46567c5170c95650b76f3af8d5e82a76648 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gianluca Cecchi <gianluca.cecchi(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: pki: set TEMPORARY_CERT_FILE to None if we deploy in insecur...
by sbonazzo＠redhat.com 01 Dec '15

01 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: pki: set TEMPORARY_CERT_FILE to None if we deploy in insecure mode ...................................................................... pki: set TEMPORARY_CERT_FILE to None if we deploy in insecure mode Deploy additional host in insecure mode failed, because we use empty temorary certificate, when tring to get SSH key. Change-Id: I18886578e57cf2e3061623d50ca6692ead021ef3 Bug-Url: https://bugzilla.redhat.com/1286429 Signed-off-by: Lukianov Artyom <alukiano(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Artyom Lukianov: Verified -- To view, visit https://gerrit.ovirt.org/49437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18886578e57cf2e3061623d50ca6692ead021ef3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup recently added code for remove-template
by ahadas＠redhat.com 01 Dec '15

01 Dec '15

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup recently added code for remove-template ...................................................................... core: cleanup recently added code for remove-template 1. Simplify the signature of acquireBaseTemplateSuccessorLock 2. Inline variable Change-Id: I2f4435b5c099aef2f4c35af4921a2ecb01e07ecc Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/49494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f4435b5c099aef2f4c35af4921a2ecb01e07ecc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine, webadmin: do not invoke HostSetupNetworksCommand wher...
by tnisan＠redhat.com 01 Dec '15

01 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine,webadmin: do not invoke HostSetupNetworksCommand where no changes were made ...................................................................... engine,webadmin: do not invoke HostSetupNetworksCommand where no changes were made • discard from HostSetupNetworksCommandParameters all bonds and network attachments, which are sent to be updated, but they're equal to already existing Bonds resp. NetworkAttachment in the system. • added method to HostSetupNetworksCommandParameters to figure out if there's any change to be done in them, and this method is used both on UI and bll to figure out, whether changes needs to be done to the system. Change-Id: Icc4c17171ed37cea79ea80aa65b7f2a056ca407c Bug-Url: https://bugzilla.redhat.com/1254320 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetHostBondsByHostIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostSetupNetworksParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 4 files changed, 145 insertions(+), 35 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc4c17171ed37cea79ea80aa65b7f2a056ca407c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: check if pci slot is used by managed device during v...
by tnisan＠redhat.com 01 Dec '15

01 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: check if pci slot is used by managed device during vm nic hotplug ...................................................................... engine: check if pci slot is used by managed device during vm nic hotplug Change-Id: Ic4143197d5c30fc28e58d1203a8490a614a3ca88 Bug-Url: https://bugzilla.redhat.com/1199782 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 32 insertions(+), 2 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49455 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4143197d5c30fc28e58d1203a8490a614a3ca88 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add model servlet
by juan.hernandez＠redhat.com 01 Dec '15

01 Dec '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add model servlet ...................................................................... restapi: Add model servlet This patch adds a servlet that servers the representation of the model, in its original source form and also in the XML and JSON representations. The servlet is available in "/ovirt-engine/api/model". It supports the following content types: application/json application/octet-stream application/xml These content typs can be indicated using the HTTP "Accept" header, as usual, and also the "accept" query parameter: GET /ovirt-engine/api/model?accept=application/json File extensions can also be used to indicate the requested content type. For example, the following request will indicate JSON: GET /ovirt-engine/api/model.json Change-Id: I895a6923849402f8f392336c8aa69e03a8e90183 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/metamodel/pom.xml A backend/manager/modules/restapi/metamodel/server/README.md A backend/manager/modules/restapi/metamodel/server/pom.xml A backend/manager/modules/restapi/metamodel/server/src/main/java/org/ovirt/api/metamodel/server/MimeTypes.java A backend/manager/modules/restapi/metamodel/server/src/main/java/org/ovirt/api/metamodel/server/ModelServlet.java A backend/manager/modules/restapi/metamodel/server/src/main/modules/org/ovirt/api/metamodel-server/main/module.xml M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/jboss-deployment-structure.xml M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml 8 files changed, 344 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49161 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I895a6923849402f8f392336c8aa69e03a8e90183 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add model description as resource
by juan.hernandez＠redhat.com 01 Dec '15

01 Dec '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add model description as resource ...................................................................... restapi: Add model description as resource This patch changes the RESTAPI definition project so that it includes the description of the model in three formats: 1. The original sources inside a "model.jar" resource. 2. The XML representation of the model inside a "model.xml" resource. 3. The JSON representation of the model in side a "model.json" resource. Later patches will change the RESTAPI implementation so that it serves these representations to the callers. Change-Id: I10337939bd268291e177b7658975ba13139a5252 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Model.java M backend/manager/modules/restapi/metamodel/tool/pom.xml A backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/JsonDescriptionGenerator.java M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/Tool.java A backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/XmlDescriptionGenerator.java 6 files changed, 569 insertions(+), 23 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10337939bd268291e177b7658975ba13139a5252 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: HostNetworkAttachementsPersister LinqUtils
by masayag＠redhat.com 01 Dec '15

01 Dec '15

Moti Asayag has submitted this change and it was merged. Change subject: core: HostNetworkAttachementsPersister LinqUtils ...................................................................... core: HostNetworkAttachementsPersister LinqUtils Replace usages of LinqUtils with Java 8's standard streaming API in order to standardize the code and make it easier to read. Change-Id: I000733a3d5e345b93cc1c8ea12dc458653fcedeb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java 1 file changed, 4 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I000733a3d5e345b93cc1c8ea12dc458653fcedeb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: update setupNetworks heartbeat policy only for mgmt ...
by alkaplan＠redhat.com 01 Dec '15

01 Dec '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: update setupNetworks heartbeat policy only for mgmt networks ...................................................................... engine: update setupNetworks heartbeat policy only for mgmt networks Updating the heartbeat policy during the HostSetupNetworks command only makes sense when the connection between the engine and host is modified. This should only be the case when the management network is modified. This patch changes the rpc broker to only reset the heartbeat policy when the management network is changed in any way. Change-Id: I49ef2e8d520c5cfff769375a0d5f9428179e87d8 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1262051 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostSetupNetworksVdsCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 10 files changed, 81 insertions(+), 16 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49ef2e8d520c5cfff769375a0d5f9428179e87d8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0