Change in ovirt-engine[master]: host-deploy: make mktemp relative to TMPDIR
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: host-deploy: make mktemp relative to TMPDIR
......................................................................
host-deploy: make mktemp relative to TMPDIR
add -t parameter dropped in I9c780005a4.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1195672
Change-Id: I0c3260f61b0acbd914d587a59e610a9d627227b3
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Moti Asayag: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38123
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c3260f61b0acbd914d587a59e610a9d627227b3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 10 months
Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: allow SSO robots to fill in the login ...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: userportal, webadmin: allow SSO robots to fill in the login form
......................................................................
userportal, webadmin: allow SSO robots to fill in the login form
Our UI editors/models don't get populated from forms unless a change event fires on
the form (usually on blur when a user types in a value and tabs away from that field
(ValueChangeEvent)).
For the login form, there are third-party SSO applications that "paste" credentials
into the form. LastPass, for example, works fine because it fires a DOM change event
on the fields it pastes into. But here are other solutions that don't fire that
change event after pasting into the fields.
We want to allow those to work by forcing change events on the form fields
when the form is submitted. This patch does just that. Now when the login form
is submitted, "change" is fired on the username, password, and profile fields, which
causes the editor and model to be properly populated, which allows the login to
succeed.
Change-Id: I0364ac5c4524f5260480bca38642a6998d0c9147
Bug-Url: https://bugzilla.redhat.com/1194394
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java
3 files changed, 47 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38017
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0364ac5c4524f5260480bca38642a6998d0c9147
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in ovirt-engine[master]: packaging: backup: respect TMPDIR
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: backup: respect TMPDIR
......................................................................
packaging: backup: respect TMPDIR
Change-Id: Ie3b14776168920b11519c2e2ccfd76173564295a
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/bin/engine-backup.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38122
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3b14776168920b11519c2e2ccfd76173564295a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 10 months
Change in ovirt-engine[master]: core: Refactor FenceActionType
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Refactor FenceActionType
......................................................................
core: Refactor FenceActionType
1. Moves enum to org.ovirt.engine.core.common.businessentities.pm
package
2. Renames enum values according Java Coding Conventions
3. Adds string representation of fence action and use it in
FenceVdsVDSCommand
Change-Id: Ia5b7808fe646139ad251d3614b3d0ab25cdfe4f6
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsPowerDownCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/FenceExecutorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/StartVdsCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceActionType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FenceVdsVDSCommandParameters.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
20 files changed, 117 insertions(+), 99 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/38059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5b7808fe646139ad251d3614b3d0ab25cdfe4f6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in ovirt-engine[ovirt-engine-3.5]: aaa: always set principal when fetching principal record
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: aaa: always set principal when fetching principal record
......................................................................
aaa: always set principal when fetching principal record
although information is available in AuthRecord, and extensions should
fall back into optional Principal anyway (as already do), it would be
nicer to provide both Principal and AuthRecord if available to simplify
extension implementation.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1192791
Change-Id: I1330df35a054713d2e42c00bf70ea52ff0b49021
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java
1 file changed, 26 insertions(+), 10 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/38055
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1330df35a054713d2e42c00bf70ea52ff0b49021
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in ovirt-engine[master]: core: Do not check PM status of host twice
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Do not check PM status of host twice
......................................................................
core: Do not check PM status of host twice
Check for PM status of host only prior to PM Start/Stop actions and not
prior to Status action.
Change-Id: I5238d368469992707ff76694363f9ee493fdaebb
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/37776
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5238d368469992707ff76694363f9ee493fdaebb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in ovirt-engine[master]: aaa: Missing namespace and principal in RSDL (users.add)
by wallaroo1976＠gmail.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Missing namespace and principal in RSDL (users.add)
......................................................................
aaa: Missing namespace and principal in RSDL (users.add)
Change-Id: I3ac8f4f22132e37d58bae65b8d7fafd4ec2fd121
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1188176
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37543
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ac8f4f22132e37d58bae65b8d7fafd4ec2fd121
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 10 months
Change in ovirt-host-deploy[master]: build: fix recent pep8 warnings
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: fix recent pep8 warnings
......................................................................
build: fix recent pep8 warnings
Change-Id: I5a6760fac4b261719ee257b465dd80008b247ec5
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/ovirt_host_deploy/hardware.py
M src/plugins/ovirt-host-deploy/core/misc.py
M src/plugins/ovirt-host-deploy/core/offlinepackager.py
M src/plugins/ovirt-host-deploy/gluster/__init__.py
M src/plugins/ovirt-host-deploy/gluster/glusterpmd.py
M src/plugins/ovirt-host-deploy/gluster/nrpe.py
M src/plugins/ovirt-host-deploy/gluster/packages.py
M src/plugins/ovirt-host-deploy/kdump/packages.py
M src/plugins/ovirt-host-deploy/node/detect.py
M src/plugins/ovirt-host-deploy/node/persist.py
M src/plugins/ovirt-host-deploy/node/vdsm_reg.py
M src/plugins/ovirt-host-deploy/openstack/neutron.py
M src/plugins/ovirt-host-deploy/openstack/neutron_linuxbridge.py
M src/plugins/ovirt-host-deploy/openstack/neutron_openvswitch.py
M src/plugins/ovirt-host-deploy/tune/iosched.py
M src/plugins/ovirt-host-deploy/tune/tuned.py
M src/plugins/ovirt-host-deploy/vdsm/__init__.py
M src/plugins/ovirt-host-deploy/vdsm/bridge.py
M src/plugins/ovirt-host-deploy/vdsm/config.py
M src/plugins/ovirt-host-deploy/vdsm/hardware.py
M src/plugins/ovirt-host-deploy/vdsm/packages.py
M src/plugins/ovirt-host-deploy/vdsm/pki.py
M src/plugins/ovirt-host-deploy/vdsm/software.py
M src/plugins/ovirt-host-deploy/vdsm/vdsmid.py
M src/plugins/ovirt-host-deploy/vdsmhooks/hooks.py
25 files changed, 170 insertions(+), 90 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/38090
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a6760fac4b261719ee257b465dd80008b247ec5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 10 months
Change in otopi[master]: build: fix recent pep8 warnings
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: fix recent pep8 warnings
......................................................................
build: fix recent pep8 warnings
Change-Id: Iaa84feac4efc8f9edaf26e4d076fede633b6ddbb
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/__main__.py
M src/otopi/command.py
M src/otopi/common.py
M src/otopi/context.py
M src/otopi/dialog.py
M src/otopi/filetransaction.py
M src/otopi/main.py
M src/otopi/miniyum.py
M src/otopi/packager.py
M src/otopi/plugin.py
M src/otopi/transaction.py
M src/otopi/util.py
M src/plugins/otopi/core/__init__.py
M src/plugins/otopi/core/config.py
M src/plugins/otopi/core/log.py
M src/plugins/otopi/core/misc.py
M src/plugins/otopi/core/transaction.py
M src/plugins/otopi/dialog/__init__.py
M src/plugins/otopi/dialog/cli.py
M src/plugins/otopi/dialog/human.py
M src/plugins/otopi/dialog/machine.py
M src/plugins/otopi/dialog/misc.py
M src/plugins/otopi/network/__init__.py
M src/plugins/otopi/network/firewalld.py
M src/plugins/otopi/network/hostname.py
M src/plugins/otopi/network/iptables.py
M src/plugins/otopi/network/ssh.py
M src/plugins/otopi/packagers/yumpackager.py
M src/plugins/otopi/services/__init__.py
M src/plugins/otopi/services/openrc.py
M src/plugins/otopi/services/rhel.py
M src/plugins/otopi/services/systemd.py
M src/plugins/otopi/system/__init__.py
M src/plugins/otopi/system/clock.py
M src/plugins/otopi/system/command.py
M src/plugins/otopi/system/info.py
M src/plugins/otopi/system/reboot.py
37 files changed, 237 insertions(+), 148 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/38089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa84feac4efc8f9edaf26e4d076fede633b6ddbb
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 10 months
Change in ovirt-engine[master]: gluster: Fixed a build issue related to VdcActionType
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: gluster: Fixed a build issue related to VdcActionType
......................................................................
gluster: Fixed a build issue related to VdcActionType
Change-Id: Ia577df1bf08f2f1898e53d6fb8af88ebc1b256ac
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Shubhendu Tripathi: Verified
--
To view, visit http://gerrit.ovirt.org/38084
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia577df1bf08f2f1898e53d6fb8af88ebc1b256ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 10 months