Change in ovirt-engine[master]: core: get rid of VdsIdParametersBase
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: get rid of VdsIdParametersBase
......................................................................
core: get rid of VdsIdParametersBase
Replace VdsIdParametersBase with IdQueryParameters and delete it
Change-Id: I8f1308738cd3c3b0da1ead4c66c23ff745a5a76a
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetLunsByVgIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsFenceStatusQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterStorageDevicesQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetUnusedGlusterBricksQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/OvirtNodeUpgradeManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/GetoVirtISOsQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetExistingStorageDomainListQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVgListQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/GetoVirtISOsTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetDeviceListQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDeviceListQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetExistingStorageDomainListParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetLunsByVgIdParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdsIdParametersBase.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
22 files changed, 58 insertions(+), 82 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43036
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f1308738cd3c3b0da1ead4c66c23ff745a5a76a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in jenkins[master]: gerrit triggers reduce load
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: gerrit triggers reduce load
......................................................................
gerrit triggers reduce load
update gerrit trigger-on to:
- exclude drafts
- exclude no-code changes
Change-Id: Ib377aaba7894b3e93efb6698a230deaf2fd2d834
Signed-off-by: Max Kovgan <mvk(a)redhat.com>
---
M jobs/confs/yaml/jobs/jenkins/jenkins_check_yaml.yaml
M jobs/confs/yaml/jobs/jenkins/jenkins_deploy_yamls.yaml
M jobs/confs/yaml/triggers/gerrit.yaml
M jobs/confs/yaml/triggers/ovirt-node.yaml
M jobs/confs/yaml/triggers/standard.yaml
5 files changed, 46 insertions(+), 15 deletions(-)
Approvals:
Eyal Edri: Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
David Caro: Looks good to me
Max Kovgan: Verified; Ready for review
--
To view, visit https://gerrit.ovirt.org/43004
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib377aaba7894b3e93efb6698a230deaf2fd2d834
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Max Kovgan <mvk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com>
9 years, 6 months
Change in ovirt-engine[master]: core: [provider] inadequate test failure output
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: [provider] inadequate test failure output
......................................................................
core: [provider] inadequate test failure output
Adding printing of the exception code and full stack-trace of the
OpenstackResponseException to the engine log.
This is done for both storage and network providers.
Change-Id: I3d12fb0da446fc04bf28132ae288fab391dce91b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1217975
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/AbstractOpenStackStorageProviderProxy.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
5 files changed, 22 insertions(+), 4 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified; Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42779
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d12fb0da446fc04bf28132ae288fab391dce91b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5]: restapi: The "isattached" action should return an action object
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: The "isattached" action should return an action object
......................................................................
restapi: The "isattached" action should return an action object
Currently the "isattached" action of the storage domain resource returns
a storage domain object. For example, the following HTTP request:
POST /api/storagedomains/{storagedomain:id}/isattached
<action>
<host id="{host:id}"/>
</action>
Returns the following response:
<storage_domain id="{storagedomain:id}">
<is_attached>true</is_attached>
</storage_domain>
This isn't correct, because all actions are expected to return an action
object. Returning something different causes issues in the SDKs. The
returned result should look like this:
<action>
<status>
<state>complete</state>
</status>
<is_attached>true</is_attached>
</action>
There is no need to return the storage domain object, only the
"is_attached" flag, and it should be an attribute of the action object,
not of the storage domain.
This patch modifies the storage domain resource so that this action
works as described above.
Change-Id: I4033daddfca8f6d25ee2a1efd03fa2b65a48c6f4
Bug-Url: https://bugzilla.redhat.com/1234937
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java
2 files changed, 28 insertions(+), 21 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/43000
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4033daddfca8f6d25ee2a1efd03fa2b65a48c6f4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: allow null values to be passed into BusinessEntityMap
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: allow null values to be passed into BusinessEntityMap
......................................................................
core: allow null values to be passed into BusinessEntityMap
Change-Id: I2c8917dda7fd1ebea2d6722f1bee3a69f56980d8
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntityMap.java
1 file changed, 9 insertions(+), 2 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
Jenkins CI: Verified
--
To view, visit https://gerrit.ovirt.org/42091
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c8917dda7fd1ebea2d6722f1bee3a69f56980d8
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: renamed method
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: renamed method
......................................................................
core: renamed method
renamed method so its name is more descriptive
notManagementNetwork —> notRemovingManagementNetwork
Change-Id: I7469ab4578d689b89a32daaf2e53c9d2de1de70a
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java
4 files changed, 10 insertions(+), 3 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/36571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7469ab4578d689b89a32daaf2e53c9d2de1de70a
Gerrit-PatchSet: 60
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: tests for NetworkAttachmentValidator
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: tests for NetworkAttachmentValidator
......................................................................
core: tests for NetworkAttachmentValidator
• getNetworkValidator —> createNetworkValidator: a) changed
method visibility to package local to be available for
mocking (stubbing) b) removed caching of NetworkValidator for
easier handling in tests + it was probably premature optmization.
• notManagementNetwork —> notRemovingManagementNetwork: renamed method
to be more descriptive; produced error complaints about unability to
remove… not about not-being management network.
Change-Id: Ia4ba4327b93f8628e234e0e2b23234d8b89902b5
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java
4 files changed, 737 insertions(+), 34 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/36570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4ba4327b93f8628e234e0e2b23234d8b89902b5
Gerrit-PatchSet: 60
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: replaced 'unless' with 'when'
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: replaced 'unless' with 'when'
......................................................................
core: replaced 'unless' with 'when'
'unless' with lot of negations is almost not readable(don't do
something when something is not true). Simple 'when' is much clearer(do it when).
• replaced 'unless' with 'when'
• negated boolean expression passed to this function to preserve same meaning
Change-Id: I027709a58c35836a461362eb4e94313ffd66e79a
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java
1 file changed, 19 insertions(+), 10 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/36569
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I027709a58c35836a461362eb4e94313ffd66e79a
Gerrit-PatchSet: 58
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: Tests for NetworkAttachmentsValidator
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: Tests for NetworkAttachmentsValidator
......................................................................
core: Tests for NetworkAttachmentsValidator
Change-Id: I534a0a200f9a5b7d9faadba766699112b9c6a5b8
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/ValidationResultMatchers.java
3 files changed, 214 insertions(+), 12 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/36147
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I534a0a200f9a5b7d9faadba766699112b9c6a5b8
Gerrit-PatchSet: 59
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: refactor: renamed variables + extracted creating map
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: refactor: renamed variables + extracted creating map
......................................................................
core: refactor: renamed variables + extracted creating map
• Map<String, List<NetworkType>> nicsToNetworks —>
Map<String, List<NetworkType>> nicNameToNetworkTypesMap
• Entry<String, List<NetworkType>> nicToNetworkTypes —>
Entry<String, List<NetworkType>> nicNameToNetworkTypes
• extracted code creating map into method
createNicNameToNetworkTypesMap
• added check for nicName nullity; it should not happen. If it
happens, there's a bug in our code(about which we're immediately
informed).
Change-Id: I7e0a7875a3f5356455f132af23d56d62f00d1989
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java
1 file changed, 34 insertions(+), 19 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/36145
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e0a7875a3f5356455f132af23d56d62f00d1989
Gerrit-PatchSet: 58
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months