Change in ovirt-engine[master]: restapi: Remove unused constant from CDROM resource
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Remove unused constant from CDROM resource
......................................................................
restapi: Remove unused constant from CDROM resource
This patch removes an unused constant with value "current" from the
CDROM resource class.
Change-Id: I8fb4a56b3c485203d790277371ea656277d4b9c1
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCdRomResource.java
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/42810
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fb4a56b3c485203d790277371ea656277d4b9c1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: restapi: Fix RSDL metadata of storage connections
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Fix RSDL metadata of storage connections
......................................................................
restapi: Fix RSDL metadata of storage connections
The RSDL metadata for the top level storage connections server
incorrectly includes the "iqn" parameter instead of "target". This patch
fixes that and reformats the metadata so that it is easier to read.
Change-Id: I8794f96a3400bd19ae76811a06b24361641f0ade
Bug-Url: https://bugzilla.redhat.com/1236718
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 52 insertions(+), 27 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43031
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8794f96a3400bd19ae76811a06b24361641f0ade
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: restapi: Improve display of failed expectations
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Improve display of failed expectations
......................................................................
restapi: Improve display of failed expectations
Currently the display of failed query and action expectations created
with the "eqQueryParams" and "eqActionParams" methods consist on the
names of the fields, without the values, for example:
Expectation failure on verify:
runQuery(
GetVmByVmId,
eqQueryParams(
, field: Id
, field: SessionId
)
): expected: 1, actual: 0
This patch changes the implementation of these methods so that they will
display the names of the fields and the values, for example:
Expectation failure on verify:
runQuery(
GetVmByVmId,
eqQueryParams(
Id=11111111-1111-1111-1111-111111111111,
SessionId=5bb9a592-b4f2-46b5-a375-1ce5a89fd9e2
)
): expected: 1, actual: 0
This helps when developing and debugging tests.
Change-Id: I234e317a9fc7bcb0f16d7eb88ead0fb21cd54733
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/test/util/TestHelper.java
1 file changed, 14 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/42830
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I234e317a9fc7bcb0f16d7eb88ead0fb21cd54733
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Fix typo allowd -> allowed
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix typo allowd -> allowed
......................................................................
core: Fix typo allowd -> allowed
Change-Id: I6dc1e595fee3c8434527febdceac3bd0799d4309
Bug-Url: https://bugzilla.redhat.com/1234761
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43076
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dc1e595fee3c8434527febdceac3bd0799d4309
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: don't contain X-Auth-Header in toString method
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: don't contain X-Auth-Header in toString method
......................................................................
core: don't contain X-Auth-Header in toString method
Change-Id: I90510cd486467eed888ac9a5810d789387160138
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HttpLocationInfo.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40109
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90510cd486467eed888ac9a5810d789387160138
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-live[master]: build: post ovirt-live-3.6.0_alpha2.1
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: post ovirt-live-3.6.0_alpha2.1
......................................................................
build: post ovirt-live-3.6.0_alpha2.1
Change-Id: I18c9bb7b37eabff061b0dbc1bf18cde57c907f43
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/Makefile
M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18c9bb7b37eabff061b0dbc1bf18cde57c907f43
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months