August 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: userportal: Fix NPE in handling of connect automatically

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: userportal: Fix NPE in handling of connect automatically ...................................................................... userportal: Fix NPE in handling of connect automatically ConnectAutomaticallyManager's event handler is being called on each setItems() event, even when it is called with 'null' as items by the infrastructure. Solidified the getAutoConnectableConsoles() method for such case. Change-Id: I02d8757efe3b9188a33af11a880a511e044d225e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257143 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/45364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02d8757efe3b9188a33af11a880a511e044d225e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Fix message when importing SD

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: engine: Fix message when importing SD ...................................................................... engine: Fix message when importing SD When importing a storage domain created on a DC level lower than 3.5, a log event is displayed. The content of the event is now : 'This Data center compatibility version does not support importing a data domain with its entities (VM's and Templates). The imported domain will be imported without them.' Change-Id: I490777b044158029dcacd8baf056c2c73a25bb68 Bug-Url: https://bugzilla.redhat.com/1182109 Signed-off-by: Fred Rolland <frolland(a)redhat.com> (cherry picked from commit d5e2043d60b3701915546f273135a00d38944384) --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Passed CI tests David Caro: Verified Allon Mureinik: Verified; Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/45376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I490777b044158029dcacd8baf056c2c73a25bb68 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: Fix message when importing SD

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Fix message when importing SD ...................................................................... engine: Fix message when importing SD When importing a storage domain created on a DC level lower than 3.5, a log event is displayed. The content of the event is now : 'This Data center compatibility version does not support importing a data domain with its entities (VM's and Templates). The imported domain will be imported without them.' Change-Id: I490777b044158029dcacd8baf056c2c73a25bb68 Bug-Url: https://bugzilla.redhat.com/1182109 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I490777b044158029dcacd8baf056c2c73a25bb68 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: Add connect server call for Fiber Channel

by laravot＠redhat.com

Liron Aravot has submitted this change and it was merged. Change subject: engine: Add connect server call for Fiber Channel ...................................................................... engine: Add connect server call for Fiber Channel Add connect server call for Fiber Channel on following flows : - when a host comes to UP state and one of the SD in the DC is FC - when activate/deactivate a FC SD The connect server call on host will start a rescan to discover new FC devices and resize existing ones. Change-Id: If1acdccb7f6b934db2f33fdb963b3a6710ce449f Bug-Url: https://bugzilla.redhat.com/1242200 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java 2 files changed, 85 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Freddy Rolland: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1acdccb7f6b934db2f33fdb963b3a6710ce449f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: fixing error message length for attaching label to i...

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: engine: fixing error message length for attaching label to interface ...................................................................... engine: fixing error message length for attaching label to interface Change-Id: I636c99e9e6088681f1f0155d50f44c1730b799ac Bug-Url: https://bugzilla.redhat.com/1141512 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I636c99e9e6088681f1f0155d50f44c1730b799ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: userportal: Fix NPE in handling of connect automatically

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: Fix NPE in handling of connect automatically ...................................................................... userportal: Fix NPE in handling of connect automatically ConnectAutomaticallyManager's event handler is being called on each setItems() event, even when it is called with 'null' as items by the infrastructure. Solidified the getAutoConnectableConsoles() method for such case. Change-Id: I02d8757efe3b9188a33af11a880a511e044d225e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257143 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/45352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02d8757efe3b9188a33af11a880a511e044d225e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: userportal: User portal error message when changing VM clust...

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: userportal: User portal error message when changing VM cluster inconsistent with webadmin ...................................................................... userportal: User portal error message when changing VM cluster inconsistent with webadmin The error message displayed in user portal when changing VM cluster is inconsistant with the admin portal. This is because the user portal invoked first the ChangeVMCluster command, and then the UpdateVm command, without checking if the first command was successful. The meaningful message from the first command was overshaddowed by the less accurate message from the second command. Now the second command will only be invoked if the first command was successful. Change-Id: I6daaf41c4e09516eb503178b39d3a603dc11c7d1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1149092 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45150 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6daaf41c4e09516eb503178b39d3a603dc11c7d1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: adding QoS column to networks tab

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: engine: adding QoS column to networks tab ...................................................................... engine: adding QoS column to networks tab Adding a column in the network_view The column is needed to display qos in the Networks main tab Change-Id: I99314acda36195fe708ca3c9f1d685f4cf08227f Bug-Url: https://bugzilla.redhat.com/1180891 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkViewDaoImpl.java M packaging/dbscripts/create_views.sql 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99314acda36195fe708ca3c9f1d685f4cf08227f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: adding QoS column to networks tab

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: adding QoS column to networks tab ...................................................................... webadmin: adding QoS column to networks tab Adding a column in the Networks main tab for host QoS entity for specific network Change-Id: I797e83fda3bb961e17773cdc1ddb4f0834ea97d2 Bug-Url: https://bugzilla.redhat.com/1180891 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkView.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkConditionFieldAutoCompleter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java 3 files changed, 25 insertions(+), 0 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44790 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I797e83fda3bb961e17773cdc1ddb4f0834ea97d2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: network: NetworkView equals incorrect

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: network: NetworkView equals incorrect ...................................................................... network: NetworkView equals incorrect NetworkView.equals does not compare provider names correctly. Change-Id: Ib2135cfa196efc4db9222c90f541a0a14f115d47 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2135cfa196efc4db9222c90f541a0a14f115d47 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 1 month

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits August 2015