August 2015 - Engine-commits - oVirt List Archives

Change in otopi[master]: packagers: dnf: fix gpg ask
by Alon Bar-Lev 05 Aug '15

05 Aug '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: dnf: fix gpg ask ...................................................................... packagers: dnf: fix gpg ask Change-Id: Ic445b20688558d09ddce612be38ebe2dea495821 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/minidnf.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic445b20688558d09ddce612be38ebe2dea495821 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: freeze_filesystems and thaw_filesystems actions
by derez＠redhat.com 05 Aug '15

05 Aug '15

Daniel Erez has submitted this change and it was merged. Change subject: restapi: freeze_filesystems and thaw_filesystems actions ...................................................................... restapi: freeze_filesystems and thaw_filesystems actions Exposing new actions at VM resource: freezefilesystems and thawfilesystems Freezing and thawing are used internally in the backend as part of the live snapshot flow (for Cinder disks). These actions should be exposed to the user for manual invocation if needed (see more details at [1-3]). [1] http://wiki.libvirt.org/page/Qemu_guest_agent [2] http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainFSFreeze [3] http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainFSThaw Change-Id: I80299644f4d19c5e771dd0f15c1284779b2fa498 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java 4 files changed, 68 insertions(+), 0 deletions(-) Approvals: Ori Liel: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80299644f4d19c5e771dd0f15c1284779b2fa498 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal: Fix of FE NPE during too fast clicking at list r...
by tjelinek＠redhat.com 05 Aug '15

05 Aug '15

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: Fix of FE NPE during too fast clicking at list refresh ...................................................................... userportal: Fix of FE NPE during too fast clicking at list refresh Too fast clicking at refresh button in Basic Userportal or Extended Userportal > VMs could cause nearly concurrent run of callbacks in UserPortla(Basic)ListModel#onVmAndPoolLoad() that resulted in getvms() returning null and thus to NPE. * Filds 'vms' and 'pools' transformed to local variables to prevent concurrent data manipulation. * Methods 'onVmAndPoolLoad' and 'finishSearch' moved to parent class - removing code duplication. Change-Id: I8d5bb5587c09cfb8981e51a6cb3202c4f0a9d174 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 3 files changed, 121 insertions(+), 242 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d5bb5587c09cfb8981e51a6cb3202c4f0a9d174 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Move messages to the right place
by amureini＠redhat.com 05 Aug '15

05 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Move messages to the right place ...................................................................... core: Move messages to the right place Messages from EngineError should be I18Ned in the VdsmErrors files, not the AppErrors files. This patch moves the misplaced messages to their correct files and amends AbstractPropertiesTestBase to ensure it. Change-Id: I06248e23e32b7ca2e7f3397e8c0e28e24eb20bf5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/AbstractPropertiesTestBase.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 9 files changed, 19 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Verified Moti Asayag: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06248e23e32b7ca2e7f3397e8c0e28e24eb20bf5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove unused UserCommandBase#initUser
by amureini＠redhat.com 05 Aug '15

05 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused UserCommandBase#initUser ...................................................................... core: Remove unused UserCommandBase#initUser This method is no longer used in the current codebase, and therefore can safely be removed. Since this was the only place in the code to use EngineError.USER_FAILED_POPULATE_DATA, this error code and its translations were also removed. Change-Id: I759e502865d149cc56e059afd7ccc757fa073fc0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/UserCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 0 insertions(+), 38 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/44335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759e502865d149cc56e059afd7ccc757fa073fc0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Remove unused VdsmErrors
by amureini＠redhat.com 05 Aug '15

05 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove unused VdsmErrors ...................................................................... engine: Remove unused VdsmErrors Similarly to d9a87e52e9727d9bb5a1ca7f7425aaaf4fd97503, this patch cleans up redundant messages from VdsmErrors.properties and VdsmErrors.java files. This patch contains: - Refactoring AbstractPropertiesTestBase so it receives the enum to check against as a parameter instead of hard-coded in the class. - Add new EngineErrorsTest test classes in dal, webadmin and frontend modules. - Remove unused error messages from frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.propertie Change-Id: I0e39c94499a3a05020bdb87e643849e1b6680f34 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/EngineErrorsTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/ErrorMessagesTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/AbstractPropertiesTestBase.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties A frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/EngineErrorsTest.java M frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/ErrorMessagesTest.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties A frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/EngineErrorsTest.java M frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/ErrorMessagesTest.java 11 files changed, 43 insertions(+), 43 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Verified Moti Asayag: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e39c94499a3a05020bdb87e643849e1b6680f34 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: One properties file, one enum
by amureini＠redhat.com 05 Aug '15

05 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: One properties file, one enum ...................................................................... core: One properties file, one enum An I18Ned .properties file should only contain translations for a single enum. This patch removes redundant (and wrong) support for multiple enums being translated in a single file from EnumTranslationProperties. Change-Id: I0ebb683a6b9628b7f0efd8d31b66336b7c90ec03 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/EnumTranslationProperties.java 1 file changed, 8 insertions(+), 35 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Verified Moti Asayag: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ebb683a6b9628b7f0efd8d31b66336b7c90ec03 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix broken ClusterValidatorTest
by amureini＠redhat.com 05 Aug '15

05 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix broken ClusterValidatorTest ...................................................................... core: Fix broken ClusterValidatorTest Patch 29d8a1c17d83ae4b79698e012e8e68d16733fa2a intoruced injecting CpuFlagsManagerHandler in ClusterValidator, but failed to mock it properly in the test, thus breaking it. This patch introduces an InjectorRule to the test to fix it. Change-Id: Ib55e805bb60094d037190db0c5907b41a10b4cfe Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/ClusterValidatorTest.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44414 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib55e805bb60094d037190db0c5907b41a10b4cfe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: Fix Deadlock in multiple hostdev RunVmCommands
by ofrenkel＠redhat.com 05 Aug '15

05 Aug '15

Omer Frenkel has submitted this change and it was merged. Change subject: backend: Fix Deadlock in multiple hostdev RunVmCommands ...................................................................... backend: Fix Deadlock in multiple hostdev RunVmCommands The eager synchronous instantiation of Commands in MultipleActionsRunner combined with host device lock being obtained in @PostConstruct of RunVmCommand resulted in deadlock in initCommandsAndReturnValues() method. The deadlock was resolved by moving the acquireHostDeviceLock() to RunVmCommand#canDoAction() and releasing it immediately after check with cooperation of the runVm() method that obtains it again and holds it during the actual host device operations. Change-Id: I64135e46be0dfb6dd71dde862d44f5afa1f1a7b9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1248104 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M packaging/dbscripts/host_device_sp.sql 7 files changed, 43 insertions(+), 20 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44245 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64135e46be0dfb6dd71dde862d44f5afa1f1a7b9 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Fix LUN type for Fiber Channel
by derez＠redhat.com 05 Aug '15

05 Aug '15

Daniel Erez has submitted this change and it was merged. Change subject: engine: Fix LUN type for Fiber Channel ...................................................................... engine: Fix LUN type for Fiber Channel Populate LUN LunType field for Fiber Channel with correct type instead of unknown. Change-Id: I51ab4dcd0d3ee87269d515544dd6caaba62cb1d1 Bug-Url: https://bugzilla.redhat.com/1179921 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommandTest.java 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/44343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51ab4dcd0d3ee87269d515544dd6caaba62cb1d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0