Change in ovirt-engine[master]: core: Determine target connection host specific
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Determine target connection host specific
......................................................................
core: Determine target connection host specific
Since we now have a mechnism to set up host specific target connection
credentials they will be used when connecting a host to a target, if a
host specific credentials exist for the target to connect to, those
credentials will be sent, if not then the regular credentials will be sent.
Change-Id: Id899afb94468356fbc760e6c4ad6f3ceed06bfde
Bug-Url: https://bugzilla.redhat.com/1239266
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StorageConnectionHelper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/storage/StorageConnectionHelperTest.java
4 files changed, 175 insertions(+), 36 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44316
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id899afb94468356fbc760e6c4ad6f3ceed06bfde
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Add backend support for storage connection extension
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add backend support for storage connection extension
......................................................................
core: Add backend support for storage connection extension
Bug-Url: https://bugzilla.redhat.com/1239266
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Change-Id: I4edd54932886cbf8898210b1e3dad86d80798108
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionExtensionCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageServerConnectionExtensionByIdQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageServerConnectionExtensionsByHostIdQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionExtensionCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionExtensionCommandBase.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionExtensionCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageServerConnectionExtensionValidator.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageServerConnectionExtensionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
18 files changed, 337 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44282
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4edd54932886cbf8898210b1e3dad86d80798108
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Add StorageServerConnectionExtension entity
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add StorageServerConnectionExtension entity
......................................................................
core: Add StorageServerConnectionExtension entity
Add the entity, its DAO and the DAO tests
Bug-Url: https://bugzilla.redhat.com/1239266
Change-Id: Iffdb92ff14ab9da76553acabcfa4256ac2fb870e
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/StorageServerConnectionExtension.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionExtensionDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionExtensionDaoImpl.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionExtensionDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/storages_san_sp.sql
A packaging/dbscripts/upgrade/03_06_1780_create_storage_server_connection_extension_table.sql
8 files changed, 412 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffdb92ff14ab9da76553acabcfa4256ac2fb870e
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: Handle null and empty list values in ListModelMult...
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: webadmin: Handle null and empty list values in ListModelMultipleSelectListBox
......................................................................
webadmin: Handle null and empty list values in ListModelMultipleSelectListBox
The code assumed the values are always passed which isn't the case for
new clusters and that caused NPE in GWT and dialogs to appear stuck on
loading.
Change-Id: I77fd69736080eb253f0c3259bda6e3108a2493a2
Bug-Url: https://bugzilla.redhat.com/1248509
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelMultipleSelectListBox.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Roy Golan: Verified
Omer Frenkel: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/44359
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77fd69736080eb253f0c3259bda6e3108a2493a2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Store the Vm ID rather then TEMPLATE ID
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Store the Vm ID rather then TEMPLATE ID
......................................................................
core: Store the Vm ID rather then TEMPLATE ID
The insertion of dedicated vm to host record took the template instead
of vm id.
Change-Id: I1c9fe6c69b127434a2c037264253cd61d7d30770
Bug-Url: https://bugzilla.redhat.com/1249631
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M packaging/dbscripts/vms_sp.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44353
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c9fe6c69b127434a2c037264253cd61d7d30770
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: small format change of QosRangeValidatorTest
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: small format change of QosRangeValidatorTest
......................................................................
core: small format change of QosRangeValidatorTest
Change-Id: I424a0c1592efe03e70cb6a11e26e9e28c4467d65
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/QosRangeValidatorTest.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40903
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I424a0c1592efe03e70cb6a11e26e9e28c4467d65
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-host-deploy[master]: build: vmconsole: fix typo
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: vmconsole: fix typo
......................................................................
build: vmconsole: fix typo
Change-Id: If95643cb56944248875032cca5b82bc8c9b28996
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/plugins/ovirt-host-deploy/vmconsole/Makefile.am
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44361
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If95643cb56944248875032cca5b82bc8c9b28996
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in otopi[master]: build: cleanup Makefile.am order
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: cleanup Makefile.am order
......................................................................
build: cleanup Makefile.am order
Change-Id: I37ff68cae27a248b977f361079cc2516bf86f67c
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile.am
M src/java/Makefile.am
M src/otopi/Makefile.am
M src/plugins/otopi/Makefile.am
M src/plugins/otopi/core/Makefile.am
M src/plugins/otopi/dialog/Makefile.am
M src/plugins/otopi/network/Makefile.am
M src/plugins/otopi/services/Makefile.am
M src/plugins/otopi/system/Makefile.am
9 files changed, 31 insertions(+), 31 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44358
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37ff68cae27a248b977f361079cc2516bf86f67c
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-node-plugin-vdsm[master]: autoreg: replace ovirt-register to vdsm-tool register
by dougsland＠redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: autoreg: replace ovirt-register to vdsm-tool register
......................................................................
autoreg: replace ovirt-register to vdsm-tool register
For now, vdsm-tool register will be used instead of ovirt-register.
Change-Id: I2799ed12682c099b8c7b748d8ff40a180e9fc052
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44258
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M autoinstall/ovirt-node-plugin-vdsm-autoreg
1 file changed, 9 insertions(+), 8 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/44258
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2799ed12682c099b8c7b748d8ff40a180e9fc052
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: display Disk Snapshots sub-tab for Cinder domains
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: display Disk Snapshots sub-tab for Cinder domains
......................................................................
webadmin: display Disk Snapshots sub-tab for Cinder domains
Display 'Disk Snapshots' sub-tab (under Storage main-tab)
for Cinder domains.
Change-Id: I44753507fa0464c867f63fb97fcf0cff96f246c2
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/44159
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44753507fa0464c867f63fb97fcf0cff96f246c2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months