September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: sercon: tests: fix failing tests
by tjelinek＠redhat.com 29 Sep '15

29 Sep '15

Tomas Jelinek has submitted this change and it was merged. Change subject: sercon: tests: fix failing tests ...................................................................... sercon: tests: fix failing tests After commit f620fbe UserProfileDaoTests started to fail, because the testcase change was not stashed in. This patch fixes that. Change-Id: I574827f23ec4376f44fe71d41fe78cd1f012686d Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UserProfileDaoTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/46784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I574827f23ec4376f44fe71d41fe78cd1f012686d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add JAXB annotation to "pm_proxy"
by juan.hernandez＠redhat.com 29 Sep '15

29 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add JAXB annotation to "pm_proxy" ...................................................................... restapi: Add JAXB annotation to "pm_proxy" This annotation is used to make sure that the name of the corresponding Java getter is "getPmProxies", as this, plural, is what is used in the rest of the API. Change-Id: I5a00272d817f2adf010743e136090eb02df631ed Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/HostValidator.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 4 files changed, 13 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46787 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a00272d817f2adf010743e136090eb02df631ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add JAXB annotation to "core"
by juan.hernandez＠redhat.com 29 Sep '15

29 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add JAXB annotation to "core" ...................................................................... restapi: Add JAXB annotation to "core" This annotation is used to make sure that the name of the corresponding Java getter is "getCores", as this, plural, is what is used in the rest of the API. Change-Id: I167a3cedc49314293a81ca66cfbff8595503158c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NumaMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NumaMapperTest.java 3 files changed, 12 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I167a3cedc49314293a81ca66cfbff8595503158c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.6]: fix vmconsoleProxyConfig key
by sbonazzo＠redhat.com 29 Sep '15

29 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: fix vmconsoleProxyConfig key ...................................................................... fix vmconsoleProxyConfig key vmconsoleProxyConfig has been moved to OVESETUP_VMCONSOLE_PROXY_CONFIG Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1267222 Change-Id: Ie0d6470df99e3925d1f29ef9d81897bd91d623fe Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 4110f8f96baf541e1cca30f08eb49006d7524901) --- M centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/ovirt-answer 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46793 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0d6470df99e3925d1f29ef9d81897bd91d623fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: fix vmconsoleProxyConfig key
by sbonazzo＠redhat.com 29 Sep '15

29 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: fix vmconsoleProxyConfig key ...................................................................... fix vmconsoleProxyConfig key vmconsoleProxyConfig has been moved to OVESETUP_VMCONSOLE_PROXY_CONFIG Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1267222 Change-Id: Ie0d6470df99e3925d1f29ef9d81897bd91d623fe Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/ovirt-answer 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46792 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0d6470df99e3925d1f29ef9d81897bd91d623fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: translations update [it-IT]
by ecohen＠redhat.com 29 Sep '15

29 Sep '15

Einav Cohen has submitted this change and it was merged. Change subject: webadmin, userportal: translations update [it-IT] ...................................................................... webadmin, userportal: translations update [it-IT] pulled Italian [it-IT] translation from Zanata oVirt project, master version. Change-Id: I8180ed06979c7c7d6c17e565f77f7f5330c8b947 Bug-Url: https://bugzilla.redhat.com/1110577 Signed-off-by: Einav Cohen <ecohen(a)redhat.com> --- M backend/manager/modules/welcome/src/main/resources/messages_it_IT.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_it_IT.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums_it_IT.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_it_IT.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_it_IT.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_it_IT.properties A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_it_IT.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_it_IT.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_it_IT.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_it_IT.properties A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_it_IT.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_it_IT.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_it_IT.properties 13 files changed, 3,102 insertions(+), 148 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Einav Cohen: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/31263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8180ed06979c7c7d6c17e565f77f7f5330c8b947 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: introducing italian
by ecohen＠redhat.com 29 Sep '15

29 Sep '15

Einav Cohen has submitted this change and it was merged. Change subject: engine: introducing italian ...................................................................... engine: introducing italian adding Italian [it-IT] to the available ovirt engine locales. Change-Id: I10ffccafa49baeb31187e3fc7738b76fe5d11371 Bug-Url: https://bugzilla.redhat.com/1110577 Signed-off-by: Einav Cohen <ecohen(a)redhat.com> --- M backend/manager/modules/utils/src/main/resources/languages.properties M backend/manager/modules/welcome/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml 5 files changed, 8 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Einav Cohen: Verified -- To view, visit https://gerrit.ovirt.org/31262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10ffccafa49baeb31187e3fc7738b76fe5d11371 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Correctly finish Remove VM Pool job
by mperina＠redhat.com 29 Sep '15

29 Sep '15

Martin Peřina has submitted this change and it was merged. Change subject: core: Correctly finish Remove VM Pool job ...................................................................... core: Correctly finish Remove VM Pool job For every VM in the pool removed, the endAction() of the corresponding RemoveVmCommand must be called. For this purpose, RemoveVmCommand must be parent command of all async tasks, not RemoveVmPoolCommand. Also, adding IDs of all async tasks to the return value of RemoveVmPoolCommand (RemoveVmCommand also needed to be fixed to add the IDs to the correct list if RemoveVmCommand is executed as internal command). Change-Id: I49e31a498cf57dc8a1b459c79fbe4566cd3d0e89 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257132 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49e31a498cf57dc8a1b459c79fbe4566cd3d0e89 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add support for mocking multiple matrix parameters
by juan.hernandez＠redhat.com 29 Sep '15

29 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add support for mocking multiple matrix parameters ...................................................................... restapi: Add support for mocking multiple matrix parameters Currently it isn't possible to mock more than one matrix parameter with values. This patch adds support for that. Change-Id: I6ec835b0839db23d7d0d02f806b5510d299ebf99 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ec835b0839db23d7d0d02f806b5510d299ebf99 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Rename "storage" and "host_storage" elements
by juan.hernandez＠redhat.com 29 Sep '15

29 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename "storage" and "host_storage" elements ...................................................................... restapi: Rename "storage" and "host_storage" elements The host storage collection used the "storage" and "host_storage" elements and the "Storage" and "HostStorage" complex types to report the storage associated to a host: GET /hosts/{host:id}/storage <host_storage> <storage> ... </storage> <storage> ... </storage> ... </host_storage> This doesn't follow the pattern used in the rest of the API, where the outer element is a plural name and the inner element is the same name but in singular. This patch changes the host storage collection to use "host_storages" as the outer element and "host_storage" as the inner element: GET /hosts/{host:id}/storage <host_storages> <host_storage> ... </host_storage> <host_storage> ... </host_storage> ... </host_storage> Change-Id: If83d2a3551f6ddeee36009fe9b6b5a406813746d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/LinkHelperTest.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostStorageResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageVolumeGroupMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/LunDiskMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageDomainMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageVolumeGroupMapperTest.java 21 files changed, 125 insertions(+), 84 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If83d2a3551f6ddeee36009fe9b6b5a406813746d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0