January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: Revert "core, webadmin: Not validating HostNetworkQos values"
by tnisan＠redhat.com 31 Jan '16

31 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: Revert "core,webadmin: Not validating HostNetworkQos values" ...................................................................... Revert "core,webadmin: Not validating HostNetworkQos values" This reverts commit 261b920b6a5e49d0ef0cc0d6b62284de2640529b. This patch is probably mostly beneficial — it tries to workaround i ssues with problematically testable *Parameters class, and allows this *Parameters class to be validated using bean validation. However doing so unravels another design issues, which cannot be easily solved, and it's (at least for now) easier to rewrite those validations programmatically and introduce duplicate code, than trying to use bean validation. Bug-Url: https://bugzilla.redhat.com/1271220 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Change-Id: Ia6298732a81570795ab1be6f140acaf3d1cb5f88 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/businessentities/SeparateNewAndModifiedInstances.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 2 insertions(+), 71 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6298732a81570795ab1be6f140acaf3d1cb5f88 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: webadmin: Release keys removed from the console title
by piotr.kliczewski＠gmail.com 30 Jan '16

30 Jan '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Release keys removed from the console title ...................................................................... webadmin: Release keys removed from the console title With this fix, the console title does not contain release keys. This info is displayed by virt-viewer out of the box. Change-Id: I620d55a83ec6f0231fb6eb9f882a10fa98199f9e Bug-Url: https://bugzilla.redhat.com/1295659 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 2 files changed, 1 insertion(+), 20 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/52862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I620d55a83ec6f0231fb6eb9f882a10fa98199f9e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Reimplement PKIResources.Resource as class
by piotr.kliczewski＠gmail.com 30 Jan '16

30 Jan '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Reimplement PKIResources.Resource as class ...................................................................... core: Reimplement PKIResources.Resource as class PKIResources.Resource was implemented as enum, but we used Config value as a parameter for enum constructor. This caused troubles because enum constructor was called during class loading but Config values are initialized during Backend EJB initialization, so if some called PKIResourceServlet to get certificate before Backend was initialized, enum was initialized incorrectly and servlet returned error until JBoss instance was restarted. 1. Connection refused - before JBoss instance starts up 2. 404 Not Found - JBoss instance is up, but engine application is not yet deployed 3. 500 Internal Server Error - in server log there's our custom message describing that certificate is not available yet as engine startup hasn't been finished yet 4. Success, certificate returned - JBoss instance is up, engine application fisnished initialization Change-Id: If5fea4db033bddb5103cd412627e2506d5167a3d Bug-Url: https://bugzilla.redhat.com/1302776 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCACertificateQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/RegisterServlet.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java 5 files changed, 70 insertions(+), 18 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52878 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5fea4db033bddb5103cd412627e2506d5167a3d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Fixed retention strategi
by dcaro＠redhat.com 28 Jan '16

28 Jan '16

David Caro has submitted this change and it was merged. Change subject: Fixed retention strategi ...................................................................... Fixed retention strategi The latest update changed the way the xml looks and made all the retention strategies empty, filling up the disk... This needs the custom jjb that has the fix (1.4.1.dev50.ovirt) Change-Id: I773be36b6b0f0b2d56ce03f9faddfc2ce10aaaca Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/defaults.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.5.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml M jobs/confs/yaml/templates/create-rpms_mock.yaml M jobs/confs/yaml/templates/install-rpm-sanity.yaml M jobs/confs/yaml/templates/ovirt-node-job-templates.yaml M jobs/confs/yaml/templates/standard-stage.yaml 8 files changed, 55 insertions(+), 15 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/52872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I773be36b6b0f0b2d56ce03f9faddfc2ce10aaaca Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: core: Reimplement PKIResources.Resource as class
by piotr.kliczewski＠gmail.com 28 Jan '16

28 Jan '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Reimplement PKIResources.Resource as class ...................................................................... core: Reimplement PKIResources.Resource as class PKIResources.Resource was implemented as enum, but we used Config value as a parameter for enum constructor. This caused troubles because enum constructor was called during class loading but Config values are initialized during Backend EJB initialization, so if some called PKIResourceServlet to get certificate before Backend was initialized, enum was initialized incorrectly and servlet returned error until JBoss instance was restarted. 1. Connection refused - before JBoss instance starts up 2. 404 Not Found - JBoss instance is up, but engine application is not yet deployed 3. 500 Internal Server Error - in server log there's our custom message describing that certificate is not available yet as engine startup hasn't been finished yet 4. Success, certificate returned - JBoss instance is up, engine application fisnished initialization Change-Id: If5fea4db033bddb5103cd412627e2506d5167a3d Bug-Url: https://bugzilla.redhat.com/1294025 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCACertificateQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployPKIUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployVmconsoleUnit.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/RegisterServlet.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java 6 files changed, 71 insertions(+), 19 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52870 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5fea4db033bddb5103cd412627e2506d5167a3d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Reimplement PKIResources.Resource as class
by piotr.kliczewski＠gmail.com 28 Jan '16

28 Jan '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Reimplement PKIResources.Resource as class ...................................................................... core: Reimplement PKIResources.Resource as class PKIResources.Resource was implemented as enum, but we used Config value as a parameter for enum constructor. This caused troubles because enum constructor was called during class loading but Config values are initialized during Backend EJB initialization, so if some called PKIResourceServlet to get certificate before Backend was initialized, enum was initialized incorrectly and servlet returned error until JBoss instance was restarted. 1. Connection refused - before JBoss instance starts up 2. 404 Not Found - JBoss instance is up, but engine application is not yet deployed 3. 500 Internal Server Error - in server log there's our custom message describing that certificate is not available yet as engine startup hasn't been finished yet 4. Success, certificate returned - JBoss instance is up, engine application fisnished initialization Change-Id: If5fea4db033bddb5103cd412627e2506d5167a3d Bug-Url: https://bugzilla.redhat.com/1294025 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCACertificateQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployPKIUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployVmconsoleUnit.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/RegisterServlet.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java 6 files changed, 71 insertions(+), 19 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5fea4db033bddb5103cd412627e2506d5167a3d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: new pool dialog contained the sub version field
by tnisan＠redhat.com 28 Jan '16

28 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: new pool dialog contained the sub version field ...................................................................... webadmin: new pool dialog contained the sub version field The sub version field is from the template dialog - it should not be present in the new pool dialog. Change-Id: I36188c0e666377ea076caea1966004a47632f338 Bug-Url: https://bugzilla.redhat.com/1302372 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolNewPopupWidget.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36188c0e666377ea076caea1966004a47632f338 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Consistent relation memory - guaranteed memory
by tjelinek＠redhat.com 28 Jan '16

28 Jan '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Consistent relation memory - guaranteed memory ...................................................................... webadmin: Consistent relation memory - guaranteed memory * Null checks added * If value of 'System' > 'Memory Size' is changed, value of 'Resource allocation' > 'Physical Memory Guaranteed' is set to (memory size / cluster over-commitment factor) for following dialogs: * New/Edit VM * New Pool * Values 'Memory Size' and 'Physical Memory Guaranteed' are not connected for dialogs: * New/Edit Template * New/Edit Instance Type Change-Id: I2c1d257b6edc81964272474510afd004248b9e39 Bug-Url: https://bugzilla.redhat.com/1302582 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NewInstanceTypeModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NonClusterModelBehaviorBase.java 8 files changed, 16 insertions(+), 28 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c1d257b6edc81964272474510afd004248b9e39 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Reimplement PKIResources.Resource as class
by mperina＠redhat.com 28 Jan '16

28 Jan '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Reimplement PKIResources.Resource as class ...................................................................... core: Reimplement PKIResources.Resource as class PKIResources.Resource was implemented as enum, but we used Config value as a parameter for enum constructor. This caused troubles because enum constructor was called during class loading but Config values are initialized during Backend EJB initialization, so if some called PKIResourceServlet to get certificate before Backend was initialized, enum was initialized incorrectly and servlet returned error until JBoss instance was restarted. 1. Connection refused - before JBoss instance starts up 2. 404 Not Found - JBoss instance is up, but engine application is not yet deployed 3. 500 Internal Server Error - in server log there's our custom message describing that certificate is not available yet as engine startup hasn't been finished yet 4. Success, certificate returned - JBoss instance is up, engine application fisnished initialization Change-Id: If5fea4db033bddb5103cd412627e2506d5167a3d Bug-Url: https://bugzilla.redhat.com/1294025 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCACertificateQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployPKIUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployVmconsoleUnit.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/RegisterServlet.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java 6 files changed, 71 insertions(+), 19 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5fea4db033bddb5103cd412627e2506d5167a3d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Uninitialized host fails to open hardware tab
by tnisan＠redhat.com 28 Jan '16

28 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Uninitialized host fails to open hardware tab ...................................................................... webadmin: Uninitialized host fails to open hardware tab When hardware sub-tab is selected for uninitialized host, a NPE is thrown since the HBA collection is null. In addition, the HostGeneralModel.oupdateAlerts() will be the only place where alerts are being handled. Change-Id: I759e49a0418c9a0c21e917b153d4c1ef4c877911 Bug-Url: https://bugzilla.redhat.com/1293574 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 3 files changed, 2 insertions(+), 12 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/52855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759e49a0418c9a0c21e917b153d4c1ef4c877911 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0