Change in ovirt-node-plugin-vdsm[ovirt-3.6]: Revert "Disable engine registration if hosted engine is conf...
by dougsland＠redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: Revert "Disable engine registration if hosted engine is configured"
......................................................................
Revert "Disable engine registration if hosted engine is configured"
This reverts commit b18463d1992ac0c130c1b4d448e2eb9f8b7627c2.
Change-Id: I2eba6f8d632f6ffe7f264447612acda9c4e3f829
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1301486
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
Reviewed-on: https://gerrit.ovirt.org/52675
Continuous-Integration: Jenkins CI
Reviewed-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reviewed-by: Ryan Barry <rbarry(a)redhat.com>
Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com>
Continuous-Integration: Fabian Deutsch <fabiand(a)redhat.com>
Tested-by: Fabian Deutsch <fabiand(a)redhat.com>
(cherry picked from commit 673ad1aabda99907d0d612e290098f8393011cef)
Reviewed-on: https://gerrit.ovirt.org/52709
Continuous-Integration: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Tested-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/engine_page.py
1 file changed, 0 insertions(+), 26 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52709
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2eba6f8d632f6ffe7f264447612acda9c4e3f829
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-node-plugin-vdsm[master]: Revert "Disable engine registration if hosted engine is conf...
by fabiand＠redhat.com
Fabian Deutsch has submitted this change and it was merged.
Change subject: Revert "Disable engine registration if hosted engine is configured"
......................................................................
Revert "Disable engine registration if hosted engine is configured"
This reverts commit b18463d1992ac0c130c1b4d448e2eb9f8b7627c2.
Change-Id: I2eba6f8d632f6ffe7f264447612acda9c4e3f829
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1301486
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
Reviewed-on: https://gerrit.ovirt.org/52675
Continuous-Integration: Jenkins CI
Reviewed-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reviewed-by: Ryan Barry <rbarry(a)redhat.com>
Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com>
Continuous-Integration: Fabian Deutsch <fabiand(a)redhat.com>
Tested-by: Fabian Deutsch <fabiand(a)redhat.com>
---
M src/engine_page.py
1 file changed, 0 insertions(+), 26 deletions(-)
Approvals:
Fabian Deutsch: Verified; Looks good to me, approved; Passed CI tests
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Ryan Barry: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/52675
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2eba6f8d632f6ffe7f264447612acda9c4e3f829
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in mom[master]: Release mom-0.5.2
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Release mom-0.5.2
......................................................................
Release mom-0.5.2
Change-Id: Idf9747a8f94b3b1ca8966a9ea8e7b9fadf24b363
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/52695
Continuous-Integration: Jenkins CI
---
M configure.ac
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52695
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf9747a8f94b3b1ca8966a9ea8e7b9fadf24b363
Gerrit-PatchSet: 2
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: User version 3.1 of the servlet API
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: User version 3.1 of the servlet API
......................................................................
core: User version 3.1 of the servlet API
The engine has been recently updated to use WildFly 10, which uses
version 3.1 of the servlet API. But we are still building using version
3.0. This doesn't currently create any problem, but it is good practice
to build with the same version that will be used during runtime. This
patch changes the POM files so that the version used for the build will
be the same used during runtime.
Change-Id: I15f299a5ecbf462305785ec23aae0527ac76c2d5
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/aaa/pom.xml
M backend/manager/modules/branding/pom.xml
M backend/manager/modules/docs/pom.xml
M backend/manager/modules/enginesso/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/services/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/uutils/pom.xml
M backend/manager/modules/welcome/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M pom.xml
14 files changed, 15 insertions(+), 16 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52552
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15f299a5ecbf462305785ec23aae0527ac76c2d5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: Do not assign creator as owner to VMs from pool
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Do not assign creator as owner to VMs from pool
......................................................................
engine: Do not assign creator as owner to VMs from pool
If VM is created to attach it to a VM pool, do not assign its creator as
owner in any case. Assignment of a user to the VM in this case will
designate this VM as occupied and prevent other users from taking it.
This assignment happens currently when pool creator doesn't have
MANIPULATE_PERMISSIONS role on the pool VMs.
Change-Id: I6af18a2b7caa8181523a277f4d63cc688e69a59e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1298094
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/52697
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6af18a2b7caa8181523a277f4d63cc688e69a59e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in mom[master]: Convert big numbers to i8 type in the XML-RPC interface
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Convert big numbers to i8 type in the XML-RPC interface
......................................................................
Convert big numbers to i8 type in the XML-RPC interface
Make sure all numbers are transferable over XML-RPC with its signed
32 bit limitation. All numbers greater than that need to be converted
to long and the XML-RPC server configured to serialize long type
using the i8 extension.
Python supports reading i8 in the default configuration
(https://bugs.python.org/issue2985) and so the clients do not have to
do anything special.
Change-Id: Ief62c3dd120c9efca7e270b768e394f467ac3417
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1294833
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51396
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Continuous-Integration: Jenkins CI
---
M mom.spec.in
M mom/MOMFuncs.py
M mom/RPCServer.py
M mom/__init__.py
M momd
M tests/GeneralTests.py
6 files changed, 63 insertions(+), 2 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/51396
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief62c3dd120c9efca7e270b768e394f467ac3417
Gerrit-PatchSet: 8
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: frontend: Fix name uniqueness chack in ImportVmModel
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Fix name uniqueness chack in ImportVmModel
......................................................................
frontend: Fix name uniqueness chack in ImportVmModel
Now when checking the name uniqueness of imported VM, we check for conflict
only VMs in target data center.
To facilitate this the data center loading part from
ImportVmFromExportDomainModel#doInit() and
ImportVmFromExternalProviderModel#doInit() had to be extracted into special
helpers withDataCenterLoaded() that are used to wrap the setItems() method doing
the name uniqueness analysis - since it requires access to storagePool.id.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=912263
Change-Id: I86c8b17bee0d676bc09c758e98439e5d672eb885
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java
4 files changed, 102 insertions(+), 79 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/52574
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86c8b17bee0d676bc09c758e98439e5d672eb885
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: fetch guest agent nic statistics from vm analyzers
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fetch guest agent nic statistics from vm analyzers
......................................................................
core: fetch guest agent nic statistics from vm analyzers
Use Stream API to fetch the dynamic information for guest
agent NICs instead of holding them in VmsMonitoring.
Change-Id: I8355501738ee83fdd3e1cf7ba8a00d4650a180e1
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
2 files changed, 10 insertions(+), 5 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/52683
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8355501738ee83fdd3e1cf7ba8a00d4650a180e1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: Add Attach Disk/Cpu profile permissions to all Import/Export...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: Add Attach Disk/Cpu profile permissions to all Import/Export capable roles
......................................................................
Add Attach Disk/Cpu profile permissions to all Import/Export capable roles
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1255405
Change-Id: Id2cc0e56bd1ea4a5f9aeac0684a2acc3998a5e9d
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_00_0230_add_profile_perms_to_import_export.sql
1 file changed, 14 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Martin Sivák: Verified
--
To view, visit https://gerrit.ovirt.org/51880
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2cc0e56bd1ea4a5f9aeac0684a2acc3998a5e9d
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: adding missing ctors
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: adding missing ctors
......................................................................
core: adding missing ctors
When the AsyncTaskManager creats a command it creates it without
the context.
When migrating the different flows to use coco rather than rely on
the async task manager, the modified commands that were used as child
commands until now will be created by the async task manager.
This patch adds the missing parameters ctor to those commands.
Change-Id: Iaae93b7e6b041749c4911806bfdb78fa4afe166c
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotFromTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveTemplateSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AddImageFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateImageTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ExtendImageSizeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/MoveImageGroupCommand.java
9 files changed, 36 insertions(+), 0 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52573
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaae93b7e6b041749c4911806bfdb78fa4afe166c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months