Change in ovirt-engine[master]: core: stateless vms monitoring - monitoredVms
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: stateless vms monitoring - monitoredVms
......................................................................
core: stateless vms monitoring - monitoredVms
As part of the effort to make VmsMonitoring stateless, the
monitoredVms are passed directly to the perform method instead
of holding them as a member of VmsMonitoring.
Change-Id: I016830e33d2d0ae6bbacb23b4d8eeeaace93af8b
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVmStatsRefresher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVmStatsRefresher.java
3 files changed, 14 insertions(+), 19 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/52707
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I016830e33d2d0ae6bbacb23b4d8eeeaace93af8b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: webadmin: Release keys removed from the console title
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Release keys removed from the console title
......................................................................
webadmin: Release keys removed from the console title
With this fix, the console title does not contain release keys.
This info is displayed by virt-viewer out of the box.
Change-Id: I620d55a83ec6f0231fb6eb9f882a10fa98199f9e
Bug-Url: https://bugzilla.redhat.com/1295659
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
2 files changed, 1 insertion(+), 20 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Marek Libra: Verified
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/51634
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I620d55a83ec6f0231fb6eb9f882a10fa98199f9e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: retrieve vm-jobs only if needed
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: retrieve vm-jobs only if needed
......................................................................
core: retrieve vm-jobs only if needed
Previously, we queried vm-jobs from the database every time that
VMs-monitoring was executed - even when no VM reported vm-jobs.
Now, the vm-jobs are queried only if a VM reports VM-jobs.
The query is now done by VmAnalyzer instead of VmsMonitoring.
The drawback of this approach is that when we poll host with 100
running VMs, we will query the database 100 times in worse case
(when all VMs report VM-jobs) instead of only once. However, the
common case is that no VM or only a few report VM-jobs and thus
this approach is better for the common case. For the extreme case
a mechanism that caches the jobs instead of querying the database
everytime would be the best solution.
Change-Id: I2b9ee3c1bb0c6d7316a1a4f73488a550a1f994e5
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
2 files changed, 2 insertions(+), 14 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/52696
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b9ee3c1bb0c6d7316a1a4f73488a550a1f994e5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: core: allow to balance migrate vm that run on specific host
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: allow to balance migrate vm that run on specific host
......................................................................
core: allow to balance migrate vm that run on specific host
Change-Id: I1b34923ad7659d426eca51eb360c6ae0add01a54
Bug-Url: https://bugzilla.redhat.com/1258751
Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com>
Signed-off-by: Martin Sivák <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/FindVmAndDestinations.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/utils/FindVmAndDestinationsTest.java
2 files changed, 88 insertions(+), 7 deletions(-)
Approvals:
Martin Sivák: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Artyom Lukianov: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/52739
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b34923ad7659d426eca51eb360c6ae0add01a54
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: remove AuditLogDirector from VmAnalyzer ctor
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove AuditLogDirector from VmAnalyzer ctor
......................................................................
core: remove AuditLogDirector from VmAnalyzer ctor
Change-Id: Ibaa44436d6ed5492bee75f65aa9e3084abaa1f0a
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java
3 files changed, 20 insertions(+), 15 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/52684
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibaa44436d6ed5492bee75f65aa9e3084abaa1f0a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in jenkins[master]: ovirt-dwh: fix build on fc22
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-dwh: fix build on fc22
......................................................................
ovirt-dwh: fix build on fc22
Change-Id: I5d787e46ebae3b711b7f2ad9a8e674cbb1a5ef62
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-dwh/ovirt-dwh_create-rpms.yaml
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52778
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d787e46ebae3b711b7f2ad9a8e674cbb1a5ef62
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: SubTabNetworkHostView's comparator
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: SubTabNetworkHostView's comparator
......................................................................
core: SubTabNetworkHostView's comparator
Reuse PairFirstComparator's logic instead of reimplementing it.
Change-Id: I68a4beaa8a209a104e618858107363adda3ebb66
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java
1 file changed, 10 insertions(+), 12 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51918
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68a4beaa8a209a104e618858107363adda3ebb66
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: NetworkClusterListModel comparator
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: NetworkClusterListModel comparator
......................................................................
core: NetworkClusterListModel comparator
Reuse the PairFirstComparator instead of re-implementing it.
Change-Id: I5001980ce903703be674ae697d530f712dc1daf5
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java
1 file changed, 3 insertions(+), 10 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50452
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5001980ce903703be674ae697d530f712dc1daf5
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: Separate VmDevicesMonitoring from VmsMonitoring
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Separate VmDevicesMonitoring from VmsMonitoring
......................................................................
core: Separate VmDevicesMonitoring from VmsMonitoring
Move all processing related to VM device changes into a separate
singleton class named VmDevicesMonitoring. It supports processing of two
types of changes:
1. VM status events, when device information hash returned by VDSM is
compared to the previous one. FullList VDSM command is used then to get
information about all devices. Processing result of FullList that was
run somewhere else is also supported.
2. Individual changes in devices. This mechanism may be used in the
future to process 'device changed' events from VDSM.
The current device information hash is kept inside VmDevicesMonitoring
and stored in the DB only to restore it after Engine restart.
Change-Id: I8726c74c155f447aee4a93912fb8606430abeb1b
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVmStatsRefresher.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmDevicesMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmStatsRefresher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsListFetcher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVmStatsRefresher.java
M packaging/dbscripts/vms_sp.sql
11 files changed, 710 insertions(+), 308 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/51535
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8726c74c155f447aee4a93912fb8606430abeb1b
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Prevent host device copy on pinned host mismatch
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Prevent host device copy on pinned host mismatch
......................................................................
core: Prevent host device copy on pinned host mismatch
When user is creating a VM from pre-existing configuration
(Template/Snapshot/Import) and has the ability to override the "pinned-to-host"
value, it results in a VM being created with inconsistent host devices attached
(device name from old host, but with new host id).
Most cases were covered by VmDeviceUtils#copyVmDevices and import by
VmDeviceUtils#addImportedOtherDevices.
Change-Id: Iaa99737928d1111b994d7827fd6aade0d249ff28
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1281428
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
2 files changed, 47 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Martin Peřina: Looks good to me, approved
Martin Betak: Verified
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Marek Libra: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/52493
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa99737928d1111b994d7827fd6aade0d249ff28
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months