Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Remove deprecated message when trying to move a disk
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Remove deprecated message when trying to move a disk
......................................................................
webadmin: Remove deprecated message when trying to move a disk
When trying to move a disk in webadmin the message "Note: Some target
domains are filtered by the source domain type (file/block)" appears in
the dialog, this message is for a past limitation not relevant since 3.5
and should be removed
Change-Id: I4166234dce45f3297d8304a7975c597b542173e2
Bug-Url: https://bugzilla.redhat.com/1390305
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
3 files changed, 0 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65914
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4166234dce45f3297d8304a7975c597b542173e2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years
Change in ovirt-engine[master]: webadmin: Remove deprecated message when trying to move a disk
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Remove deprecated message when trying to move a disk
......................................................................
webadmin: Remove deprecated message when trying to move a disk
When trying to move a disk in webadmin the message "Note: Some target
domains are filtered by the source domain type (file/block)" appears in
the dialog, this message is for a past limitation not relevant since 3.5
and should be removed
Change-Id: I4166234dce45f3297d8304a7975c597b542173e2
Bug-Url: https://bugzilla.redhat.com/1390305
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
3 files changed, 0 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65913
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4166234dce45f3297d8304a7975c597b542173e2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: Move SCSI reservation indication to DiskVmElement
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Move SCSI reservation indication to DiskVmElement
......................................................................
core: Move SCSI reservation indication to DiskVmElement
As the indication to whether a disk uses SCSI reservation is relevant to
disks and not all the other types of devices it should be moved from
VmDevice to DiskVmElement.
Aside for that the fact that the LunDisk entity contains that indication
is plain wrong and redundant and thus removed.
Additionally a test was added to MigrateVmCommand which is the most
important command regarding the SCSI reservation
Bug-Url: https://bugzilla.redhat.com/1362152
Change-Id: I3e70748464637720edc2d023becd8d8bcf648ce1
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MigrateVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmValidatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskVmElement.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/LunDisk.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskVmElementDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskVmElementDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskAttachmentMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ReadOnlyDiskModel.java
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/disk_vm_element_sp.sql
A packaging/dbscripts/upgrade/04_01_0380_move_scsi_reservation_to_disk_vm_element.sql
M packaging/dbscripts/vm_device_sp.sql
30 files changed, 211 insertions(+), 174 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/65711
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e70748464637720edc2d023becd8d8bcf648ce1
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: Add test fo RefreshLunsSizeCommandTest::getFailedLuns
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add test fo RefreshLunsSizeCommandTest::getFailedLuns
......................................................................
core: Add test fo RefreshLunsSizeCommandTest::getFailedLuns
Change-Id: I958f0cd27545ad7de07313123a1ba3f14b2ad19f
Related-to: https://bugzilla.redhat.com/1389455
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommandTest.java
2 files changed, 39 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65859
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I958f0cd27545ad7de07313123a1ba3f14b2ad19f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in jenkins[master]: Fixed bug in test experimental repo emails
by gshinar＠redhat.com
Gil Shinar has submitted this change and it was merged.
Change subject: Fixed bug in test experimental repo emails
......................................................................
Fixed bug in test experimental repo emails
Change-Id: I6499af52decf971a3e49d7001516cff38305466c
Signed-off-by: Gil Shinar <gshinar(a)redhat.com>
---
M jobs/confs/groovy-scripts/test-ovirt-repo.groovy
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Gil Shinar: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65890
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6499af52decf971a3e49d7001516cff38305466c
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: webadmin, userportal: Clean up Editor fields before Model obj...
by gshereme＠redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: webadmin,userportal: Clean up Editor fields before Model objects
......................................................................
webadmin,userportal: Clean up Editor fields before Model objects
This ensures that GWT widgets hooked to UiCommon models have
a chance to do their cleanup *before* we destroy the models.
This fixes NPEs where a model is already destroyed but a GWT
widget attempts to access its properties such as the property
change event, see AbstractUiCommandButton#cleanup for example.
Change-Id: I3dd8e320a774c35db8262e9a297557243a99ef5a
Bug-Url: https://bugzilla.redhat.com/1389998
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorDriver.java
2 files changed, 20 insertions(+), 20 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/65899
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3dd8e320a774c35db8262e9a297557243a99ef5a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: Remove redundant initializer
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Remove redundant initializer
......................................................................
core: Remove redundant initializer
Change-Id: I88e5a23a0c7718be1320bd590cc56460d36e8b40
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/65868
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88e5a23a0c7718be1320bd590cc56460d36e8b40
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: webadmin: Add POSIX domain creation to Data Center "Guide Me"
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Add POSIX domain creation to Data Center "Guide Me"
......................................................................
webadmin: Add POSIX domain creation to Data Center "Guide Me"
Bug-Ur: https://bugzilla.redhat.com/1359943
Change-Id: I17b26369caea5471af29febd2afecd4b371d5d0c
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
1 file changed, 127 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65902
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17b26369caea5471af29febd2afecd4b371d5d0c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-hosted-engine-ha[master]: service: Disable stdout capture in systemd
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: service: Disable stdout capture in systemd
......................................................................
service: Disable stdout capture in systemd
Standard output for agent and broker system services
disabled to prevent log duplications and keep logging
only to the custom log files (agent and broker logs)
Change-Id: I65b49fad3a2a915019231341e64d161aad9d4660
Bug-Url: https://bugzilla.redhat.com/1376559
Signed-off-by: Yanir Quinn <yquinn(a)redhat.com>
---
M initscripts/ovirt-ha-agent.service.in
M initscripts/ovirt-ha-broker.service.in
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yanir Quinn: Verified
--
To view, visit https://gerrit.ovirt.org/65800
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65b49fad3a2a915019231341e64d161aad9d4660
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: frontend: fix custom compatibility version field setting
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: fix custom compatibility version field setting
......................................................................
frontend: fix custom compatibility version field setting
Fix the UI behaviour of both webadmin and userportal for setting the
VM->System tab->Custom compatibility version (CCV) drop down menu to
avoid refreshing and reseting the value after manually changing it by
the user.
Changing the CCV field value for a VM/pool/template (choosing a
different value from pool down menu), causes few VM fields
values to be reseted and refreshed back to template defaults.
this fix avoid from the CCV field itself to be reseted as well.
This change influence the template field and CCV field behaviour for the
following use cases:
New VM
New VM from Template
New pool
Edit pool
Change-Id: I4e20cdb868740241338d007686adf9f8d780bb61
Bug-Url: https://bugzilla.redhat.com/1367405
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmFromTemplateModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
8 files changed, 65 insertions(+), 15 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/65809
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e20cdb868740241338d007686adf9f8d780bb61
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years