Change in jenkins[master]: Fix issue with mock_genconfig
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged.
Change subject: Fix issue with mock_genconfig
......................................................................
Fix issue with mock_genconfig
Recent change to mock_configs/*_proxied.sfg files causes mock_genconfig
to crash when trying to use them. This fixes the issue and also adds
some CI tests for mock_genconfig.
Change-Id: Ib4757fc2d304f0bc6e8197da0b5f2a3f75794f00
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-939
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
M automation/check-patch.packages
M automation/check-patch.packages.el7
R automation/check-patch.repos.el7
M automation/check-patch.sh
M mock_configs/mock_genconfig
5 files changed, 23 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved; Ready for merge
Martin Sivák: Looks good to me
Eyal Edri: Looks good to me
Barak Korren: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68453
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4757fc2d304f0bc6e8197da0b5f2a3f75794f00
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <david(a)dcaro.es>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: restapi: StepMapper - adding progress
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: restapi: StepMapper - adding progress
......................................................................
restapi: StepMapper - adding progress
Change-Id: I2e3d88651b816fdeab475484821411eeb5ac4635
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StepMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StepMapperTest.java
2 files changed, 5 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67135
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e3d88651b816fdeab475484821411eeb5ac4635
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: webadmin, userportal: Fix GWT debug compilation errors
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin,userportal: Fix GWT debug compilation errors
......................................................................
webadmin,userportal: Fix GWT debug compilation errors
1. updated SLF4J class overrides from gwt-extension project
(those are messing with Java classpath when executing GWT
debugger via gwt-maven-plugin)
- sadly, we cannot remove them since the "common" backend
code (used by frontend) uses SLF4J for logging :-(
2. updated frontend classes to not use SLF4J API
3. modified WebAdmin & UserPortal pom.xml files
- added `jboss-concurrency-api` (provided scope) to avoid
class loading issues (this is due to DashboardDataServlet
being part of frontend.jar)
- removed unnecessary `maven-compiler-plugin` declaration
since it's applied anyway
All frontend code should NOT use SLF4J API.
Instead, all frontend code should use java.util.logging API
directly, which is the standard way of doing logging in GWT.
Change-Id: I573e14332ab10fd5cb844c6fe03e1614c32fcc72
Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com>
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/StringFormat.java
M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/slf4j/Logger.java
M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/slf4j/LoggerFactory.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
7 files changed, 36 insertions(+), 31 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Scott Dickerson: Verified
--
To view, visit https://gerrit.ovirt.org/68073
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I573e14332ab10fd5cb844c6fe03e1614c32fcc72
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine-sdk-java[sdk_4.0]: Add example of how to change fencing option
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add example of how to change fencing option
......................................................................
Add example of how to change fencing option
This patch adds an example that shows how to add or update an option of
one of the fencing agents of a host.
Change-Id: Ia78e1f352c08827c73b3addd91334f778643345d
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit e7a643d9b14dc23eafdda5efdce2e80e1f6c9bd5)
---
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/UpdateFencingOptions.java
1 file changed, 115 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68462
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia78e1f352c08827c73b3addd91334f778643345d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in jenkins[master]: add more history to standard jobs
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: add more history to standard jobs
......................................................................
add more history to standard jobs
Keeping 120 builds isn't enough for
check-patch jobs, we need longer
history based on days, even if it takes
more space, so we can debug issues
that fail specific jobs.
Change-Id: Ie64637fc15084e2a56be76c8f5f6377e3d87eb53
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/yaml/templates/standard-stage.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68439
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie64637fc15084e2a56be76c8f5f6377e3d87eb53
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <david(a)dcaro.es>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine-sdk-java[master]: Add example of how to change fencing option
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add example of how to change fencing option
......................................................................
Add example of how to change fencing option
This patch adds an example that shows how to add or update an option of
one of the fencing agents of a host.
Change-Id: Ia78e1f352c08827c73b3addd91334f778643345d
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/UpdateFencingOptions.java
1 file changed, 115 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia78e1f352c08827c73b3addd91334f778643345d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: adding HostJobInfo/VDSError toString()
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: core: adding HostJobInfo/VDSError toString()
......................................................................
core: adding HostJobInfo/VDSError toString()
This change adds the toString() to the HostJobInfo/VDSError classes.
HostJobInfo represents the current status of a job executed by vdsm -
returned when executing the GetHostJobsVDSCommand. The results of the
execution are logged - adding toString() will make it readable.
HostJobInfo has VDSError member, therefore a toString() is being added
to it as well.
before:
FINISH, GetHostJobsVDSCommand, return:
{a4c19e06-df55-4ca0-9d7e-3a12fcf59929=
org.ovirt.engine.core.common.businessentities.HostJobInfo@3657bbdd}
after:
FINISH, GetHostJobsVDSCommand, return:
{fcd3813b-6783-442e-8659-ab6b2b11879b=
HostJobInfo:{id='fcd3813b-6783-442e-8659-ab6b2b11879b',
type='storage', description='move_device', status='failed',
progress='null', error='VDSError:{code='UnsupportedOperationErr',
message='Operation not supported'}'}}
Change-Id: I75c1033f573bec4719a8f40f7f0408217c4fbab6
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostJobInfo.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VDSError.java
2 files changed, 22 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/68405
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75c1033f573bec4719a8f40f7f0408217c4fbab6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: engine : Change LeaseState to LeaseStatus
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: engine : Change LeaseState to LeaseStatus
......................................................................
engine : Change LeaseState to LeaseStatus
VDSM will report the lease state with more information as before.
Currently, the engine only needs to know if the lease is free or not.
Change-Id: I221ff47bcf5876d1ce67ba6818ec99a0c1979f25
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/VdsmImagePoller.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LeaseState.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LeaseStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Image.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVolumeInfoVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
8 files changed, 81 insertions(+), 19 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67945
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I221ff47bcf5876d1ce67ba6818ec99a0c1979f25
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-log-collector[ovirt-log-collector-4.1]: automation: move to stable repo
by Code Review
>From Rafael Martins <rmartins(a)redhat.com>:
Rafael Martins has submitted this change and it was merged.
Change subject: automation: move to stable repo
......................................................................
automation: move to stable repo
Change-Id: Iab8624ed0346ec7d148eeda994f08cadda3ebcd3
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M automation/build-artifacts.repos
M automation/check-merged.repos
M automation/check-patch.repos
3 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Jenkins CI: Passed CI tests
Rafael Martins: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68454
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab8624ed0346ec7d148eeda994f08cadda3ebcd3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: Make sure the ClusterPolicy does not cause NPEs
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: core: Make sure the ClusterPolicy does not cause NPEs
......................................................................
core: Make sure the ClusterPolicy does not cause NPEs
Change-Id: Ib6a94d9cd51429372649b9ac7949b67cc8122bc9
Bug-Url: https://bugzilla.redhat.com/1404231
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/ClusterPolicy.java
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Denis Chaplygin: Verified; Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68357
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6a94d9cd51429372649b9ac7949b67cc8122bc9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years