Change in ovirt-engine[ovirt-engine-3.6]: packaging: setup: require correct otopi version
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: setup: require correct otopi version
......................................................................
packaging: setup: require correct otopi version
We require otopi to be 1.4.0 when in reality we really
need it to be >= 1.4.1.
Change-Id: Id046512091b4644ff0cefbb4d7a940cbdb750f4e
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Sandro Bonazzola: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/55304
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id046512091b4644ff0cefbb4d7a940cbdb750f4e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: v2v: Set disk's boot flag after conversion
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: v2v: Set disk's boot flag after conversion
......................................................................
v2v: Set disk's boot flag after conversion
Disk's boot flag is determined in ConvertVmCommand when disk information
is already written into DB. Because of that the boot flag needs to be
written after that in a separate call.
Change-Id: Ic9603163bfd03bfe248ebfdd227e4a9087568706
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1308914
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoImpl.java
M packaging/dbscripts/base_disks_sp.sql
5 files changed, 45 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55357
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9603163bfd03bfe248ebfdd227e4a9087568706
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: engine: Enabled editing HE in pre-upgrade script
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Enabled editing HE in pre-upgrade script
......................................................................
engine: Enabled editing HE in pre-upgrade script
Set the 'AllowEditingHostedEngine' update configuration value to true,
as the feature is now supported.
Change-Id: I2b69fd8a29815b9e4a468440093c3c6d286258b2
Bug-Url: https://bugzilla.redhat.com/1290478
Signed-off-by: Phillip Bailey <phbailey(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Phillip Bailey: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55129
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b69fd8a29815b9e4a468440093c3c6d286258b2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in jenkins[master]: Added vdsm el7 checks
by dcaro＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Added vdsm el7 checks
......................................................................
Added vdsm el7 checks
Change-Id: I109bf40742e3092edf025a86c47fdf2921400161
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/projects/vdsm/vdsm_standard.yaml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Yaniv Bronhaim: Looks good to me
Jenkins CI: Passed CI tests
David Caro: Verified; Ready for merge
Dan Kenigsberg: Looks good to me
--
To view, visit https://gerrit.ovirt.org/55381
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I109bf40742e3092edf025a86c47fdf2921400161
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: kerbldap: Add deprecation message to engine-manage-domains
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: kerbldap: Add deprecation message to engine-manage-domains
......................................................................
kerbldap: Add deprecation message to engine-manage-domains
engine-manage-domains is part of kerberos/ldap provider which is
deprecated in 3.5 in favor of aaa-ldap extension. There's already
deprecation warning message display during engine-setup, but this
patch add another warning into engine-manage-domains itself to make
this breaking change more visible.
Change-Id: I0750983235a22c852d96ff025d7dbd28817f3765
Bug-Url: https://bugzilla.redhat.com/1319635
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified
Oved Ourfali: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55207
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0750983235a22c852d96ff025d7dbd28817f3765
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-live[ovirt-live-3.6]: oVirt Live 3.6.4
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: oVirt Live 3.6.4
......................................................................
oVirt Live 3.6.4
Change-Id: Ia7e64d19fa1f966cca77ae3252e01773c1ffcdbb
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/Makefile
M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55388
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7e64d19fa1f966cca77ae3252e01773c1ffcdbb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: packaging: setup: Allow to exit with Ctrl-C at ISO domain pa...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Allow to exit with Ctrl-C at ISO domain path prompt
......................................................................
packaging: setup: Allow to exit with Ctrl-C at ISO domain path prompt
setup wasn't allowing the user to exit with Ctrl-C during Local ISO
domain path prompt, until a valid path provided.
This patch fixes this.
Change-Id: I020f217307d83ea425986c74fbf3a52d11f7fc1e
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1274220
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Lev Veyde: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55320
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I020f217307d83ea425986c74fbf3a52d11f7fc1e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: webadmin: Check selected item for null before running plugin...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Check selected item for null before running plugins on it
......................................................................
webadmin: Check selected item for null before running plugins on it
Invoking plugins on events with selected item being null
results in a NPE in SystemTreeItemObject
This situation can happen when an item is unselected in the tree.
Change-Id: I4f4f2ed5c3d32c5396e51e17c7fa9e91c588eddc
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginEventHandler.java
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Marcin Mirecki: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54894
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f4f2ed5c3d32c5396e51e17c7fa9e91c588eddc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: core: remove redundant null checks in vm-analyzer
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove redundant null checks in vm-analyzer
......................................................................
core: remove redundant null checks in vm-analyzer
In processDownVms when detecting that the dbVm is null we used to check
if the dynamic data of the VM exists in the database. This is not needed
anymore since it must exist - if dbVm is null and the dynamic data is
not in the DB it means that it is an external VM and when detecting an
external VM we immediately insert its dynamic part to the DB and don't
continue to the processDownVms method in the same iteration.
Same goes to the updateRepository method.
Change-Id: I7e23388c12c0724eb4c852f1e6f142f5ba72fd3f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 2 insertions(+), 6 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55305
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e23388c12c0724eb4c852f1e6f142f5ba72fd3f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in otopi[master]: doc: Fix spelling errors in README*
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: doc: Fix spelling errors in README*
......................................................................
doc: Fix spelling errors in README*
Change-Id: Icbf91b6a1f9f10c6a046a39132d4bd19c0977ec2
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M README
M README.API
M README.config-query
M README.debug-plugins
M README.dialog
M README.environment
6 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Yedidyah Bar David: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55382
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbf91b6a1f9f10c6a046a39132d4bd19c0977ec2
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month