March 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core, db: View, DAO and entity updates for Image Upload fron...
by mlipchuk＠redhat.com 09 Mar '16

09 Mar '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core, db: View, DAO and entity updates for Image Upload frontend ...................................................................... core, db: View, DAO and entity updates for Image Upload frontend The progress of an image upload operation will be displayed in the webadmin disk list. In addition, the status will be used to determine which upload operations are available (upload, pause, resume, etc). In order to do this efficiently, the status of the upload should be made available to the UI via propagation through the Disk object. Change-Id: I3f9c17839086a2b63c65246a785b53cbe2829885 Related-To: https://bugzilla.redhat.com/1091377 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Disk.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDaoImpl.java M packaging/dbscripts/create_views.sql 3 files changed, 63 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Greg Padgett: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f9c17839086a2b63c65246a785b53cbe2829885 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Fix parsing of XML strings
by juan.hernandez＠redhat.com 09 Mar '16

09 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Fix parsing of XML strings ...................................................................... Fix parsing of XML strings Current when a element containing an string is parsed, the next element is ignored, because there are two calls to the "next_element" method. This patch fixes that and adds a test to check it. Change-Id: Iadf02e6c9d546ab3566c1e2ebc20144cd554d43e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java A sdk/tests/test_fault_reader.py 2 files changed, 92 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadf02e6c9d546ab3566c1e2ebc20144cd554d43e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[master]: packaging: set version to 4.0.0
by sradco＠redhat.com 09 Mar '16

09 Mar '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: set version to 4.0.0 ...................................................................... packaging: set version to 4.0.0 Change version from 4.0 to 4.0.0. If we're going to have zstream (4.0.1) we should start with 4.0.0 avoiding semantic changes in versioning. Change-Id: I16cb7a777ae14771f7851edfcf3bf097e2f93ccb Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M version.mak 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Shirly Radco: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54554 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16cb7a777ae14771f7851edfcf3bf097e2f93ccb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: engine-backup: recreate dwh conf only if found
by tnisan＠redhat.com 09 Mar '16

09 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: engine-backup: recreate dwh conf only if found ...................................................................... packaging: engine-backup: recreate dwh conf only if found When restoring engine db with --change-db-credentials, we also need to update dwh's conf, as it too needs access to the engine db. But we need to do that only if dwh is configured. Change-Id: I0e962cad1cc8abd0f02ab0379ee9d797cebba685 Bug-Url: https://bugzilla.redhat.com/1314847 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 18df21b4b107adee0851317d83dd516a3b8812f5) --- M packaging/bin/engine-backup.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/54552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e962cad1cc8abd0f02ab0379ee9d797cebba685 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: network: update CachingNetInfo API calls
by sbonazzo＠redhat.com 09 Mar '16

09 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: network: update CachingNetInfo API calls ...................................................................... network: update CachingNetInfo API calls update CachingNetInfo API calls Change-Id: Ic71e6a6eec6fb67e0ba645229f056fe3f2b328c1 Bug-Url: https://bugzilla.redhat.com/1316094 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/vds_info.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic71e6a6eec6fb67e0ba645229f056fe3f2b328c1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add support for debug log file
by juan.hernandez＠redhat.com 09 Mar '16

09 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add support for debug log file ...................................................................... Add support for debug log file Currently when the debug mode is enabled the SDK writes the debug output to stdout. This isn't convenient for applications that need to write other things to stdout. This patch adds a new "log" parameter to the constructor of the connection. This parameter can contain a file name or an IO object. If it contains a file name the file will be created if needed, and the debug output will be added to the end of the file. If it contains an IO object then the debug output will be written directly to that IO object. Change-Id: I0abd38f103290b23df193052a6fab42843cc2928 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4/http.py 1 file changed, 24 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0abd38f103290b23df193052a6fab42843cc2928 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove GetVmCustomPropertiesQueryTest
by amureini＠redhat.com 09 Mar '16

09 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetVmCustomPropertiesQueryTest ...................................................................... core: Remove GetVmCustomPropertiesQueryTest All the methods in this test case are @Ignored and broken beyond salvation. As it stands, this test case is useless, and should be removed to reduce confusion. Change-Id: Ife4f3d4f49bbecadc15b10302d39da68314422d3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmCustomPropertiesQueryTest.java 1 file changed, 0 insertions(+), 66 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife4f3d4f49bbecadc15b10302d39da68314422d3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GeoRepCreateEligibilityBaseTest version
by amureini＠redhat.com 09 Mar '16

09 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GeoRepCreateEligibilityBaseTest version ...................................................................... core: GeoRepCreateEligibilityBaseTest version Fix CLUSTER_COMPATIBILITY_VERSION as per Java's conventions for constants and reuse the Version.v3_5 constant instead of a string literal. Change-Id: Ie331ea3491aa54daa784be5766d45557a489e842 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GeoRepCreateEligibilityBaseTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie331ea3491aa54daa784be5766d45557a489e842 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: recreate dwh conf only if found
by sbonazzo＠redhat.com 09 Mar '16

09 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: recreate dwh conf only if found ...................................................................... packaging: engine-backup: recreate dwh conf only if found When restoring engine db with --change-db-credentials, we also need to update dwh's conf, as it too needs access to the engine db. But we need to do that only if dwh is configured. Change-Id: I0e962cad1cc8abd0f02ab0379ee9d797cebba685 Bug-Url: https://bugzilla.redhat.com/1314847 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/54379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e962cad1cc8abd0f02ab0379ee9d797cebba685 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Fix log closing
by juan.hernandez＠redhat.com 09 Mar '16

09 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: Fix log closing ...................................................................... Fix log closing This patch fixes the logic to close the log file, introducing a new "@close_log" attribute that explicitly indicates if it the log must be closed. Change-Id: I3db7ae189f9bb23206380707871d459a3553dc1d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4/http.rb 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3db7ae189f9bb23206380707871d459a3553dc1d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0