March 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.4]: engine: Leave cpuProfileId untouched after reading a snapshot
by tnisan＠redhat.com 07 Mar '16

07 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Leave cpuProfileId untouched after reading a snapshot ...................................................................... engine: Leave cpuProfileId untouched after reading a snapshot cpuProfileId is not stored in OVF, so after reading a snapshot it must be left untouched, not set to null. Change-Id: I5c2fcf0b7a5d1eeaf9bd07b99aaa748f30dc51d7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1238742 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c2fcf0b7a5d1eeaf9bd07b99aaa748f30dc51d7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.4 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Ignore change in creationDate for NEXT_RUN
by tnisan＠redhat.com 07 Mar '16

07 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Ignore change in creationDate for NEXT_RUN ...................................................................... engine: Ignore change in creationDate for NEXT_RUN Ignore creationDate when getting list of changed fields to update on the next run. Otherwise creationDate will always show change in milliseconds, because creationDate is saved without milliseconds in OVF, but with milliseconds in the DB. Change-Id: If672659ba5a433aa9d029b258bf7e36e0fe58b82 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1238742 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If672659ba5a433aa9d029b258bf7e36e0fe58b82 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: CommandBase - avoid setting end status prematurely
by tnisan＠redhat.com 07 Mar '16

07 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: CommandBase - avoid setting end status prematurely ...................................................................... core: CommandBase - avoid setting end status prematurely In change I49b7f506dc1142c3a559d0e6f64813e2ade02254 the code checking whether the command should status should be updated after execution was updated. As some of the commands are adding the tasks to the internal task id list instead of using the getTaskIdList() method it'll cause those commands to be marked as ended although the tasks are still running. This patch adds a check to the internal list as well to avoid that issue. Change-Id: I2251dd808734f297c5e3907b9f106d6cf87fbd18 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310390 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2251dd808734f297c5e3907b9f106d6cf87fbd18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: rename vds_groups_sp.sql -> clusters_sp.sql
by tjelinek＠redhat.com 07 Mar '16

07 Mar '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: rename vds_groups_sp.sql -> clusters_sp.sql ...................................................................... core: rename vds_groups_sp.sql -> clusters_sp.sql Renamed to be consistent with the main patch https://gerrit.ovirt.org/#/c/51109/ Change-Id: If8a8f54a3db36e743e149dafeab4d6b740805b18 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- R packaging/dbscripts/clusters_sp.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8a8f54a3db36e743e149dafeab4d6b740805b18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: lang: pt_BR: updated po
by sbonazzo＠redhat.com 07 Mar '16

07 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: lang: pt_BR: updated po ...................................................................... lang: pt_BR: updated po Change-Id: I3ce8251d5434fa058b754808d2093096450ca6e2 Signed-off-by: Wesley Morais de Oliveira <wesleymoraisdeoliveira18(a)gmail.com> --- M po/pt_BR.po 1 file changed, 965 insertions(+), 907 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53458 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ce8251d5434fa058b754808d2093096450ca6e2 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Wesley Morais de Oliveira <wesleymoraisdeoliveira18(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Avoid potential NPE in event mapper
by juan.hernandez＠redhat.com 07 Mar '16

07 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Avoid potential NPE in event mapper ...................................................................... restapi: Avoid potential NPE in event mapper The mapper for events doesn't take into account that the severity can be null if the user provides an incorrect value. If that happens, a NPE is generated when extracting the name from the null enum value. To avoid that this patch adds a null check. Change-Id: Id299521c59baf49e27ef6381b1be872338fd1982 Coverity-Id: 1201913 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/EventMapper.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54372 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id299521c59baf49e27ef6381b1be872338fd1982 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add ovirt sdk 3.6 for master publisher
by sbonazzo＠redhat.com 07 Mar '16

07 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add ovirt sdk 3.6 for master publisher ...................................................................... Add ovirt sdk 3.6 for master publisher Change-Id: Iae95f5646c6f65696c5336db4bed05de3e16618f Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Juan Hernandez: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/54405 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae95f5646c6f65696c5336db4bed05de3e16618f Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Check dispatcher in version filter
by juan.hernandez＠redhat.com 07 Mar '16

07 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Check dispatcher in version filter ...................................................................... restapi: Check dispatcher in version filter Currently the version filter doesn't check the result of the "getRequestDispatcher" method, which may be null when there is no such dispatcher. If this happens that will generate a NPE. That isn't a serious problem, as it will result in an HTTP 500 (internal server error) code sent to the client for a request that is incorrect anyhow. But it is better to check it, write a message in the log, and send to the client a HTTP 404 (not found) code. Change-Id: Ib73a6ef557f079f667bbddca6596799a08c5ddad Coverity-Id: 1352163 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/VersionFilter.java 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib73a6ef557f079f667bbddca6596799a08c5ddad Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Tranform correctly arrays of bytes
by juan.hernandez＠redhat.com 07 Mar '16

07 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Tranform correctly arrays of bytes ...................................................................... restapi: Tranform correctly arrays of bytes Some of the methods of the system resource return arrays of bytes instead of objects. For example, the "?schema" requests returns the XML schema as an array of bytes. Currently this produces an exception because the V3 output adapter doesn't know how to handle arrays of bytes. This patch fixes that issue. Change-Id: Id9476bd0ac0da315af27d9f63fa41bbb9fe1b7dd Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3OutAdapters.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9476bd0ac0da315af27d9f63fa41bbb9fe1b7dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove getTaskType() check
by laravot＠redhat.com 07 Mar '16

07 Mar '16

Liron Aravot has submitted this change and it was merged. Change subject: core: Remove getTaskType() check ...................................................................... core: Remove getTaskType() check In the rebase of I2251dd808734f297c5e3907b9f106d6cf87fbd18 the task type check was mistakenly left, this patch removes it. Change-Id: I07d489edaeabe0db74ef71db06b40e1af73195ae Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54406 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07d489edaeabe0db74ef71db06b40e1af73195ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0