May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: StorageJobCallback - poll on ExecutionFailed
by laravot＠redhat.com 29 May '16

29 May '16

Liron Aravot has submitted this change and it was merged. Change subject: StorageJobCallback - poll on ExecutionFailed ...................................................................... StorageJobCallback - poll on ExecutionFailed StorageJobCallback is updated to reflect that its doPolling() should be executed when the command status is ExecutionFailed. Change-Id: I335e3bc5cae72e0f1d00f38b68dcc83ae68dd97b Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57653 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I335e3bc5cae72e0f1d00f38b68dcc83ae68dd97b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: BaseImagesCommand - adjust to dc without spm
by laravot＠redhat.com 29 May '16

29 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: BaseImagesCommand - adjust to dc without spm ...................................................................... core: BaseImagesCommand - adjust to dc without spm Use GetVolumeInfoVDSCommand for dc without SPM instead of GetImageInfo which is a SPM command. Change-Id: I64965ac398d4a189f190a98e1846c0c418bf739f Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVolumeInfoVDSCommandParameters.java 2 files changed, 25 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/44785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64965ac398d4a189f190a98e1846c0c418bf739f Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageHandlingCommandBaseTest type inference
by amureini＠redhat.com 29 May '16

29 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageHandlingCommandBaseTest type inference ...................................................................... core: StorageHandlingCommandBaseTest type inference Change-Id: Id31e1235337659d994878bf9002ce61d82538978 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id31e1235337659d994878bf9002ce61d82538978 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix StorageHandlingCommandBaseTest's typo
by amureini＠redhat.com 29 May '16

29 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix StorageHandlingCommandBaseTest's typo ...................................................................... core: Fix StorageHandlingCommandBaseTest's typo Change-Id: Ic7f1cd8463a5a772e05f484b31f88668741242f3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f1cd8463a5a772e05f484b31f88668741242f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: CommandBase - endAction() lock release
by tnisan＠redhat.com 29 May '16

29 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: CommandBase - endAction() lock release ...................................................................... core: CommandBase - endAction() lock release When ending command action the commands locks are freed on endActionInTransactionScope() which is wrong because the transaction should be committed before the lock is released. additionally, currently there is a duplicate call which is unneeded. Change-Id: Ia1405b6010cfebc5cdbe4ac8c87822ea6fc0fd72 Signed-off-by: Liron Aravot <laravot(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1339308 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1405b6010cfebc5cdbe4ac8c87822ea6fc0fd72 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.7]: frontend: Import VM dialog - architecture
by tnisan＠redhat.com 29 May '16

29 May '16

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Import VM dialog - architecture ...................................................................... frontend: Import VM dialog - architecture * The split table of the dialog shows VMs with architecture: "Name (arch)". * The dialog prevents from continuing to the next page and shows error dialog if the selection * contains VM with multiple architectures (because they can't be imported in one Cluster) * contains VM with architecture for which there is no corresponding Cluster in selected Data Center Change-Id: Ife22ca52a9ba8308f5fce2d52318d182382b2337 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1294451 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java 4 files changed, 104 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife22ca52a9ba8308f5fce2d52318d182382b2337 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.7]: engine: Set the vfsType glusterfs when importing HE domain
by tnisan＠redhat.com 29 May '16

29 May '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Set the vfsType glusterfs when importing HE domain ...................................................................... engine: Set the vfsType glusterfs when importing HE domain In HE flow, when importing a gluster domain we must set explicitly the domain type otherwise the mount will fail. This problem discovered when non HE hosts where connecting to that domain. HE hosts have the right mount options in a configuration file (they are connecting before there is an engine live) Change-Id: Ic2383047d5033818ae2c2227e9fd6e756db10eaa Bug-Url: https://bugzilla.redhat.com/1317699 Signed-off-by: Roy Golan <rgolan(a)redhat.com> (cherry picked from commit ed8f4ac73cfaf849982e60b456284b5e88b45e47) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommand.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57929 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2383047d5033818ae2c2227e9fd6e756db10eaa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: notifier: mail logger fixes
by mperina＠redhat.com 27 May '16

27 May '16

Martin Peřina has submitted this change and it was merged. Change subject: core: notifier: mail logger fixes ...................................................................... core: notifier: mail logger fixes Change-Id: I57881e45949fbc3bc4fa7a82ea5bbb5cd0d4ab70 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57881e45949fbc3bc4fa7a82ea5bbb5cd0d4ab70 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: notifier: add successfull mail sent message
by mperina＠redhat.com 27 May '16

27 May '16

Martin Peřina has submitted this change and it was merged. Change subject: core: notifier: add successfull mail sent message ...................................................................... core: notifier: add successfull mail sent message Change-Id: I5e5311befaa6e27435b4e91bab1059b272dac48b Bug-Url: https://bugzilla.redhat.com/1092907 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57622 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e5311befaa6e27435b4e91bab1059b272dac48b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Map PM iLO3 and iLO4 to their native agents
by mperina＠redhat.com 27 May '16

27 May '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Map PM iLO3 and iLO4 to their native agents ...................................................................... core: Map PM iLO3 and iLO4 to their native agents IPMI is currently implicitly used when working with iLO3/4 fence devices. This was done from historical reasons because fence-agents package did not had specific agents for iLO3/4 But that was changed and now we can use iLO3/4 native drivers which are recommended. Also, lanplus=1 is set by default for the native drivers and there is no need to set it implicitly anymore. Patch was tested with iLO4 agent and works as expected. I will try to find a way to validate it on iLO3 as well and also on PPC machines. Change-Id: I6f5b5799d5f394f194a26edd6ab54172ef4c2205 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126753 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57739 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f5b5799d5f394f194a26edd6ab54172ef4c2205 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0