Change in ovirt-engine[master]: webadmin: Move readonly, boot and interface columns to disk ...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Move readonly, boot and interface columns to disk attach popup
......................................................................
webadmin: Move readonly, boot and interface columns to disk attach popup
The updatable columns readonly, boot and interface columns that used to
be in DiskViewColumns are only used in the disk attach popup and also are
not really "view" columns as they are updatable, they were …
[View More]moved to
VmDiskAttachPopupWidget were they belong
Bug-Url: http://bugzilla.redhat.com/1341737
Change-Id: Ib878afde565c90da4318a4fcf180c19911dff6f2
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.java
2 files changed, 79 insertions(+), 72 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58481
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib878afde565c90da4318a4fcf180c19911dff6f2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 7 months
Change in ovirt-engine[master]: webadmin: Disabled boot option on disk attach if boot disk e...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Disabled boot option on disk attach if boot disk exists
......................................................................
webadmin: Disabled boot option on disk attach if boot disk exists
When attaching disk(s) to a VM, if a boot disk already exists on the VM
disable the boot checkboxes as a VM cannot have more than one boot disk
Bug-Url: https://bugzilla.redhat.com/1341737
Change-Id: …
[View More]If24974a311af1be276d2d8d0120c481f95928700
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java
2 files changed, 18 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58482
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If24974a311af1be276d2d8d0120c481f95928700
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 7 months
Change in ovirt-engine[ovirt-engine-3.6]: core: StorageDomainDaoTest cleanups backport
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: StorageDomainDaoTest cleanups backport
......................................................................
core: StorageDomainDaoTest cleanups backport
This patch backports a series of cleanups done to StorageDomainDaoTest
in order to facilitate bugfixes in the following patches.
It includes:
- Fixing naming conventions of the class' methods
- Removing a useless member
- Using constants from the FixturesTool
- …
[View More]Fixing the order the assertEquals parameters
- Removing redundant whitespaces that hinder the code's readability
- Removing some pointless assertions
Note this patch should also have a [very slight] performance
improvement, as it uses a pre-created Guids instead of invoking the
constructor several times and removing some useless assertions.
This patch contains the fixes introduced in patches 3158869..15d72f1
from the master branch.
Related-To: https://bugzilla.redhat.com/1337257
Related-To: https://bugzilla.redhat.com/1341661
Change-Id: I8f25dfbd3530b555a0c2aa3ff992990274be6db8
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java
1 file changed, 42 insertions(+), 106 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/58450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f25dfbd3530b555a0c2aa3ff992990274be6db8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
[View Less]
8 years, 7 months
Change in ovirt-engine[master]: core: Fix NPE during merge of snapshots
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix NPE during merge of snapshots
......................................................................
core: Fix NPE during merge of snapshots
Commit 6e55d137d5ca (core: Move disks boot and interface properties
to DiskVmelement) disk boot and interface properties moved to
DiskVmElement. This change caused NPE during snapshot merge because
the DiskVmElement wasn't set on destination image. This patch sets
…
[View More]DiskVmElement on disk before calling OvfWriter.
Change-Id: I5ffecab869f82b5b78a5e1f19bdecbb6927e44e1
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/58509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ffecab869f82b5b78a5e1f19bdecbb6927e44e1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 7 months
Change in ovirt-engine[ovirt-engine-4.0]: rest: Fix NPE when no headers are present during subcollecti...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: rest: Fix NPE when no headers are present during subcollection DELETE
......................................................................
rest: Fix NPE when no headers are present during subcollection DELETE
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254818
Change-Id: I8ad392f0883900facb65a09af7e238a430a70402
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/…
[View More]src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/ExpectationHelper.java
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Martin Sivák: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58485
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ad392f0883900facb65a09af7e238a430a70402
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 7 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Affinity label REST API implementation
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Affinity label REST API implementation
......................................................................
restapi: Affinity label REST API implementation
This patch implements the affinity label endpoints defined
in the REST API model.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254818
Change-Id: Iefa242b8852180524ff505bfc72f26f81753941e
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
…
[View More]A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAffinityLabelledEntitiesResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAffinityLabelledEntityResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityLabelHostResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityLabelHostsResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityLabelResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityLabelVmResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityLabelVmsResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAffinityLabelsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedAffinityLabelResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedAffinityLabelsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/AffinityLabelMapper.java
15 files changed, 602 insertions(+), 15 deletions(-)
Approvals:
Martin Sivák: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58484
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefa242b8852180524ff505bfc72f26f81753941e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 7 months
Change in ovirt-engine[ovirt-engine-4.0]: aaa : Automatic logout does not terminate user session
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa : Automatic logout does not terminate user session
......................................................................
aaa : Automatic logout does not terminate user session
Automatic logout at the expiration of
UserSessionTimeOutInterval should terminate
the session if the session has been inactive
Change-Id: I6712291801ba579b3c4ac7da161f39fbaf38a32e
Bug-Url: https://bugzilla.redhat.com/1340471
Signed-off-by: …
[View More]Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58479
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6712291801ba579b3c4ac7da161f39fbaf38a32e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 7 months
Change in ovirt-engine[ovirt-engine-4.0]: automation: Perform minimal GWT build on merged patches
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: automation: Perform minimal GWT build on merged patches
......................................................................
automation: Perform minimal GWT build on merged patches
Add execution of GWT build for English locale and Firefox only for all
merged patches to detect possible issues in GWT build.
Change-Id: I9a243ae09c613b087f164b9798e97ca2e6291f67
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
…
[View More]M automation/check-merged.sh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, but someone else must approve
Martin Peřina: Verified; Looks good to me, approved
Eyal Edri: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58475
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a243ae09c613b087f164b9798e97ca2e6291f67
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
[View Less]
8 years, 7 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Fix a bug in OVF generation from configuration
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix a bug in OVF generation from configuration
......................................................................
core: Fix a bug in OVF generation from configuration
Change-Id: I7f2c3c02683111498094899164ef9409549b72b9
Bug-Url: https://bugzilla.redhat.com/1340607
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/…
[View More]OvfHelper.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58488
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f2c3c02683111498094899164ef9409549b72b9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 7 months
Change in ovirt-engine[master]: packaging: engine-backup: Fix usage text
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: engine-backup: Fix usage text
......................................................................
packaging: engine-backup: Fix usage text
Drop '[xxx]' around mandatory options and add '[options]'.
Change-Id: Ic6603772429fb631457229044fbcf556635100e4
Bug-Url: https://bugzilla.redhat.com/1300947
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/bin/engine-backup.sh.in
1 file …
[View More]changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/58219
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6603772429fb631457229044fbcf556635100e4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 7 months