August 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add logicalName to DiskAttachment
by tnisan＠redhat.com 03 Aug '16

03 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: add logicalName to DiskAttachment ...................................................................... core: add logicalName to DiskAttachment In v3 of the the REST API, the logical name of a disk could be retrieved from ovirt-engine/api/v3/vms/<vm_id>/disks. Since in v4 DiskAttachmentsService replaces DisksService, the field logicalName should be added to DiskAttachment so that it can be retrieved from /ovirt-engine/api/vms/<vm_id>/diskattachments and /ovirt-engine/api/vms/<vm_id>/diskattachments/<disk_attachment_id>. Change-Id: I102e2e79dcf39aef22bdd36dd12d323564458930 Bug-Url: https://bugzilla.redhat.com/1358271 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskVmElement.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskVmElementDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskVmElementDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskAttachmentMapper.java M packaging/dbscripts/create_views.sql 7 files changed, 28 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/61606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I102e2e79dcf39aef22bdd36dd12d323564458930 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: refactor internalSetVmStatus
by ahadas＠redhat.com 03 Aug '16

03 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: refactor internalSetVmStatus ...................................................................... core: refactor internalSetVmStatus To get VmDynamic instead of the whole VM object. Change-Id: Ic35acd85b6d44367557596bf3db89e07764299cf Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVmStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java 5 files changed, 15 insertions(+), 17 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/61042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic35acd85b6d44367557596bf3db89e07764299cf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: aaa: Add support for dynamic porting
by piotr.kliczewski＠gmail.com 03 Aug '16

03 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Add support for dynamic porting ...................................................................... aaa: Add support for dynamic porting Add support to SSO for dynamic porting. A new config variable has been added ENGINE_SSO_INSTALLED_ON_ENGINE_HOST that determines if SSO has been installed on the same host as engine. By default it is set to true and forwards the user to the host and port that was used to access engine. Change-Id: I3d6aade0ca7126d93014ecda2e0f3abea4498395 Bug-Url: https://bugzilla.redhat.com/1362196 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoLoginServlet.java M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/header.tag M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/credentialsChange.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/LoginServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeContextListener.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeUtils.java M backend/manager/modules/welcome/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java M packaging/services/ovirt-engine/ovirt-engine.conf.in 14 files changed, 75 insertions(+), 14 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d6aade0ca7126d93014ecda2e0f3abea4498395 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine : Add alternate engine FQDNs
by piotr.kliczewski＠gmail.com 03 Aug '16

03 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine : Add alternate engine FQDNs ...................................................................... engine : Add alternate engine FQDNs Add ability to configure alternate engine FQDNs that can be used to access engine. SSO_ALTERNATE_ENGINE_FQDNS config variable can be used to configure the alternate FQDNs. Engine can be accessed using alternate host names (or IP addresses) that can configured by adding a new configuration file /etc/ovirt-engine/engine.conf.d/99-fqdns.conf with following content: SSO_ALTERNATE_ENGINE_FQDNS="alias1.example.com alias2.example.com" The list of alternate names has to be listed separated by spaces. It's possible to also add IP addresses of engine host, but using IP addresses instead of DNS names is not considered to be a good practice. Change-Id: Idd8864e2fa308aa2530a209332fadcb94bdc944d Bug-Url: https://bugzilla.redhat.com/1325746 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/sso.py 3 files changed, 9 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61845 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd8864e2fa308aa2530a209332fadcb94bdc944d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: build: oVirt Live 4.0.2 RC3
by sbonazzo＠redhat.com 02 Aug '16

02 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: oVirt Live 4.0.2 RC3 ...................................................................... build: oVirt Live 4.0.2 RC3 Change-Id: Iea4cf4d21dedb78e47645e1e0609619f82af49be Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea4cf4d21dedb78e47645e1e0609619f82af49be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add support to pass SSO token to SDK connection
by juan.hernandez＠redhat.com 02 Aug '16

02 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add support to pass SSO token to SDK connection ...................................................................... Add support to pass SSO token to SDK connection This patch add support to pass SSO token to SDK connection class, so if user has SSO token, he doesn't have to authenticate with username and password. Change-Id: I2ce1acb1acbfa24ca34d30002962b6037b35a95d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e6a4ab6540a0c16035ca3b5ba9db954ec6acc6a8) --- M sdk/lib/ovirtsdk4/http.rb M sdk/spec/connection_create_spec.rb M sdk/spec/spec_helper.rb 3 files changed, 96 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61836 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ce1acb1acbfa24ca34d30002962b6037b35a95d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: packaging: avoid hard links
by sbonazzo＠redhat.com 02 Aug '16

02 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: avoid hard links ...................................................................... packaging: avoid hard links On some slaves build fails if using hard link due to cross device linking. Change-Id: Ia36046bc89a7c686e559dfea364568ab56ecc693 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M fedora-24/Makefile 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61848 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia36046bc89a7c686e559dfea364568ab56ecc693 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: fedora: aligned fedora with centos
by sbonazzo＠redhat.com 02 Aug '16

02 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: fedora: aligned fedora with centos ...................................................................... fedora: aligned fedora with centos - Renamed fedora to fedora-24 - Aligned fedora-24 content with centos content Change-Id: I3ae9ddeaf6375b18c472ea83855adf21214387cd Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A fedora-24/Makefile A fedora-24/kickstart/ovirt-live-ovirt-custom.ks.in A fedora-24/oVirtLiveFiles/root/etc/gdm/custom.conf R fedora-24/oVirtLiveFiles/root/etc/ovirt-host-deploy.conf.d/50-vdsm-conf-fake-nic.conf R fedora-24/oVirtLiveFiles/root/etc/sysconfig/network-scripts/ifcfg-dummy0 C fedora-24/oVirtLiveFiles/root/etc/sysconfig/network-scripts/ifcfg-eth0 A fedora-24/oVirtLiveFiles/root/etc/sysconfig/network-scripts/ifcfg-ovirtmgmt R fedora-24/oVirtLiveFiles/root/etc/sysconfig/network-scripts/ifcfg-wlan0 A fedora-24/oVirtLiveFiles/root/etc/sysconfig/network-scripts/route-ovirtmgmt A fedora-24/oVirtLiveFiles/root/etc/sysconfig/network-scripts/rule-ovirtmgmt R fedora-24/oVirtLiveFiles/root/etc/xdg/autostart/engine-setup.desktop R fedora-24/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/engine-setup-yad.sh R fedora-24/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/ovirt-answer A fedora-24/oVirtLiveFiles/root/usr/libexec/vdsm/hooks/before_vdsm_start/20-setupBridge.py R fedora-24/oVirtLiveFiles/root/usr/share/applications/ovirt.desktop R fedora-24/oVirtLiveFiles/root/usr/share/glib-2.0/schemas/org.gnome.desktop.lockdown.gschema.override R fedora-24/oVirtLiveFiles/root/usr/share/glib-2.0/schemas/org.gnome.desktop.screensaver.gschema.override R fedora-24/oVirtLiveFiles/root/usr/share/glib-2.0/schemas/org.gnome.settings-daemon.plugins.updates.gschema.override R fedora-24/oVirtLiveFiles/root/usr/share/glib-2.0/schemas/org.gnome.shell.gschema.override D fedora/Makefile D fedora/kickstart/ovirt.ks D fedora/oVirtLiveFiles/patches/0001-oVirtLive-patches.patch D fedora/oVirtLiveFiles/root/etc/gdm/custom.conf D fedora/oVirtLiveFiles/root/etc/sysconfig/network-scripts/ifcfg-eth0 D fedora/oVirtLiveFiles/root/etc/sysconfig/network-scripts/ifcfg-ovirtmgmt D fedora/oVirtLiveFiles/root/etc/yum.repos.d/ovirt.repo 26 files changed, 290 insertions(+), 360 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61835 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ae9ddeaf6375b18c472ea83855adf21214387cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: Removed the 'all' keyword fron the config file. reason: it's...
by rmartins＠redhat.com 02 Aug '16

02 Aug '16

Rafael Martins has submitted this change and it was merged. Change subject: Removed the 'all' keyword fron the config file. reason: it's not working since 3.2.0 . ...................................................................... Removed the 'all' keyword fron the config file. reason: it's not working since 3.2.0 . Change-Id: I655ee352db2bdc74a076bfadc017884678569dc8 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1355966 --- M src/logcollector.conf 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, but someone else must approve Ido Rosenzwig: Verified Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61842 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I655ee352db2bdc74a076bfadc017884678569dc8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: add default quota to the DB
by rgolan＠redhat.com 02 Aug '16

02 Aug '16

Roy Golan has submitted this change and it was merged. Change subject: core: add default quota to the DB ...................................................................... core: add default quota to the DB Add is_default boolean column to each quota, to indicate if it is default for its storage pool. Change-Id: Ib87dd07ed52c8fdf111c04407f25947ccbb6f5ba Bug-Url: https://bugzilla.redhat.com/1297210 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaCRUDCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddEmptyStoragePoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Quota.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql M packaging/dbscripts/quota_sp.sql A packaging/dbscripts/upgrade/04_01_0190_add_default_quota.sql 10 files changed, 367 insertions(+), 22 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/59634 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib87dd07ed52c8fdf111c04407f25947ccbb6f5ba Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0