September 2016 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: CreateGlusterVolumeCommand.getVolume()

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: CreateGlusterVolumeCommand.getVolume() ...................................................................... core: CreateGlusterVolumeCommand.getVolume() Add a utility method getVolume() to return the volume from the parameters instead of saving it as a data member. This achieves two things: First, from a design perspective, it saves the need to keep the same object in two places. Second, it allows for more flexibility, and lends ease to testing the class in the following patches of the series. Change-Id: If8c30fc9ea0822e3832b132ef3f13070a9f7f4f8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java 1 file changed, 23 insertions(+), 23 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8c30fc9ea0822e3832b132ef3f13070a9f7f4f8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: remove GlusterHookCommandTest ctor

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: remove GlusterHookCommandTest ctor ...................................................................... core: remove GlusterHookCommandTest ctor Remove the useless default constructor that does nothing more than the constructor Java would generate for us. Change-Id: I189a65b09adc6b829e3b8da60bd74b2077193448 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64614 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I189a65b09adc6b829e3b8da60bd74b2077193448 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Remove unused GlusterHookCommandTest#HOOK_ID2

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused GlusterHookCommandTest#HOOK_ID2 ...................................................................... core: Remove unused GlusterHookCommandTest#HOOK_ID2 Change-Id: I44a991d87349b2575e75a54bf225984955444f5d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44a991d87349b2575e75a54bf225984955444f5d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: @Spy gluster georep session commands

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: @Spy gluster georep session commands ...................................................................... core: @Spy gluster georep session commands Cleaned up the gluster geo rep commands tests to use the @Spy annotation in preparation for injecting the DAOs. This patch includes: - Moving the definition of the command to the base class GepRepSessionCommandTest and @Spying it there. - Thus, there is only only command object per test, so all the methods receiving commands as parameters were redone to use the member. - Wherever possible, these now argument-less methods were annotated with @Before to avoid having to call them explicitly in each test. Change-Id: Icaea6b86e36784d53fbe98ab3ef202c202f03b79 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DeleteGeoRepSessionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GeoRepSessionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/PauseGlusterVolumeGeoRepSessionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopGeoRepSessionCommandTest.java 6 files changed, 75 insertions(+), 105 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaea6b86e36784d53fbe98ab3ef202c202f03b79 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: @Spy gluster volume commands

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: @Spy gluster volume commands ...................................................................... core: @Spy gluster volume commands Cleaned up the gluster volume commands tests to use the @Spy annotation in preparation for injecting the DAOs. This patch includes: - Changing the command being tested to be initialized once and annotated with @Spy and @InjectMocks. - Thus, there is only only command object per test, so all the methods receiving commands as parameters were redone to use the member. - Wherever possible, these now argument-less methods were annotated with @Before to avoid having to call them explicitly in each test. - Since now the command under test injects its mocks, redundant InjectorRule calls were removed in order to avoid duplication. Change-Id: I7c5f3a928c5837e275d8fdf06af3f200909183c4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeProfileCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartRemoveGlusterVolumeBricksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeProfileCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommandTest.java 15 files changed, 309 insertions(+), 370 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64611 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c5f3a928c5837e275d8fdf06af3f200909183c4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: AddImageFromScratchCommand - disable the SDM support

by laravot＠redhat.com

Liron Aravot has submitted this change and it was merged. Change subject: core: AddImageFromScratchCommand - disable the SDM support ...................................................................... core: AddImageFromScratchCommand - disable the SDM support Currently the create image flow SDM verbs (allocate) aren't completely implemented. In order for being able to test the current implemented SDM flows - this patch removes the SDM implementation for this flow, we'll add it once it will be implemented. Change-Id: Ie75848a75ee0aadce3681d0f667ecb854c4b8b08 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AddImageFromScratchCommand.java 1 file changed, 12 insertions(+), 39 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie75848a75ee0aadce3681d0f667ecb854c4b8b08 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 7 months

1
0
0 / 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare for next development iteration

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare for next development iteration ...................................................................... [maven-release-plugin] prepare for next development iteration Change-Id: Icad913158ea918d00293de5b1d0f4d754a885c2a --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64956 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icad913158ea918d00293de5b1d0f4d754a885c2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 7 months

1
0
0 / 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare release 4.0.2

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare release 4.0.2 ...................................................................... [maven-release-plugin] prepare release 4.0.2 Change-Id: Ib04e6746682afe816d4275c3cec21896f51bfc31 --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64955 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib04e6746682afe816d4275c3cec21896f51bfc31 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 7 months

1
0
0 / 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Update CHANGES.adoc for release 4.0.2

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: Update CHANGES.adoc for release 4.0.2 ...................................................................... Update CHANGES.adoc for release 4.0.2 This patch updates the CHANGES.adoc file, documenting the relevant changes in release 4.0.2. Change-Id: I304c1f2dbe955bdc232bd081a072ee53198ed120 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/CHANGES.adoc 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64954 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I304c1f2dbe955bdc232bd081a072ee53198ed120 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 7 months

1
0
0 / 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Change the probe to receive options instead of a connection

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: Change the probe to receive options instead of a connection ...................................................................... Change the probe to receive options instead of a connection This is done for decoupling with connection implementation so that curb can be removed more easily. Change-Id: Id8ce552106811773f1d35ece4370baf62e43dc83 Signed-off-by: borod108 <bodnopoz(a)redhat.com> (cherry picked from commit fd328cd85e96e27c8d7546f735774eabd181b574) --- M sdk/lib/ovirtsdk4/http.rb M sdk/lib/ovirtsdk4/probe.rb M sdk/spec/probe_spec.rb M sdk/spec/spec_helper.rb 4 files changed, 174 insertions(+), 63 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64953 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8ce552106811773f1d35ece4370baf62e43dc83 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

7 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits September 2016