Change in ovirt-engine[master]: core: DirectoyUtils type inference
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DirectoyUtils type inference
......................................................................
core: DirectoyUtils type inference
Change-Id: I1c09723a72ea6f8e9f60ba589bf03eb785d2dde8
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java
1 file changed, 19 insertions(+), 19 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c09723a72ea6f8e9f60ba589bf03eb785d2dde8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: DirectoryUtils#mapGroupRecordToDbGroup(String, ExtMap)
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DirectoryUtils#mapGroupRecordToDbGroup(String, ExtMap)
......................................................................
core: DirectoryUtils#mapGroupRecordToDbGroup(String, ExtMap)
Remove an unused method.
Change-Id: Ie9e3fae36385abbd901cc7b23ef5f944a2ad8946
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71409
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9e3fae36385abbd901cc7b23ef5f944a2ad8946
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: prevent possible NPE
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: prevent possible NPE
......................................................................
core: prevent possible NPE
This code is going to removed anyway by Ibcabcc2.
Change-Id: I0f9360c4d2939a2746b7496f0d991b699a9492a7
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/71486
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f9360c4d2939a2746b7496f0d991b699a9492a7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: update DiskVmElements on getTemplateDisks
by Code Review
>From Daniel Erez <derez(a)redhat.com>:
Daniel Erez has submitted this change and it was merged.
Change subject: core: update DiskVmElements on getTemplateDisks
......................................................................
core: update DiskVmElements on getTemplateDisks
GetVmTemplatesDisksQuery:
Update DiskVmElements on getTemplateDisks method,
so GetStorageDomainsByVmTemplateIdQuery would return
updated disk.
Needed for interface column in 'Storage -> Templates'
sub-tab and for extended tab in the UserPortal
(TemplateDiskListModelTable).
Current view with missing interface value:
http://imgur.com/a/CeYlV
Change-Id: I6185232775771dccea732f22fd318747b436993f
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetVmTemplatesDisksQuery.java
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/71483
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6185232775771dccea732f22fd318747b436993f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: webadmin: interface in DisksTree and StoragesTree
by Code Review
>From Daniel Erez <derez(a)redhat.com>:
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: interface in DisksTree and StoragesTree
......................................................................
webadmin: interface in DisksTree and StoragesTree
Added interface column in disk table (in Templates ->
Storage / Disks sub-tabs).
Currently, only the Interface column title is displayed:
http://imgur.com/a/CeYlV
Change-Id: Id9643b2eeae59a7c773c80e9657db96d4aec6d48
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/DisksTree.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/StoragesTree.java
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/71484
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9643b2eeae59a7c773c80e9657db96d4aec6d48
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: webadmin: DiskListModel - removed redundant casting
by Code Review
>From Daniel Erez <derez(a)redhat.com>:
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: DiskListModel - removed redundant casting
......................................................................
webadmin: DiskListModel - removed redundant casting
Removed redundant casting to List in updateActionAvailability.
Change-Id: Ic9f0ce98351789d139d9af03876438c3be56341e
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/71481
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9f0ce98351789d139d9af03876438c3be56341e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: webadmin: DiskListModel - add generics to ArrayList
by Code Review
>From Daniel Erez <derez(a)redhat.com>:
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: DiskListModel - add generics to ArrayList
......................................................................
webadmin: DiskListModel - add generics to ArrayList
ArrayList -> ArrayList<Disk>
Change-Id: I681641130f3c2f1c0af3c797d2f871843315a19c
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/71482
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I681641130f3c2f1c0af3c797d2f871843315a19c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: webadmin: adjust upload image dialog height
by Code Review
>From Daniel Erez <derez(a)redhat.com>:
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: adjust upload image dialog height
......................................................................
webadmin: adjust upload image dialog height
Adjusted upload image dialog height to accommodate properly
"There are no active Data Centers in the system." error message.
Before: http://imgur.com/a/aeLd2
After: http://imgur.com/a/X0qYz
Change-Id: Ia6ffd59bb231062ed99dbd8cafb2d82ecde073c1
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71480
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6ffd59bb231062ed99dbd8cafb2d82ecde073c1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: rename create vm vds-commands
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: rename create vm vds-commands
......................................................................
core: rename create vm vds-commands
The standard in oVirt is to name VDS command of operation 'verb' to
VerbVDSCommand and its vdsbroker part VerbBrokerVDSCommand. This
patch changes CreateVmVDSCommand and CreateVDSCommand accordingly.
Note that CreateVmFromCloudInit and CreateVmFromSysPrep are not
changed because the plan is to merge them with CreateBroker.
Change-Id: I26831b575e964cadeebf87d6ca894407a69ea818
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java
R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateBrokerVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVmFromCloudInitVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVmFromSysPrepVDSCommand.java
9 files changed, 29 insertions(+), 29 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/71447
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26831b575e964cadeebf87d6ca894407a69ea818
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in jenkins[master]: ovirt-node-ng: fix reference to master-experimental
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-node-ng: fix reference to master-experimental
......................................................................
ovirt-node-ng: fix reference to master-experimental
fix reference to master-experimental repository
Change-Id: Ifc6c37b4e64d71e10b72f1dce38e4a914a6eb4b9
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-node-ng/ovirt-node-ng.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Yuval Turgeman: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71477
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc6c37b4e64d71e10b72f1dce38e4a914a6eb4b9
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months