Change in ovirt-engine[master]: core: extract passthroughVnicToVfMap from vm
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: extract passthroughVnicToVfMap from vm
......................................................................
core: extract passthroughVnicToVfMap from vm
It is used only on run VM flow, so moving it from the overloaded VM
object into the parameters of CreateVDSCommand.
Change-Id: I8921abedadcc96e0cdbec617ac8ead35acf7d011
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateBrokerVDSCommand.java
8 files changed, 22 insertions(+), 21 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/72912
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8921abedadcc96e0cdbec617ac8ead35acf7d011
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: packaging: spec: ensure debug packages alignment
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: ensure debug packages alignment
......................................................................
packaging: spec: ensure debug packages alignment
Debug packages requires same exact version of the runtime
packages in order to properly work.
Added explicit require ensuring that the version match.
Concern has been raised related to eventual yum update
error messages related to version locking:
debug packages are not meant to be installed on any production
environment other than for debugging purpose.
Once the debug is finished they need to be removed.
Change-Id: I77f1e509c7e0d8ed903ad33c154098c974e08c39
Bug-Url: https://bugzilla.redhat.com/1401963
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73046
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77f1e509c7e0d8ed903ad33c154098c974e08c39
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add support for custom global headers
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add support for custom global headers
......................................................................
Add support for custom global headers
Currently there is no way to have global custom headers. This patch adds
support for that. For example, if the caller, for whatever the reason,
needs to send the 'My: myvalue' header to add a virtual
machine, it can be done as follows:
connection = OivrtSDK4::Connection.new(
url: 'https://engine/ovirt-engine/api',
username: 'username@domain',
password: 'password',
ca_file: 'ca.pem',
headers: { my: 'myvalue' }
)
# Get the reference to the service that manage the collection
# of virtual machines and add virtual machine:
vms_service = connection.system_service.vms_service
vms_service.add(OvirtSDK4::Vm.new)
Change-Id: I53a67698e3c260b6721d62c8b5c51368ad561079
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 7f5f30da4da30c9b20093d9cc9c5dc3c61062a5d)
---
M sdk/lib/ovirtsdk4/connection.rb
A sdk/spec/global_headers_spec.rb
M sdk/spec/spec_helper.rb
3 files changed, 110 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73120
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53a67698e3c260b6721d62c8b5c51368ad561079
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine-sdk-ruby[master]: Add support for custom global headers
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add support for custom global headers
......................................................................
Add support for custom global headers
Currently there is no way to have global custom headers. This patch adds
support for that. For example, if the caller, for whatever the reason,
needs to send the 'My: myvalue' header to add a virtual
machine, it can be done as follows:
connection = OivrtSDK4::Connection.new(
url: 'https://engine/ovirt-engine/api',
username: 'username@domain',
password: 'password',
ca_file: 'ca.pem',
headers: { my: 'myvalue' }
)
# Get the reference to the service that manage the collection
# of virtual machines and add virtual machine:
vms_service = connection.system_service.vms_service
vms_service.add(OvirtSDK4::Vm.new)
Change-Id: I53a67698e3c260b6721d62c8b5c51368ad561079
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M sdk/lib/ovirtsdk4/connection.rb
A sdk/spec/global_headers_spec.rb
M sdk/spec/spec_helper.rb
3 files changed, 110 insertions(+), 3 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73045
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53a67698e3c260b6721d62c8b5c51368ad561079
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: core: All hosts are allowed by default from CORSSupportFilter
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: core: All hosts are allowed by default from CORSSupportFilter
......................................................................
core: All hosts are allowed by default from CORSSupportFilter
All configured hosts are added as allowed origins from CORSSupportFilter
by default if
- CORSSupport=true
- CORSAllowDefaultOrigins=true
is set by engine-config.
Additionaly, use engine-config to set:
- CORSDefaultOriginSuffixes=[comma-separated list]
If CORSDefaultOriginSuffixes is empty, origins allowed by default will be:
https://[HOST_URL]
For non-empty, one allowed origin per suffix will be provided in form:
https://[HOST_URL][suffix]
This patch is required to allow REST API requests from externally served
JS applications, like Cockpit running on a host.
Change-Id: Ie6fef4df5d1059b542293ad54e2740ac61741cd3
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDefaultAllowedOriginsQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDefaultAllowedOriginsQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/CORSSupportFilter.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
10 files changed, 267 insertions(+), 44 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Marek Libra: Verified
--
To view, visit https://gerrit.ovirt.org/68529
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6fef4df5d1059b542293ad54e2740ac61741cd3
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-hosted-engine-setup[master]: packaging: spec: drop qemu-kvm-tools
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: drop qemu-kvm-tools
......................................................................
packaging: spec: drop qemu-kvm-tools
qemu-kvm-tools disappeared from Fedora 25 and it
was a nice way to discover it's there since 2012
but unused right now.
Note that the only remaining use case for qemu-kvm-tools
was sos, since the package provided only "kvm_stat --once"
output when executing "sosreport -o kvm" from log collector.
Removing it from installed packages.
Change-Id: I3b009011878fb9767ebbc2b03b674bb0d3aab131
Bug-Url: https://bugzilla.redhat.com/1426581
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-hosted-engine-setup.spec.in
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73038
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b009011878fb9767ebbc2b03b674bb0d3aab131
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin <mku(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-host-deploy[master]: vdsm: packages: drop qemu-kvm-tools
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: vdsm: packages: drop qemu-kvm-tools
......................................................................
vdsm: packages: drop qemu-kvm-tools
qemu-kvm-tools disappeared from Fedora 25 and it
was a nice way to discover it's there since 2012
but unused right now.
Note that the only remaining use case for qemu-kvm-tools
was sos, since the package provided only "kvm_stat --once"
output when executing "sosreport -o kvm" from log collector.
Removing it from installed packages.
Change-Id: If19998d33328056eb1f42cac8ff3b9cd9381ea71
Bug-Url: https://bugzilla.redhat.com/1426580
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-host-deploy/vdsm/packages.py
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73037
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If19998d33328056eb1f42cac8ff3b9cd9381ea71
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin <mku(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-dwh[master]: automation: save rpms for check-patch
by Code Review
>From Shirly Radco <sradco(a)redhat.com>:
Shirly Radco has submitted this change and it was merged.
Change subject: automation: save rpms for check-patch
......................................................................
automation: save rpms for check-patch
Change-Id: Ieb97cec9d5fd6f90be4a6c62654c8293ea974f75
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M automation/check-patch.sh
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73114
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb97cec9d5fd6f90be4a6c62654c8293ea974f75
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in jenkins[master]: Jenkins: Removed the old upgrade jobs
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: Jenkins: Removed the old upgrade jobs
......................................................................
Jenkins: Removed the old upgrade jobs
The upgrade jobs are now part of the experimental flow, and if needed
an upgrade suite can be also triggered from the manual job.
Jira ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-567
Change-Id: I225889c6c5709dfed07afdb37fda1a5c9df51b69
Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com>
---
D jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-engine.yaml
D jobs/confs/shell-scripts/ovirt-engine_upgrade-engine.cleanup.sh
D jobs/confs/shell-scripts/ovirt-engine_upgrade-engine.sh
D jobs/confs/yaml/builders/ovirt-engine_upgrade-engine.yaml
D jobs/confs/yaml/publishers/engine-upgrade-cleanup.yaml
D jobs/confs/yaml/templates/engine-upgrade.yaml
M jobs/confs/yaml/triggers/gerrit.yaml
D jobs/ovirt-engine_upgrade_to_3.5/build_engine_rpm.sh
D jobs/ovirt-engine_upgrade_to_3.5/cleanup.file.otopi
D jobs/ovirt-engine_upgrade_to_3.5/cleanup.sh
D jobs/ovirt-engine_upgrade_to_3.5/setup.file.otopi
D jobs/ovirt-engine_upgrade_to_3.5/upgrade.sh
D jobs/ovirt-engine_upgrade_to_3.6/build_engine_rpm.sh
D jobs/ovirt-engine_upgrade_to_3.6/cleanup.file.otopi
D jobs/ovirt-engine_upgrade_to_3.6/cleanup.sh
D jobs/ovirt-engine_upgrade_to_3.6/setup.file.otopi
D jobs/ovirt-engine_upgrade_to_3.6/upgrade.sh
D jobs/ovirt-engine_upgrade_to_4.0/build_engine_rpm.sh
D jobs/ovirt-engine_upgrade_to_4.0/cleanup.file.otopi
D jobs/ovirt-engine_upgrade_to_4.0/cleanup.sh
D jobs/ovirt-engine_upgrade_to_4.0/setup.file.otopi
D jobs/ovirt-engine_upgrade_to_4.0/upgrade.sh
D jobs/ovirt-engine_upgrade_to_4.1/build_engine_rpm.sh
D jobs/ovirt-engine_upgrade_to_4.1/cleanup.file.otopi
D jobs/ovirt-engine_upgrade_to_4.1/cleanup.sh
D jobs/ovirt-engine_upgrade_to_4.1/setup.file.otopi
D jobs/ovirt-engine_upgrade_to_4.1/upgrade.sh
D jobs/ovirt-engine_upgrade_to_master/build_engine_rpm.sh
D jobs/ovirt-engine_upgrade_to_master/cleanup.file.otopi
D jobs/ovirt-engine_upgrade_to_master/cleanup.sh
D jobs/ovirt-engine_upgrade_to_master/setup.file.otopi
D jobs/ovirt-engine_upgrade_to_master/upgrade.sh
D jobs/ovirt_engine_upgrade_params/answer.file.otopi
D jobs/ovirt_engine_upgrade_params/cleanup.file.otopi
D jobs/ovirt_engine_upgrade_params/update_engine_params.sh
D jobs/ovirt_engine_upgrade_stable_32_to_latest_32/answer.file
D jobs/ovirt_engine_upgrade_stable_32_to_latest_32/disable-fqdn-validation.patch
D jobs/ovirt_engine_upgrade_stable_32_to_latest_32/ovirt_engine_upgrade_stable_32_to_latest_32.repo
D jobs/ovirt_engine_upgrade_stable_32_to_latest_32/ovirt_engine_upgrade_stable_32_to_latest_32.sh
39 files changed, 0 insertions(+), 4,858 deletions(-)
Approvals:
Eyal Edri: Looks good to me, approved; Ready for merge
Daniel Belenky: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72906
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I225889c6c5709dfed07afdb37fda1a5c9df51b69
Gerrit-PatchSet: 5
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: core: Document the VmBase#dedicatedVmForVdsList field
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: Document the VmBase#dedicatedVmForVdsList field
......................................................................
core: Document the VmBase#dedicatedVmForVdsList field
Added comment explaining the usage of this VmBase field in the context
of direct host device passthrough and other flows.
Change-Id: I7ef7d410cda70ab1fc3a9e1b7078f218d6040e8f
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/72904
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ef7d410cda70ab1fc3a9e1b7078f218d6040e8f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month