March 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: core: Introducing UpdateVolumeCommand
by Code Review 29 Mar '17

29 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Introducing UpdateVolumeCommand ...................................................................... core: Introducing UpdateVolumeCommand Added UpdateVolumeCommand that allows to change volume metadata. The supported metadata that can be changed: - description of the volume - volume type (allows to make a leaf volume shared) - legality (legal/illegal) - generation Added UpdateAllTemplateDisksCommand that runs UpdateVolumeCommand on all disks of a template. This command is designed to be called from AddVmTemplateCommand and it works only on non-shared volumes of a template. Change-Id: Ic5ba999df76507f87767fa5a23278779ce453ffd Bug-Url: https://bugzilla.redhat.com/1436219 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateAllTemplateDisksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UpdateVolumeCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateAllTemplateDisksParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVolumeCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 5 files changed, 287 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74668 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5ba999df76507f87767fa5a23278779ce453ffd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Introducing CreateAllTemplateDisksCommand
by Code Review 29 Mar '17

29 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Introducing CreateAllTemplateDisksCommand ...................................................................... core: Introducing CreateAllTemplateDisksCommand Adding CreateAllTemplateDisksCommand that creates all disks needed for creating a template. This command is called from AddVmTemplateCommand instead of calling CreateImageTemplateCommand and CloneSingleCinderDiskCommand directly. AddVmTemplateFromSnapshotCommand runs CreateAllTemplateDisksFromSnapshotCommand for the same purpose. CreateAllTemplateDisksCommand incorporates callback that is needed to poll the child commands that create disk images. The callback in AddVmTemplateCommand orchestrates the process of template creation, including post-processing of template disk images, which will be added in the next patches. Change-Id: I6fc7e46df640a5ec0c0c7bc0e3f512e16d6969ae Bug-Url: https://bugzilla.redhat.com/1436219 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/CreateAllTemplateDisksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/CreateAllTemplateDisksFromSnapshotCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllTemplateDisksParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 6 files changed, 402 insertions(+), 149 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fc7e46df640a5ec0c0c7bc0e3f512e16d6969ae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Introducing SealVmTemplateCommand
by Code Review 29 Mar '17

29 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Introducing SealVmTemplateCommand ...................................................................... core: Introducing SealVmTemplateCommand Added SealVmTemplateCommand to execute virt-sysprep on disks connected to a VM. The command is intended to be run from AddVmTemplateCommand. Added SealDisksVDSCommand that executes virt-sysprep over collection of disk images. virt-sysprep erases all host-specific configuration from the filesystem: SSH keys, UDEV rules, MAC addresses, system ID, hostname etc., thus making easy to use a VM as template without manual intervention. Change-Id: I36361d552b02affa63c2f07e64e6e0bcb44187eb Bug-Url: https://bugzilla.redhat.com/1436219 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SealVmTemplateCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SealVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SealDisksVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SealDisksVDSCommand.java 10 files changed, 247 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74674 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36361d552b02affa63c2f07e64e6e0bcb44187eb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Introducing virt jobs
by Code Review 29 Mar '17

29 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Introducing virt jobs ...................................................................... core: Introducing virt jobs Added new type of host: jobs HostJobType.virt. Created HostJobCallback class as abstract superclass for all types of host job callbacks. Created VirtJobCallback for polling virt jobs. Change-Id: I9dde05c066f5f96a3f3fc66cfcfd818dd623d213 Bug-Url: https://bugzilla.redhat.com/1436219 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostJobCallback.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostJobCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VirtJobCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageJobCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostJobCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageJobCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostJobInfo.java 8 files changed, 313 insertions(+), 255 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dde05c066f5f96a3f3fc66cfcfd818dd623d213 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: New cluster has disabled overcommit by default (for re...
by Code Review 29 Mar '17

29 Mar '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: core: New cluster has disabled overcommit by default (for real now) ...................................................................... core: New cluster has disabled overcommit by default (for real now) Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1433961 Change-Id: I1e69f43fc5b3ed9d4a1757fb16c094edb2e14abd Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Jenny Tokar: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e69f43fc5b3ed9d4a1757fb16c094edb2e14abd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove OvfReader#defaultDisplayType
by Code Review 29 Mar '17

29 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: remove OvfReader#defaultDisplayType ...................................................................... core: remove OvfReader#defaultDisplayType Commit 3dfd06 changed OvfReader so it never updates the defaultDisplayType member. This patch finishes the job and removes it completely. Change-Id: I6cff70606d0e6f206cb2463d4401a2aa1224d5e7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 19 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74783 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cff70606d0e6f206cb2463d4401a2aa1224d5e7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: OvfReader string usages
by Code Review 29 Mar '17

29 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfReader string usages ...................................................................... core: OvfReader string usages Use a plain old String instead of a StringBuilder for composing a constant string. Change-Id: I3dd97469b2809394463010b9035d5a316bc290fe Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dd97469b2809394463010b9035d5a316bc290fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: OvfReader type inference
by Code Review 29 Mar '17

29 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfReader type inference ...................................................................... core: OvfReader type inference Change-Id: I6c42d47b31bcd6a0c8d3b6f24bc453f995546e5e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c42d47b31bcd6a0c8d3b6f24bc453f995546e5e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: jenkins: added a 'standard' support to export junit reports
by Code Review 29 Mar '17

29 Mar '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: jenkins: added a 'standard' support to export junit reports ...................................................................... jenkins: added a 'standard' support to export junit reports the current stable version of jjb (1.6) does not support 'allow-empty-results' in the junit plugin (added in 2.0), so I had to include raw xml to make work https://ovirt-jira.atlassian.net/browse/OVIRT-449 Change-Id: I32c5d57fc7fb6c8d69c6c7887c78b5415b6eba1c Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/yaml/publishers/standard.yaml M jobs/confs/yaml/publishers/system_tests_publishers.yaml 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Barak Korren: Looks good to me Gil Shinar: Looks good to me Jenkins CI: Passed CI tests Daniel Belenky: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/74639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32c5d57fc7fb6c8d69c6c7887c78b5415b6eba1c Gerrit-PatchSet: 9 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Reorder methods of AddVmTemplateCommand
by Code Review 29 Mar '17

29 Mar '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Reorder methods of AddVmTemplateCommand ...................................................................... core: Reorder methods of AddVmTemplateCommand Reorder methods of AddVmTemplateCommand, grouping them by purpose. Change-Id: I4287d3c934ff8741710f8ecb296536474df1c35c Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 128 insertions(+), 128 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4287d3c934ff8741710f8ecb296536474df1c35c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0