Change in ovirt-engine[master]: webadmin: Linq.SharedMacPoolComparator's lexonumeric
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Linq.SharedMacPoolComparator's lexonumeric
......................................................................
webadmin: Linq.SharedMacPoolComparator's lexonumeric
Use LexoNumericNameableComparator instead of reimplementing its
logic.
Change-Id: Icc2eb765c241f9792a076cac1aa73491efdc1ca9
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74949
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc2eb765c241f9792a076cac1aa73491efdc1ca9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: webadmin: Inline Linq.ImportEntityComparator
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Inline Linq.ImportEntityComparator
......................................................................
webadmin: Inline Linq.ImportEntityComparator
ImportEntityComparator is only used in one place
(StorageRegisterEntityListModel).
With Java 8's easy syntax, there's no reason to have it in Linq
instead of just have a oneliner with the same logic where it's
actually needed.
Change-Id: I9c5bbca67898ad0a1ae548c8f3cf2d65eccfb656
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageRegisterEntityListModel.java
2 files changed, 2 insertions(+), 13 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74946
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c5bbca67898ad0a1ae548c8f3cf2d65eccfb656
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: engine: spanish locale selection
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: engine: spanish locale selection
......................................................................
engine: spanish locale selection
- Fixed locale display issue for spanish
Change-Id: I923c96f8cada85efa76ff737926d8a5e4bfd088e
Bug-Url: https://bugzilla.redhat.com/1432904
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M backend/manager/modules/utils/src/main/resources/languages.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Looks good to me, approved
Scott Dickerson: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74975
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I923c96f8cada85efa76ff737926d8a5e4bfd088e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: aaa: Localize all user facing sso messages
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: Localize all user facing sso messages
......................................................................
aaa: Localize all user facing sso messages
All message sent to browser from SSO
needs to be localized.
Change-Id: I84a56bdf76566da639763e6d22415f6752372f13
Bug-Url: https://bugzilla.redhat.com/1435140
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveNextAuthServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java
M backend/manager/modules/enginesso/src/main/resources/AppMessages.properties
4 files changed, 37 insertions(+), 4 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74985
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84a56bdf76566da639763e6d22415f6752372f13
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: aaa: Use engine FQDN for notification callback
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: Use engine FQDN for notification callback
......................................................................
aaa: Use engine FQDN for notification callback
Use engine FQDN for notification callback
url which is used by SSO to notify engine
of logout events.
Change-Id: Iebb8718c63ef8bf07bc0cb0d196e1d77ad0323b7
Bug-Url: https://bugzilla.redhat.com/1426027
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/sso.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74983
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebb8718c63ef8bf07bc0cb0d196e1d77ad0323b7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: core : Storage domains not showing in search on a DC named w...
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core : Storage domains not showing in search on a DC named with an underscore
......................................................................
core : Storage domains not showing in search on a DC named with an underscore
When data center name has an underscore in them
the search sql for storage domains for the data
center is executed with escaped data center name.
This causes issue when the escaped name is used
in the left hand side of the like clause. When
the name is used on the left hand side of the
like clause it does not have to be escaped.
Change-Id: I3049eb2641d7a86b0b857aa9a46376d794d14812
Bug-Url: https://bugzilla.redhat.com/1409849
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java
3 files changed, 27 insertions(+), 19 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74977
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3049eb2641d7a86b0b857aa9a46376d794d14812
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: webadmin: Fix active tab highlighting
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged.
Change subject: webadmin: Fix active tab highlighting
......................................................................
webadmin: Fix active tab highlighting
There seems to be a GWTP bug related to legacy slot
handling, see the following discussion for details:
https://groups.google.com/forum/#!topic/gwt-platform/eDpwOubUCmE
For now, we're working around the problem by adding
the necessary call. In future, we'll modify our code
to use the new GWTP slot API.
Change-Id: Ie36566f9d87c04d1c1106339ae62e82712ffa2bf
Bug-Url: https://bugzilla.redhat.com/1434042
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabContainerPresenter.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74719
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie36566f9d87c04d1c1106339ae62e82712ffa2bf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: userportal: replace vm actions Composite with separate columns
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged.
Change subject: userportal: replace vm actions Composite with separate columns
......................................................................
userportal: replace vm actions Composite with separate columns
In the extended view VM grid, replace vm action Composite with
five separate columns. Additionally, replace the old image-based
icons with new font-awesome versions.
Also reworked the ButtonCell classes to be a little cleaner.
Change-Id: Ieb36934062b105d66a88dd75af22aadd46c5fcdd
Bug-Url: https://bugzilla.redhat.com/1413899
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractButtonCell.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractIconButtonCell.java
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractImageButtonCell.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java
D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/cell/VmButtonsImageButtonCell.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java
M packaging/branding/ovirt.brand/ovirt.css
7 files changed, 212 insertions(+), 264 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/74852
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb36934062b105d66a88dd75af22aadd46c5fcdd
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: packaging: services: Detect JBoss version with log level info
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: services: Detect JBoss version with log level info
......................................................................
packaging: services: Detect JBoss version with log level info
Change-Id: If00a589dac2dd6669eed5982ce82f065f1787e6a
Bug-Url: https://bugzilla.redhat.com/1329119
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit e99222714a656b6baa0f2847ea7ff669c5c44d50)
---
M packaging/services/ovirt-engine/ovirt-engine.py
1 file changed, 9 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/73735
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If00a589dac2dd6669eed5982ce82f065f1787e6a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: change the way of displaying username
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: change the way of displaying username
......................................................................
webadmin: change the way of displaying username
This patch changes the way the name of the user is displayed in
webadmin.
Now the username is displayed as 'First Last (username)'. Previously
it was 'First Last (username@authz-name)'. This is valid for permissions
tabs.
For the 'Users' tab we now display in username column just the username
without the authorization provider, because authorization provider
column is just next to username column, so it's redudant information.
Change-Id: I24e6e78b9478e23db088f65d529f5f6e60704bee
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1425323
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit d61aaa149ac9e4c2206fb7172bc5eea90ec41e1d)
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
M packaging/dbscripts/create_functions.sql
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24e6e78b9478e23db088f65d529f5f6e60704bee
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years