March 2017 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: packaging: accept ovirt-engine-appliance-4.2
by Code Review 20 Mar '17

20 Mar '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: packaging: accept ovirt-engine-appliance-4.2 ...................................................................... packaging: accept ovirt-engine-appliance-4.2 Appliances built form master are now versioned as 4.2. Change-Id: Ib3005286f2abdca258a44b7fa44e9914059f68a0 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3005286f2abdca258a44b7fa44e9914059f68a0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: Properly adjust # of usb-controllers in UpdateTemplate...
by Code Review 20 Mar '17

20 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Properly adjust # of usb-controllers in UpdateTemplate & AddVm ...................................................................... core: Properly adjust # of usb-controllers in UpdateTemplate & AddVm The VmDeviceUtils#updateUsbSlots method was not being called in the flows in UpdateVmTemplateCommand and AddVmCommand, which resulted in creation of templates (and consequently also VMs) with incorrect number of usb controllers and thus preventing the VM to be run in some cases. Change-Id: Ic8fbae5d863307bc423c3e04cfd56c370a850863 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1430009 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 3 files changed, 21 insertions(+), 20 deletions(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Shmuel Leib Melamud: Looks good to me, but someone else must approve Michal Skrivanek: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74251 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8fbae5d863307bc423c3e04cfd56c370a850863 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add job fence on amend.
by Code Review 20 Mar '17

20 Mar '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add job fence on amend. ...................................................................... core: Add job fence on amend. VDSM deletes jobs once VDSM is being restarted therefore the engine should treat those jobs as failed and fence the job once those are not fetched from VDSM. Change-Id: I32719700bfdbdfed0cd1b3afa6431f47dab6cd68 Bug-Url: https://bugzilla.redhat.com/1432067 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendVolumeCommand.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Maor Lipchuk: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32719700bfdbdfed0cd1b3afa6431f47dab6cd68 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: Increment vm db generation when importing devices
by Code Review 20 Mar '17

20 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Increment vm db generation when importing devices ...................................................................... core: Increment vm db generation when importing devices When importing vm devices the db generation column was not updated. The ovf generation process relies on this column to know when a new ovf needs to be generated. Since the column wasn't updated the imported devices were not included in the ovf. Change-Id: I0fe8c7a350e417db1ce0ba273a7d470a89afbe69 Bug-Url: https://bugzilla.redhat.com/1416846 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> (cherry picked from commit df85e2083eae38d52296a574ec35c4831d42ea85) --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDaoImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoringTest.java M packaging/dbscripts/vms_sp.sql 5 files changed, 48 insertions(+), 10 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74245 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fe8c7a350e417db1ce0ba273a7d470a89afbe69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: Monitor devices only for vms that are already in the db
by Code Review 20 Mar '17

20 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Monitor devices only for vms that are already in the db ...................................................................... core: Monitor devices only for vms that are already in the db Before this fix vm devices hash was stored in an internal cache for all vms that were reported by vdsm no matter if they were present in the engine db at the time. This caused problems with hosted engine vm that was imported after the device hash was saved in the cache. Since device monitoring relies on this cache and there was no change in the hash reported from vdsm and the hash in the cache the devices weren't imported. This patch allows monitoring caching info only for vms that already exist in the db and so solves this issue. Change-Id: Ib011ac5c7f28de7891b0b6e3c09b107679c1ff29 Bug-Url: https://bugzilla.redhat.com/1425108 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> (cherry picked from commit ced2f67e1d69c4fbcaa05ef7c47841c54357493f) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollVmStatsRefresher.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74246 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib011ac5c7f28de7891b0b6e3c09b107679c1ff29 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: CloneImageGroupVolumesStructure - determineSourceImage...
by Code Review 20 Mar '17

20 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: CloneImageGroupVolumesStructure - determineSourceImageGroup() ...................................................................... core: CloneImageGroupVolumesStructure - determineSourceImageGroup() determineSourceImageGroup() is used to determine the source image group (which may differ between the first volume and the rest of the volume chain in case the disk is based on a template). The method had two issues: 1. It returned the image id instead of the disk id. 2. It used image.getImageTemplateId() to determine if the disk is based on template. When disk snapshots are created their image template id field is copied from the parent volume, which means that all the chain has the same value in tht field - only the first volume needs to be created as based on the template disk. This patch changes the check to use the template disk id only when the template volume is the parent of the volume by checking that getParentId() equals to getImageTemplateId(). Change-Id: Ibf5f6cac89846865bb36e07507390e1a9b21e99a Bug-Url: https://bugzilla.redhat.com/1429184 Bug-Url: https://bugzilla.redhat.com/1429170 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/74282 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf5f6cac89846865bb36e07507390e1a9b21e99a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-optimizer: drop fc24 on master
by Code Review 20 Mar '17

20 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-optimizer: drop fc24 on master ...................................................................... ovirt-optimizer: drop fc24 on master fc24 will be EOL by 4.2 GA Change-Id: Iada489bc248d3d3de7f4c942ce3251fca1e6124e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-optimizer/ovirt-optimizer_standard.yaml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iada489bc248d3d3de7f4c942ce3251fca1e6124e Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: spec: dropped support for fedora < 23
by Code Review 20 Mar '17

20 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: dropped support for fedora < 23 ...................................................................... packaging: spec: dropped support for fedora < 23 Fedora 23 has gone EOL long ago. Change-Id: I7dcbf40678678b506aebd0f20571f365aa8e0875 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7dcbf40678678b506aebd0f20571f365aa8e0875 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: spec: move to headless java
by Code Review 20 Mar '17

20 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: move to headless java ...................................................................... packaging: spec: move to headless java ovirt-engine doesn't really need full java-openjdk. Moving from java-openjdk to java-openjdk-headless. Change-Id: I83430cc63af11eab564cfd1dbc7d5364cca92030 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83430cc63af11eab564cfd1dbc7d5364cca92030 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: spec: move to headless java
by Code Review 20 Mar '17

20 Mar '17

>From Shirly Radco <sradco(a)redhat.com>: Shirly Radco has submitted this change and it was merged. Change subject: packaging: spec: move to headless java ...................................................................... packaging: spec: move to headless java ovirt-dwh doesn't really need full java-openjdk. Moving from java-openjdk to java-openjdk-headless. Change-Id: If758f69a7e95b00c991d96b1b1cf0ebd1ae7bf3e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine-dwh.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Shirly Radco: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74260 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If758f69a7e95b00c991d96b1b1cf0ebd1ae7bf3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Einav Cohen <co.einav(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0