May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove redundant exception declaration in MoveOrCopyDi...
by Code Review 25 May '17

25 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Remove redundant exception declaration in MoveOrCopyDiskCommandTest ...................................................................... core: Remove redundant exception declaration in MoveOrCopyDiskCommandTest Having a 'throws Exception' declaration on a test method is redundant Change-Id: Iceb13532f17766c319b54ab1f3e07bf49b0badc2 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommandTest.java 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77341 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iceb13532f17766c319b54ab1f3e07bf49b0badc2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[v2.1.z]: build: ovirt-hosted-engine-ha-2.1.1
by Code Review 25 May '17

25 May '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-2.1.1 ...................................................................... build: ovirt-hosted-engine-ha-2.1.1 Change-Id: I6f2ebf670125d2c3e25da891e850fbef7c2e0ff9 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 7 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77348 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f2ebf670125d2c3e25da891e850fbef7c2e0ff9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.1.z Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: build: post ovirt-hosted-engine-setup-2.1.1
by Code Review 25 May '17

25 May '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-2.1.1 ...................................................................... build: post ovirt-hosted-engine-setup-2.1.1 Change-Id: I163ab4a0e666b82f447ed5289bdec041b0b9c3a6 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 11 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I163ab4a0e666b82f447ed5289bdec041b0b9c3a6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: build: ovirt-hosted-engine-setup-2.1.1
by Code Review 25 May '17

25 May '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-2.1.1 ...................................................................... build: ovirt-hosted-engine-setup-2.1.1 Change-Id: If4f8a9165178efbec49f8b7c4b3721ff7f65460d Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4f8a9165178efbec49f8b7c4b3721ff7f65460d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: appliance: allow two distinct appliance names
by Code Review 25 May '17

25 May '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: appliance: allow two distinct appliance names ...................................................................... appliance: allow two distinct appliance names hosted-engine --upgrade-appliance is mainly tested for 3.6/el6->4.0/el7; other upgrade flows could be simply achieved directly upgrading the engine rpms inside the engine VM. In this optic, having the capability to handle two different appliance rpm names for 4.0 and current one could be a nice to have. Change-Id: Ic994db3e07912ccad05827e7893d9cd6d8a6912c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1449557 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M configure.ac M src/ovirt_hosted_engine_setup/Makefile.am M src/ovirt_hosted_engine_setup/config.py.in M src/ovirt_hosted_engine_setup/constants.py M src/plugins/gr-he-common/vm/boot_disk.py 5 files changed, 22 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic994db3e07912ccad05827e7893d9cd6d8a6912c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: appliance: allow two distinct appliance names
by Code Review 25 May '17

25 May '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: appliance: allow two distinct appliance names ...................................................................... appliance: allow two distinct appliance names hosted-engine --upgrade-appliance is mainly tested for 3.6/el6->4.0/el7; other upgrade flows could be simply achieved directly upgrading the engine rpms inside the engine VM. In this optic, having the capability to handle two different appliance rpm names for 4.0 and current one could be a nice to have. Change-Id: Ic994db3e07912ccad05827e7893d9cd6d8a6912c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1449557 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M configure.ac M src/ovirt_hosted_engine_setup/Makefile.am M src/ovirt_hosted_engine_setup/config.py.in M src/ovirt_hosted_engine_setup/constants.py M src/plugins/gr-he-common/vm/boot_disk.py 5 files changed, 22 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77280 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic994db3e07912ccad05827e7893d9cd6d8a6912c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: search: fix tags/values with underscore behaviour
by Code Review 25 May '17

25 May '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: search: fix tags/values with underscore behaviour ...................................................................... search: fix tags/values with underscore behaviour This patch fixes a regression caused by [1] that attempts to resolve [2] The fix caused tags including an "_" attached to Host or VM not to work. The problem was that the [1] patch put "\" before "_" not only for a condition with LIKE/ILIKE but also for "=" condition which cause the search to return empty results. The problem is that we have generated queries with ILIKE/LIKE in two forms : 1) <field> LIKE/ILIKE <value> 2) <value> LIKE/ILIKE ANY (string_to_array ...... [1] https://gerrit.ovirt.org/#/c/69926 [2] https://bugzilla.redhat.com/show_bug.cgi?id=1409849 Change-Id: I3d8e2075f99ce2600e64bd996280c68feb8f3fa0 Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1446525 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java 3 files changed, 4 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d8e2075f99ce2600e64bd996280c68feb8f3fa0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Use font-awesome icons
by Code Review 25 May '17

25 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: inventory: Use font-awesome icons ...................................................................... inventory: Use font-awesome icons Instead of mix 'passed' string and icons, let's use icons as well for the validated checks. Change-Id: I51cd890ff243070dee9de24da4946759ffd731b4 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh 2 files changed, 7 insertions(+), 12 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51cd890ff243070dee9de24da4946759ffd731b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-iso-uploader[master]: config.py: make flake8 happy
by Code Review 25 May '17

25 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: config.py: make flake8 happy ...................................................................... config.py: make flake8 happy fix E222 multiple spaces after operator Change-Id: Ifa2949b6661602a334beaedf83237f86016a2249 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/config.py.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa2949b6661602a334beaedf83237f86016a2249 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : Hide tracebacks in engine.log by upgrading non resp...
by Code Review 25 May '17

25 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine : Hide tracebacks in engine.log by upgrading non responsive host ...................................................................... engine : Hide tracebacks in engine.log by upgrading non responsive host All host exceptions should be in debug logs, only the root cause messages should be in normal engine logs. Change-Id: Ide61e78e46643cbabcb71239d5fdf820fe345dcc Bug-Url: https://bugzilla.redhat.com/1414787 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployBase.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/LoggedUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/log/LoggedUtilsTest.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FutureVDSCommand.java 8 files changed, 44 insertions(+), 23 deletions(-) Approvals: Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77260 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide61e78e46643cbabcb71239d5fdf820fe345dcc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0