Change in ovirt-engine[master]: core: Fix test in updateVmDiskCommand
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/78875 )
Change subject: core: Fix test in updateVmDiskCommand
......................................................................
core: Fix test in updateVmDiskCommand
the validation which checks whether no amend and extend run together
does not run the command validate method.
Fixing the test to test it properly.
Change-Id: I748da61b43fb360bc3f205d4ed121be49c089781
Bug-Url: https://bugzilla.redhat.com/1464766
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/78875
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I748da61b43fb360bc3f205d4ed121be49c089781
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: refactor images list to avoid multiple DB fetch.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/78674 )
Change subject: core: refactor images list to avoid multiple DB fetch.
......................................................................
core: refactor images list to avoid multiple DB fetch.
To avoid multiple fetch of disk images from the DB, this patch adds a
lazy initializer for those images.
Change-Id: I0017efe2532d3c41f415e8986c10dce0d049dd0f
Bug-Url: https://bugzilla.redhat.com/1464766
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/78674
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0017efe2532d3c41f415e8986c10dce0d049dd0f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: Update amend validation of RAW volumes in a disk.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/78876 )
Change subject: core: Update amend validation of RAW volumes in a disk.
......................................................................
core: Update amend validation of RAW volumes in a disk.
A more proper way to validate if a disk contains only RAW volumes
on amend, is to check whether a QCOW compat value has been passed in the
parameters.
The change of the validation is neccessery since the following patches which
change amendRequested might exclude this validation.
Change-Id: I5d4102af0926961c874057b7f6ffb721751f4841
Bug-Url: https://bugzilla.redhat.com/1464766
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/78876
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d4102af0926961c874057b7f6ffb721751f4841
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: Check all volumes for their QCOW format.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/78675 )
Change subject: core: Check all volumes for their QCOW format.
......................................................................
core: Check all volumes for their QCOW format.
Since amend might fail in the middle of an operation, some volumes
might not be amended, therefore the engine should not check only the
active volume but all the disk's QCOW volumes.
Change-Id: I545686ff0b368c6062d392ba24c36e7d14eb24dc
Bug-Url: https://bugzilla.redhat.com/1464766
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendImageGroupVolumesCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java
3 files changed, 14 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/78675
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I545686ff0b368c6062d392ba24c36e7d14eb24dc
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: Add audit entry with cold merge info
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/78628 )
Change subject: core: Add audit entry with cold merge info
......................................................................
core: Add audit entry with cold merge info
In commit 2420937 (cold-merge: Update step message to include the host
name), we added merge info, mainly the host running the merge job, to
the step message. In this patch, we introduce a mechanism to add an
audit log entry.
In order to add an audit log entry:
1. An audit log type with same step enum name must be added to
AuditLogType.java
2. A message must be added to AuditLogMessages.properties. The arguments of
the message must fit those in the message of the step enum. Usually,
the same message is used
For example, for cold merge we previously added MERGE_SNAPSHOTS_ON_HOST
in StepEnum. Now, we add MERGE_SNAPSHOTS_ON_HOST to AuditLogType.java and
add a corresponding message (actually same message created for the
step enum) in AuditLogMessages.properties.
Change-Id: I685e9d833e67aa9ef0ea9680cdbacc1cc318eef8
Bug-Url: https://bugzilla.redhat.com/1464795
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/VdsCommandsHelper.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 23 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/78628
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I685e9d833e67aa9ef0ea9680cdbacc1cc318eef8
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in jenkins[master]: Added he-system-test for master branch
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged. ( https://gerrit.ovirt.org/78670 )
Change subject: Added he-system-test for master branch
......................................................................
Added he-system-test for master branch
Change-Id: I1a8367e13f8e05d4cf9c0db39bcc4f5f0023da3c
Signed-off-by: Yuval Turgeman <yturgema(a)redhat.com>
---
M jobs/confs/projects/ovirt/system-tests.yaml
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Ready for merge
Yuval Turgeman: Verified
Daniel Belenky: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78670
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a8367e13f8e05d4cf9c0db39bcc4f5f0023da3c
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
6 years, 10 months
Change in ovirt-engine[master]: core: refactoring: Inject Async Operation dependencies
by Code Review
>From Martin Betak <mbetak(a)redhat.com>:
Martin Betak has submitted this change and it was merged. ( https://gerrit.ovirt.org/78820 )
Change subject: core: refactoring: Inject Async Operation dependencies
......................................................................
core: refactoring: Inject Async Operation dependencies
Change-Id: I13c0f5eb3eedc81d83d2715cde2e35e4ba1ac5b9
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AfterDeactivateSingleAsyncOperation.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AfterDeactivateSingleAsyncOperationFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ConnectVDSToPoolAndDomains.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/DisconnectStoragePoolAsyncOperation.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/DisconnectStoragePoolAsyncOperationFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RefreshPoolSingleAsyncOperation.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RefreshPoolSingleAsyncOperationFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RefreshStoragePoolAndDisconnectAsyncOperation.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RefreshStoragePoolAndDisconnectAsyncOperationFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java
10 files changed, 114 insertions(+), 44 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78820
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13c0f5eb3eedc81d83d2715cde2e35e4ba1ac5b9
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: Validate QCOW compat level with DC format on register.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/77707 )
Change subject: core: Validate QCOW compat level with DC format on register.
......................................................................
core: Validate QCOW compat level with DC format on register.
Add validation for QCOW compatibility version with Data Center format
version once disk is being registered.
Change-Id: I977f1ad51c8507aa7314e29ab7a1c702c5beb468
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RegisterDiskCommand.java
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/77707
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I977f1ad51c8507aa7314e29ab7a1c702c5beb468
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: cleanup in host device manager
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/78903 )
Change subject: core: cleanup in host device manager
......................................................................
core: cleanup in host device manager
Replace initialization related code with a bit more efficient one
that uses Java's stream.
Change-Id: I10dfb78ee3375bb35fcc853b2de9d9c41a8044b1
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sharon Gratch: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78903
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10dfb78ee3375bb35fcc853b2de9d9c41a8044b1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: cleanup in parsing of host devices
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/78906 )
Change subject: core: cleanup in parsing of host devices
......................................................................
core: cleanup in parsing of host devices
Change-Id: I6e7c6f6d9e2d0367117b760c6e83a9071b0670ac
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 7 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sharon Gratch: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78906
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e7c6f6d9e2d0367117b760c6e83a9071b0670ac
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months