Change in ovirt-engine[master]: core: Make StorageDomainType values static
From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Make StorageDomainType values static
......................................................................
core: Make StorageDomainType values static
StorageDomainType enum conversion values (for DB storage purposes) was
equal to the ordinal value of each enum, relying on the ordinal values is
error prone as introducing a new enum not at the end of the chain will
cause the ordinals of the enum coming after to shift.
This patch sets the conversion values of the enums in StorageDomainType to
static ones based on their current ordinal and from the static values
when converting
Change-Id: Id345876c05408cf45238bcb146d522ff29be0026
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainType.java
1 file changed, 26 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Benny Zlotnik: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69917
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id345876c05408cf45238bcb146d522ff29be0026
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>