Change in ovirt-engine[master]: hostdev: Fix cleanup treatment in RefreshHostDevicesCommand
Tomas Jelinek has submitted this change and it was merged.
Change subject: hostdev: Fix cleanup treatment in RefreshHostDevicesCommand
......................................................................
hostdev: Fix cleanup treatment in RefreshHostDevicesCommand
The host device refresh logic that clears up vm_devices for host_devices that
disappear from host incorrectly assumed that only one device with given name
will exist in the vm_device table, which was incorrect for multiple reasons
(one host_device attached to multiple VMs or device with same name from
different host).
Fixed by explicitly querying vm_device attachments only for current host and
removing all with given name.
Change-Id: I8f39599928195e9c485bf0e0a206caf6b821f580
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1312879
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDao.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoImpl.java
M packaging/dbscripts/host_device_sp.sql
4 files changed, 51 insertions(+), 9 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Martin Betak: Verified
Shmuel Leib Melamud: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/54612
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f39599928195e9c485bf0e0a206caf6b821f580
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>