Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: reimplemented engine_firewalld
......................................................................
packaging: reimplemented engine_firewalld
Reimplemented using the firewall-cmd command
instead of the python API, avoiding issues with dbus.
The firewall-cmd command will be used also in otopi based
rewrite of the engine-setup command.
Change-Id: Ie0d819c9607d4c99b3093e364ca504ae96acca36
Bug-Url:
https://bugzilla.redhat.com/924071
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/engine_firewalld.py
2 files changed, 42 insertions(+), 10 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/13589
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0d819c9607d4c99b3093e364ca504ae96acca36
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>