Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Send net_ifacename to VDSM when connecting iSCSI server ...................................................................... engine: Send net_ifacename to VDSM when connecting iSCSI server In order to properly configure iSCSI multipathing each iSCSI iface should be related to the real network interface. Software iSCSI knows how to relate iface to the network interface when all network interfaces on that host reside on different subnets see [1]. However if multiple NICs reside on the same subnet iSCSI iface configuration must contain a "iface.net_ifacename" representing a name of the network layer interface, in case this network is bridged then it should be a name of the bridge. [1] http://www.open-iscsi.org/docs/README section 5.1.1. Change-Id: I3e2f3549fa08741f719eeb8d70209ab298e09da3 Bug-Url: https://bugzilla.redhat.com/1112861 Signed-off-by: Sergey Gotliv <sgotliv@redhat.com> Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java 3 files changed, 24 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e2f3549fa08741f719eeb8d70209ab298e09da3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Amador Pahim <apahim@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <ykleinbe@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server