Change in ovirt-engine[master]: core: rm AddVmTemplateFromSnapshot useless method
Allon Mureinik has submitted this change and it was merged.
Change subject: core: rm AddVmTemplateFromSnapshot useless method
......................................................................
core: rm AddVmTemplateFromSnapshot useless method
Removed the redundant AddVmTemplateFromSnapshotCommand.getSnapshotDao()
method. The base class, AuditLogableBse, already has a getSnapshotDAO()
method and having another method with the same functionality and only a
difference in case is both redundant and confusing, as FindBugs warns
about.
Change-Id: I9c6bd54cb652fa79c40d9179dad2622e6968a858
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java
1 file changed, 2 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Allon Mureinik: Verified; Looks good to me, approved
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41825
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c6bd54cb652fa79c40d9179dad2622e6968a858
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org