Change in ovirt-engine[master]: core: Make windows time zone mapping maps private
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Make windows time zone mapping maps private
......................................................................
core: Make windows time zone mapping maps private
This is needed in order to avoid the following findbugs warning:
Field is a mutable collection which should be package protected
A mutable collection instance is assigned to a final static field,
thus can be changed by malicious code or by accident from another
package. The field could be made package protected to avoid this
vulnerability. Alternatively you may wrap this field into
Collections.unmodifiableSet/List/Map/etc. to avoid this vulnerability.
Bug kind and pattern: MS - MS_MUTABLE_COLLECTION_PKGPROTECT
Change-Id: I812de9ba3e9aa19ac4ede4d1d39bef8ecfd50356
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/TimeZoneTypeTest.java
M
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/WindowsJavaTimezoneMapping.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VmStatusCell.java
4 files changed, 14 insertions(+), 5 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46618
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I812de9ba3e9aa19ac4ede4d1d39bef8ecfd50356
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org