Change in ovirt-engine[master]: core: Unify connect/disconnect storage methods in StorageDom...
From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Unify connect/disconnect storage methods in
StorageDomainCommandBase
......................................................................
core: Unify connect/disconnect storage methods in StorageDomainCommandBase
The logic of disconnect and connect storage to hosts in up status is
almost identical with the exception of the command type called in the
storage helper class and the log printed, having both methods contain the
same code makes it harder to maintain as every change is likely to be done
in both methods at once.
This patch extracts the logic to a single method to prevent the
boilerplate code
Change-Id: I0f034150ccbcddfff4ef5342789ec3871f6677c7
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
1 file changed, 10 insertions(+), 26 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69873
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f034150ccbcddfff4ef5342789ec3871f6677c7
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>