Allon Mureinik has submitted this change and it was merged. Change subject: core: VmValidator#vmNotHavingPassthroughVnics replacements ...................................................................... core: VmValidator#vmNotHavingPassthroughVnics replacements Calculate the list of replacement strings only if needed. This patch improves the code's readability by emphasizing that the replacements are only used in an error case, and offers a [very] slight performance improvement in the non-error case. Change-Id: I4f3c285c5195c369101f9b09b7e9c2867d911a31 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f3c285c5195c369101f9b09b7e9c2867d911a31 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>