Change in ovirt-engine[master]: core: StorageHandlingCommandBase#isDomainExistsInDiskDescrip...
Allon Mureinik has submitted this change and it was merged.
Change subject: core: StorageHandlingCommandBase#isDomainExistsInDiskDescription
......................................................................
core: StorageHandlingCommandBase#isDomainExistsInDiskDescription
Simplified method call by using Objects.toString with a default instead
of explicitly checking for nulls.
Besides shortening the code and making it more fluid to read, this patch
offers a minor performance improvement as
map.get(OvfInfoFileConstants.Domains) is now only called once, but it's
doubtful that this improvement will be noticeable in any reasonable
(or, frankly, unreasonable) setup.
Change-Id: I3de0cf7eae0926d650f2c6b8064c30c03a919cca
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/48588
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3de0cf7eae0926d650f2c6b8064c30c03a919cca
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>