Change in ovirt-engine[master]: core: GetErrataCountsForHostQueryTest setup order
Allon Mureinik has submitted this change and it was merged.
Change subject: core: GetErrataCountsForHostQueryTest setup order
......................................................................
core: GetErrataCountsForHostQueryTest setup order
AbstractQueryTest contains a setUp() (note the upper case U) method
annotated with @Before, and this class introduced a setup() (note the
lower case u) method also annotated with @Before.
This causes the class to have two @Before methods which may cause test
failures as JUnit does nto assure any order between multiple
initializers.
This patch renames the method to setUp() and explicitly calls super's
method in order to make the test's execution deterministically and
prevent potential test failures.
Note: This patch solves Coverity CID 1292837.
Change-Id: Ibcfebf5ddbebc9cc2e4a613841b2d870fd6fc1f0
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetErrataCountsForHostQueryTest.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/44626
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcfebf5ddbebc9cc2e4a613841b2d870fd6fc1f0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org