From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: Cold Merge: Support cold merge flow
......................................................................
Cold Merge: Support cold merge flow
Today, cold merge uses qemuimg rebase. In not too few cases, this
operation takes a long time as data is copied from base volume to top
volume. We want to use qemuimg commit for cold merge to enhance
performance and to better control the flow at the engine. New cold merge
flow will perform the following steps:
1. Prepare (for) merge
Prepare merge will calculate the required allocation for base volume,
extend the base volume and mark it as ILLEGAL.
This operation must be run on the SPM.
2. Merge
Use qemuimg commit to do the merge.
This is an SDM job that runs on any host.
3. Finalize merge
Finalize will update qemu chain and vdsm chain to reflect the new
chain after the merge.
This operation must be run on the SPM.
4. Destroy image
After mergre successfully completed, top volume is removed.
Change-Id: I35b3eac85f8546f0c412783f0b2dc58fb0288085
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/ColdMergeSnapshotSingleDiskCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskLiveCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveSnapshotSingleDiskParameters.java
R
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveSnapshotSingleDiskStep.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
7 files changed, 163 insertions(+), 62 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Ala Hino: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/66992
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I35b3eac85f8546f0c412783f0b2dc58fb0288085
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>