Change in ovirt-engine[master]: core: VM is down check when adding template
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VM is down check when adding template
......................................................................
core: VM is down check when adding template
AddTemplateCommand explicitly checks if the VM is down in the
canDoAction, so there is no need to recheck it again by passing true to
the relevant argument of PerformImagesChecks.
This patch contains the proposed fix, a test for it, and a minor
refactor required to facilitate the test.
Note: This patch is part of a series intended to remove the VM status
check from ImagesHandler.
Change-Id: Ifec2d9677765502ca6876b31835340d3c4fad5ae
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
A
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java
2 files changed, 93 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifec2d9677765502ca6876b31835340d3c4fad5ae
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>