Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix of Import VMs dialog
......................................................................
webadmin: Fix of Import VMs dialog
* Previously when there was no Data Center in state up, it was still
possible to press "Load" button which caused FE exception. This
patch binds enabled/disabled state of load button to enabled/disabled
state of Data Center drop down to prevent that.
* Load button to import VMs from external domain is now disabled when
there is not external domain. Previously it was enabled all the time
and clicking it without export domain caused frontend exception.
* Error and warning panel shows relevant info right after opening the
dialog. Previously there were no message after the dialog was opened
and messages were updated when "Source" dropbox was changed.
Change-Id: I168b4c24ae3c75d30366561d9ea61941c827eae6
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
Bug-Url:
https://bugzilla.redhat.com/1336828
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandButton.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/ImportVmsPopupPresenterWidget.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java
4 files changed, 93 insertions(+), 14 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/58268
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I168b4c24ae3c75d30366561d9ea61941c827eae6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.7
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>