Change in ovirt-engine[master]: core: ImportVm test cleanup: property generation
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImportVm test cleanup: property generation
......................................................................
core: ImportVm test cleanup: property generation
Added new functionality to RandomUtils to randomly generate Strings that
are valid property strings (i.e., may contain the characters a-z, A-Z,
0-9,"_" and "."), and used it in the test instead of the hard coded
string100 and string5000 variables.
A RandomUtilsSeedingRule was also added to the test to make this
pseudo-random output predictable, or at least reproducible.
Change-Id: I1f04e067e8bce2c6cd1010f83a44809a3c8c464c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/RandomUtils.java
2 files changed, 42 insertions(+), 30 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f04e067e8bce2c6cd1010f83a44809a3c8c464c
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>