Change in ovirt-engine[master]: engine: reuse of existingAttachments data memeber
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: reuse of existingAttachments data memeber
......................................................................
engine: reuse of existingAttachments data memeber
In the begining of the 'HostSetupNetwork.validate()' there
is completion of the 'existingAttachments' data member
and the 'parameters' of the command.
Therefore, if two attachments are the same (existing and
the one in the parameters), the comparison will be able to
detact it. However, if when doing the comparison new version of the
existing attachments is used (fetch new version from the db), the
comparison will fails, since the exisiting attachments may have missing
data (that the completaion should fix).
Change-Id: I33cbf93c00c0e0dd9bab9c218b6472a4a4723c11
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Verified; Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/54838
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I33cbf93c00c0e0dd9bab9c218b6472a4a4723c11
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>