Change in ovirt-engine[master]: core: CommandBase - Parent may run the child commands endAct...
Liron Aravot has submitted this change and it was merged.
Change subject: core: CommandBase - Parent may run the child commands endAction()
......................................................................
core: CommandBase - Parent may run the child commands endAction()
Command Coordinator commands may track commands with tasks and want to
execute their endSuccesfully()/endWithFailure() methods independently
and not when the task execution ends.
If the parent command has a callback (as this change is introduced to be
used with the CoCo framework only), the set value in VdcActionParametersBase
will be checked to determine how to proceed, if needed the command endAction()
method will be executed otherwise it'll be logged that the parent
command should end the child command.
Change-Id: I84820416344dd87626eb0805c3c273ee47b95cb7
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConcurrentChildCommandsExecutionCallback.java
3 files changed, 70 insertions(+), 30 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50494
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84820416344dd87626eb0805c3c273ee47b95cb7
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>