Change in ovirt-engine[master]: core: can not migrate vm using REST
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: can not migrate vm using REST
......................................................................
core: can not migrate vm using REST
The regression introduced by 7d5f94d4c79ebc93cdfe08a7709a6411dda8fce7
The issue is that if the getParameters().getTargetClusterId() is null it means
that the target cluster id is not set meaning the cluster did not change.
In this case the additional permission does not have to be added.
The problem was that if the getTargetClusterId was null the Objects.equals
returned false so the additional permission has been added in a way that you
need permission to create_vm on the cluster: null which did not pass.
Change-Id: Ia0d6201c3d095beebffb47a6fb6beab5e5684b6f
Bug-Url: https://bugzilla.redhat.com/1328011
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56287
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0d6201c3d095beebffb47a6fb6beab5e5684b6f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>