Martin Sivák has submitted this change and it was merged.
Change subject: broker, agent: more robust service startup/shutdown
......................................................................
broker, agent: more robust service startup/shutdown
The agent and broker had no ordering, and there was no way for an
external program to reliably tell when the broker was ready to
serve requests.
With this change:
- The agent and broker services gain an ordering dependency between
them in systemd.
- The broker attempts to clean its socket file upon exit, so that the
existence of the file generally indicates that the broker is ready
to serve requests.
- The agent will be more patient in attempting to connect to the broker.
Change-Id: I392ddf54503d7b9ef3448d22385b547222c0cc86
Bug-Url:
https://bugzilla.redhat.com/1018829
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M initscripts/ovirt-ha-agent.init.in
M initscripts/ovirt-ha-agent.service
M ovirt_hosted_engine_ha/agent/constants.py.in
M ovirt_hosted_engine_ha/agent/hosted_engine.py
M ovirt_hosted_engine_ha/broker/broker.py
M ovirt_hosted_engine_ha/broker/listener.py
M ovirt_hosted_engine_ha/lib/brokerlink.py
7 files changed, 48 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/20561
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I392ddf54503d7b9ef3448d22385b547222c0cc86
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server