Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Edit Network dialog fixes (#821021) ...................................................................... webadmin: Edit Network dialog fixes (#821021) https://bugzilla.redhat.com/821021 This bugfix patch includes: - DataCenterNetworkListModel.Edit() now uses null instead of empty string for undefined MTU value, this avoids NumberFormatException when DataCenterNetworkListModel tries to parse this (non-null) value later on - DataCenterNetwork presenter widget now enables/disables dialog input fields properly, in reaction to dialog model (DataCenterNetworkModel) "IsEnabled" property changes - Fixed "Detach all clusters" button failing due to corresponding UICommand being null (this command is set after setWindow() happens and therefore needs to be referenced through its model directly) Change-Id: I5b73073200159141b4b159db83c37ffc4daa33d1 Signed-off-by: Vojtech Szocs <vszocs@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/DataCenterNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterNetworkPopupView.java 3 files changed, 14 insertions(+), 14 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b73073200159141b4b159db83c37ffc4daa33d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com>