Allon Mureinik has submitted this change and it was merged.
Change subject: core: DBConfigUtils dependent values with defaults
......................................................................
core: DBConfigUtils dependent values with defaults
The DBConfigUtils implementation for dependent config values searched
for the dependent value in the cache, causing it to fail if that value
was not present in the database.
This patch changes the explicit retrieval from the cache with a
getValue call, thus allowing dependent values to use the default value
if there is no value in the database.
Change-Id: I2f822255ddb91974ea238c1e85747b36d68b0bf1
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtilsTest.java
2 files changed, 17 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/65023
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f822255ddb91974ea238c1e85747b36d68b0bf1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>